From patchwork Mon Oct 28 05:34:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 13853022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 497B0D13570 for ; Mon, 28 Oct 2024 05:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=0facqVfAEouuGzsKo4Jo+f3CW4RYeZOcdEu1i5H0A0I=; b=dvYR5p54zVmIJDtRSwKZyLfLCe MoIVCTbKgfRmYAVpkpMT8/YeiKxATFYwf4KH6qpqoedLeNnBQO7hy13KxaM5hrezpntsht1WGm0DA clfR9KAXdkqP6gaBfjaTF/hJL9KUEn4rokgsOv62m6sq4YxD9CX6mDNkZ6Q2hhRGPr0nV9GqLQz6w P9heGqGKdLxMcEWd11f/i5UGmW0o0xbGIDuHAMWD/cc128Z7mlKCEZ5OYuXfbPMvwxu2ks8I3mHVb KhgC1x6jA6vBCsLuj7WqqQlhcKzv6nyY4pv0FgkjfYM1Mw5eVOCi/984zTixYfBVNcMI75Zy33mKn 24e6MD7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t5IUL-00000009dA3-1HfY; Mon, 28 Oct 2024 05:40:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t5IOn-00000009bUm-08JA for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2024 05:34:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C16FE497; Sun, 27 Oct 2024 22:35:07 -0700 (PDT) Received: from a077893.blr.arm.com (a077893.blr.arm.com [10.162.16.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7D7D03F66E; Sun, 27 Oct 2024 22:34:34 -0700 (PDT) From: Anshuman Khandual To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anshuman Khandual , Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown , Mark Rutland , kvmarm@lists.linux.dev Subject: [PATCH V2 0/7] arm64/hw_breakpoint: Enable FEAT_Debugv8p9 Date: Mon, 28 Oct 2024 11:04:19 +0530 Message-Id: <20241028053426.2486633-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241027_223441_181270_8D623F0F X-CRM114-Status: UNSURE ( 8.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series enables FEAT_Debugv8p9 thus extending breakpoint and watchpoint support upto 64. This series is based on v6.12-rc5 although this depends on FEAT_FGT2 FGU series posted earlier, for MDSELR_EL1 handling in various KVM guest configurations. https://lore.kernel.org/all/20241001024356.1096072-1-anshuman.khandual@arm.com/ Cc: Jonathan Corbet Cc: Marc Zyngier Cc: Oliver Upton Cc: James Morse Cc: Suzuki K Poulose Cc: Catalin Marinas Cc: Will Deacon Cc: Mark Brown Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org Cc: kvmarm@lists.linux.dev Cc: linux-kernel@vger.kernel.org Changes in V2: Following changes have been made per review comments from Mark Rutland - Orr MDCR_EL2_EBWE directly without an intermittent register - Alphabetically order header files in debug-monitors.c - Dropped embwe_ref_count mechanism - Dropped preempt_enable() from AARCH64_DBG_READ - Dropped preempt_disable() from AARCH64_DBG_WRITE - Dropped set_bank_index() - Renamed read/write_wb_reg() as __read/__write_wb_reg() - Modified read/write_wb_reg() to have MDSELR_E1 based banked read/write - Added required sysreg tools patches from KVM FEAT_FGT2 series for build Changes in V1: https://lore.kernel.org/all/20241001043602.1116991-1-anshuman.khandual@arm.com/ - Changed FTR_STRICT to FTR_NONSTRICT for the following ID_AA64DFR1_EL1 register fields - ABL_CMPs, DPFZS, PMICNTR, CTX_CMPs, WRPs and BRPs Changes in RFC V2: https://lore.kernel.org/linux-arm-kernel/20240620092607.267132-1-anshuman.khandual@arm.com/ - This series has been split from RFC V1 dealing only with arm64 breakpoints - Restored back DBG_MDSCR_MASK definition (unrelated change) - Added preempt_disable()/enable() blocks between selecting banks and registers Changes in RFC: https://lore.kernel.org/all/20240405080008.1225223-1-anshuman.khandual@arm.com/ Anshuman Khandual (7): arm64/sysreg: Update register fields for ID_AA64MMFR0_EL1 arm64/sysreg: Add register fields for MDSELR_EL1 arm64/sysreg: Add register fields for HDFGRTR2_EL2 arm64/sysreg: Add register fields for HDFGWTR2_EL2 arm64/cpufeature: Add field details for ID_AA64DFR1_EL1 register arm64/boot: Enable EL2 requirements for FEAT_Debugv8p9 arm64/hw_breakpoint: Enable FEAT_Debugv8p9 Documentation/arch/arm64/booting.rst | 19 +++++++ arch/arm64/include/asm/debug-monitors.h | 1 + arch/arm64/include/asm/el2_setup.h | 26 +++++++++ arch/arm64/include/asm/hw_breakpoint.h | 46 ++++++++++++---- arch/arm64/include/asm/kvm_arm.h | 1 + arch/arm64/kernel/cpufeature.c | 21 ++++++-- arch/arm64/kernel/debug-monitors.c | 15 ++++-- arch/arm64/kernel/hw_breakpoint.c | 38 +++++++++++++- arch/arm64/tools/sysreg | 70 +++++++++++++++++++++++++ 9 files changed, 216 insertions(+), 21 deletions(-)