[net-next,v4,0/9] Support external snapshots on dwmac1000

Message

Maxime Chevallier Nov. 12, 2024, 5:06 p.m. UTC

Hi,

This is v4 on the series to support external snapshots on dwmac1000.

The main change since v3 is the move of the fifo flush wait in the
ptp_clock_info enable() function within the mutex that protects the ptp
registers. Thanks Jakub and Paolo for spotting this.

This series also aggregates Daniel's reviews, except for the patch 4
which was modified since then.

This series is another take on the previous work [1] done by
Alexis Lothoré, that fixes the support for external snapshots
timestamping in GMAC3-based devices.

Details on why this is needed are mentionned on the cover [2] from V1.

[1]: https://lore.kernel.org/netdev/[e-mail]/
[2]: https://lore.kernel.org/netdev/[e-mail]/

Thanks Alexis for laying the groundwork for this,

Best regards,

Maxime

Link to V1: https://lore.kernel.org/netdev/[e-mail]/
Link to V2: https://lore.kernel.org/netdev/[e-mail]/
Link to V3: https://lore.kernel.org/netdev/[e-mail]/

Maxime Chevallier (9):
  net: stmmac: Don't modify the global ptp ops directly
  net: stmmac: Use per-hw ptp clock ops
  net: stmmac: Only update the auto-discovered PTP clock features
  net: stmmac: Introduce dwmac1000 ptp_clock_info and operations
  net: stmmac: Introduce dwmac1000 timestamping operations
  net: stmmac: Enable timestamping interrupt on dwmac1000
  net: stmmac: Don't include dwmac4 definitions in stmmac_ptp
  net: stmmac: Configure only the relevant bits for timestamping setup
  net: stmmac: dwmac_socfpga: This platform has GMAC

 drivers/net/ethernet/stmicro/stmmac/common.h  |   4 +
 .../ethernet/stmicro/stmmac/dwmac-socfpga.c   |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac1000.h   |  12 +++
 .../ethernet/stmicro/stmmac/dwmac1000_core.c  | 101 ++++++++++++++++++
 drivers/net/ethernet/stmicro/stmmac/hwif.c    |  15 ++-
 .../ethernet/stmicro/stmmac/stmmac_hwtstamp.c |  26 ++++-
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  38 +++++--
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.h  |  10 ++
 8 files changed, 196 insertions(+), 11 deletions(-)

Comments

[e-mail] Nov. 14, 2024, 3 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Tue, 12 Nov 2024 18:06:48 +0100 you wrote:
> Hi,
> 
> This is v4 on the series to support external snapshots on dwmac1000.
> 
> The main change since v3 is the move of the fifo flush wait in the
> ptp_clock_info enable() function within the mutex that protects the ptp
> registers. Thanks Jakub and Paolo for spotting this.
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/9] net: stmmac: Don't modify the global ptp ops directly
    https://git.kernel.org/netdev/net-next/c/80dc1ff787a9
  - [net-next,v4,2/9] net: stmmac: Use per-hw ptp clock ops
    https://git.kernel.org/netdev/net-next/c/13e908800c0d
  - [net-next,v4,3/9] net: stmmac: Only update the auto-discovered PTP clock features
    https://git.kernel.org/netdev/net-next/c/0bfd0afc746c
  - [net-next,v4,4/9] net: stmmac: Introduce dwmac1000 ptp_clock_info and operations
    https://git.kernel.org/netdev/net-next/c/8e7620726beb
  - [net-next,v4,5/9] net: stmmac: Introduce dwmac1000 timestamping operations
    https://git.kernel.org/netdev/net-next/c/477c3e1f6363
  - [net-next,v4,6/9] net: stmmac: Enable timestamping interrupt on dwmac1000
    https://git.kernel.org/netdev/net-next/c/774f57d6562d
  - [net-next,v4,7/9] net: stmmac: Don't include dwmac4 definitions in stmmac_ptp
    https://git.kernel.org/netdev/net-next/c/85cebb7279e8
  - [net-next,v4,8/9] net: stmmac: Configure only the relevant bits for timestamping setup
    https://git.kernel.org/netdev/net-next/c/62935443214e
  - [net-next,v4,9/9] net: stmmac: dwmac_socfpga: This platform has GMAC
    https://git.kernel.org/netdev/net-next/c/b818268d9250

You are awesome, thank you!