| Message ID | 20241113-add-display-support-for-qcs615-platform-v2-0-2873eb6fb869@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add display support for QCS615 platform | expand |
On Wed, 13 Nov 2024 at 13:52, Fange Zhang <quic_fangez@quicinc.com> wrote: > > This series aims to enable display on the QCS615 platform > > 1.Add MDSS & DPU support for QCS615 > 2.Add DSI support for QCS615 Please don't send next iterations until the discussion on the previous one has finished. > > Note: > items still being confirmed > - missing reg_bus_bw > - missing refgen supply So, NAK, I'll wait for v3 after concluding discussion on v1. > > This patch series depends on below patch series: > - rpmhcc > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-2-3d716ad0d987@quicinc.com/ > - gcc > https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-4-3d716ad0d987@quicinc.com/ > - base > https://lore.kernel.org/all/20241104-add_initial_support_for_qcs615-v5-0-9dde8d7b80b0@quicinc.com/ > - Apps SMMU > https://lore.kernel.org/all/20241105032107.9552-4-quic_qqzhou@quicinc.com/ > - I2C > https://lore.kernel.org/all/20241111084331.2564643-1-quic_vdadhani@quicinc.com/ > - dispcc > https://lore.kernel.org/all/20241108-qcs615-mm-clockcontroller-v3-0-7d3b2d235fdf@quicinc.com/ > - dispcc dts > https://lore.kernel.org/lkml/20241108-qcs615-mm-dt-nodes-v1-0-b2669cac0624@quicinc.com/ > > Signed-off-by: Li Liu <quic_lliu6@quicinc.com> > Signed-off-by: Fange Zhang <quic_fangez@quicinc.com> > --- > Changes in v2: > - Added b4 check and check passed Added where? > - Added necessary blank line where? > - Added correct S-o-B > - Added correct maintainer > - Added correct To&Cc where? Is it a change to the patch? > - Added QCS615 DP controller comment in commit message > - Added comments for dsi_dp_hpd_cfg_pins and dsi_dp_cdet_cfg_pins > - Added missing port@1 for connector > - Changed patch order > - Changed 0 to QCOM_ICC_TAG_ALWAYS for mdss interconnects > - Changed 0 to GPIO_ACTIVE_HIGH for GPIO flags > - Fix indent issue > - Fix sorted issue This is not descibing the changes at all. Please take a look how other changelogs are formatted and what is actually being described. > - Moved anx_7625 to same node > - Moved status to last > - Renamed dsi0_hpd_cfg_pins to dsi_dp_hpd_cfg_pins > - Renamed dsi0_cdet_cfg_pins to dsi_dp_cdet_cfg_pins > - Renamed anx_7625_1 to dsi_anx_7625 > - Removed extra blank line > - Removed absent block > - Removed merge_3d value > - Removed redundant annotation > - Removed unsupported dsi clk in dsi0_opp_table > - Removed dp_hpd_cfg_pins node > - Splited patch according to requirements > - Link to v2: https://lore.kernel.org/r/20241014-add_display_support_for_qcs615-v1-0-4efa191dbdd4@quicinc.com > > --- > Li Liu (9): > dt-bindings: display/msm: Add QCS615 DSI phy > dt-bindings: display/msm: dsi-controller-main: Document QCS615 > dt-bindings: display/msm: Add QCS615 MDSS & DPU > drm/msm/dpu: Add QCS615 support > drm/msm: mdss: Add QCS615 support > drm/msm/dsi: Add support for QCS615 > arm64: dts: qcom: Add display support for QCS615 > arm64: dts: qcom: Add display support for QCS615 RIDE board > arm64: defconfig: Enable SX150X for QCS615 ride board > > .../bindings/display/msm/dsi-controller-main.yaml | 1 + > .../bindings/display/msm/dsi-phy-14nm.yaml | 1 + > .../bindings/display/msm/qcom,qcs615-dpu.yaml | 118 +++++++++ > .../bindings/display/msm/qcom,qcs615-mdss.yaml | 252 ++++++++++++++++++++ > arch/arm64/boot/dts/qcom/qcs615-ride.dts | 109 +++++++++ > arch/arm64/boot/dts/qcom/qcs615.dtsi | 186 ++++++++++++++- > arch/arm64/configs/defconfig | 1 + > .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_3_qcs615.h | 263 +++++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 17 ++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 21 ++ > drivers/gpu/drm/msm/msm_mdss.c | 7 + > 17 files changed, 982 insertions(+), 1 deletion(-) > --- > base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a > change-id: 20241112-add-display-support-for-qcs615-platform-674ed6c8e150 > prerequisite-message-id: <20241022-qcs615-clock-driver-v4-2-3d716ad0d987@quicinc.com> > prerequisite-patch-id: cd9fc0a399ab430e293764d0911a38109664ca91 > prerequisite-patch-id: 07f2c7378c7bbd560f26b61785b6814270647f1b > prerequisite-patch-id: a57054b890d767b45cca87e71b4a0f6bf6914c2f > prerequisite-patch-id: 5a8e9ea15a2c3d60b4dbdf11b4e2695742d6333c > prerequisite-message-id: <20241022-qcs615-clock-driver-v4-4-3d716ad0d987@quicinc.com> > prerequisite-patch-id: cd9fc0a399ab430e293764d0911a38109664ca91 > prerequisite-patch-id: 07f2c7378c7bbd560f26b61785b6814270647f1b > prerequisite-patch-id: a57054b890d767b45cca87e71b4a0f6bf6914c2f > prerequisite-patch-id: 5a8e9ea15a2c3d60b4dbdf11b4e2695742d6333c > prerequisite-message-id: <20241104-add_initial_support_for_qcs615-v5-0-9dde8d7b80b0@quicinc.com> > prerequisite-patch-id: 09782474af7eecf1013425fd34f9d2f082fb3616 > prerequisite-patch-id: 04ca722967256efddc402b7bab94136a5174b0b9 > prerequisite-patch-id: 82481c82a20345548e2cb292d3098ed51843b809 > prerequisite-patch-id: 3bd8edd83297815fcb1b81fcd891d3c14908442f > prerequisite-patch-id: fc1cfec4ecd56e669c161c4d2c3797fc0abff0ae > prerequisite-message-id: <20241105032107.9552-4-quic_qqzhou@quicinc.com> > prerequisite-patch-id: aaa7214fe86fade46ae5c245e0a44625fae1bad3 > prerequisite-patch-id: 4db9f55207af45c6b64fff4f8929648a7fb44669 > prerequisite-patch-id: 89ce719a863bf5e909989877f15f82b51552e449 > prerequisite-message-id: <20241111084331.2564643-1-quic_vdadhani@quicinc.com> > prerequisite-patch-id: 3f9489c89f3e632abfc5c3ca2e8eca2ce23093b0 > prerequisite-message-id: <20241108-qcs615-mm-clockcontroller-v3-0-7d3b2d235fdf@quicinc.com> > prerequisite-patch-id: 748a4e51bbedae9c6ebdbd642b2fd1badf958788 > prerequisite-patch-id: 72a894a3b19fdbd431e1cec9397365bc5b27abfe > prerequisite-patch-id: da2b7a74f1afd58833c6a9a4544a0e271720641f > prerequisite-patch-id: 40b79fe0b9101f5db3bddad23551c1123572aee5 > prerequisite-patch-id: cb93e5798f6bfe8cc3044c4ce973e3ae5f20dc6b > prerequisite-patch-id: 13b0dbf97ac1865d241791afb4b46a28ca499523 > prerequisite-patch-id: 807019bedabd47c04f7ac78e9461d0b5a6e9131b > prerequisite-patch-id: 8e2e841401fefbd96d78dd4a7c47514058c83bf2 > prerequisite-patch-id: 125bb8cb367109ba22cededf6e78754579e1ed03 > prerequisite-patch-id: b3cc42570d5826a4704f7702e7b26af9a0fe57b0 > prerequisite-patch-id: df8e2fdd997cbf6c0a107f1871ed9e2caaa97582 > prerequisite-message-id: <20241108-qcs615-mm-dt-nodes-v1-0-b2669cac0624@quicinc.com> > prerequisite-patch-id: bcb1328b70868bb9c87c0e4c48e5c9d38853bc60 > prerequisite-patch-id: 8844a4661902eb44406639a3b7344416a0c88ed9 > > Best regards, > -- > fangez <quic_fangez@quicinc.com> >
On Wed, 13 Nov 2024 at 13:53, Fange Zhang <quic_fangez@quicinc.com> wrote: > > From: Li Liu <quic_lliu6@quicinc.com> > > Add display MDSS and DSI configuration for QCS615. > QCS615 has a DP port, and DP support will be added in a later patch. > > Signed-off-by: Li Liu <quic_lliu6@quicinc.com> > Signed-off-by: Fange Zhang <quic_fangez@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs615-ride.dts | 109 +++++++++++++++++++++++++++++++ > 1 file changed, 109 insertions(+) This patch has even more feedback that was ignored at v1. Please go to the v1 discussion, respond to _all_ the items, so that we can actually see what got ignored and why. Usually I don't require this (we can all make a mistake and miss an item or two), but with this patchset the number of the comments that were ignored is extremely high.