mbox series

[V2,0/2] Add atomic transfer support to i2c-xiic

Message ID 20241210095242.1982770-1-manikanta.guntupalli@amd.com (mailing list archive)
Headers show
Series Add atomic transfer support to i2c-xiic | expand

Message

Manikanta Guntupalli Dec. 10, 2024, 9:52 a.m. UTC 
This patch series adds atomic transfer support to the i2c-xiic
controller.
---
Changes for V2:
Remove NULL checks for tx_msg and rx_msg, as __xiic_start_xfer() already
has checks.

Manikanta Guntupalli (2):
  i2c: xiic: Relocate xiic_i2c_runtime_suspend and
    xiic_i2c_runtime_resume to facilitate atomic mode
  i2c: xiic: Add atomic transfer support

 drivers/i2c/busses/i2c-xiic.c | 281 +++++++++++++++++++++++++++-------
 1 file changed, 227 insertions(+), 54 deletions(-)

Comments

Michal Simek Dec. 11, 2024, 11:36 a.m. UTC | #1 
+Kees

On 12/10/24 10:52, Manikanta Guntupalli wrote:
> This patch series adds atomic transfer support to the i2c-xiic
> controller.
> ---
> Changes for V2:
> Remove NULL checks for tx_msg and rx_msg, as __xiic_start_xfer() already
> has checks.
> 
> Manikanta Guntupalli (2):
>    i2c: xiic: Relocate xiic_i2c_runtime_suspend and
>      xiic_i2c_runtime_resume to facilitate atomic mode
>    i2c: xiic: Add atomic transfer support
> 
>   drivers/i2c/busses/i2c-xiic.c | 281 +++++++++++++++++++++++++++-------
>   1 file changed, 227 insertions(+), 54 deletions(-)
> 

Kees should be in CC on this because he was reviewing v1 version of this.

 From my perspective this is fine.

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Andi Shyti Dec. 27, 2024, 12:21 a.m. UTC | #2 
Hi Manikanta,

On Tue, Dec 10, 2024 at 03:22:40PM +0530, Manikanta Guntupalli wrote:
> This patch series adds atomic transfer support to the i2c-xiic
> controller.
> ---
> Changes for V2:
> Remove NULL checks for tx_msg and rx_msg, as __xiic_start_xfer() already
> has checks.
> 
> Manikanta Guntupalli (2):
>   i2c: xiic: Relocate xiic_i2c_runtime_suspend and
>     xiic_i2c_runtime_resume to facilitate atomic mode
>   i2c: xiic: Add atomic transfer support

these look similar to other work you did earlier. Looks fine to
me I'm not delaying any further and I pushed it in i2c/i2c-host.

Thanks Michal for looking into it.

Andi