mbox series

[v2,0/3] arm64: dts: rockchip: Add H96 Max V58 (RK3588 based TV box)

Message ID 20250108-rk3588-h96-max-v58-v2-0-522301b905d6@gmail.com (mailing list archive)
Headers show
Series arm64: dts: rockchip: Add H96 Max V58 (RK3588 based TV box) | expand

Message

Alexey Charkov Jan. 8, 2025, 9:09 a.m. UTC
Add support for H96 Max V58: a compact TV box based on Rockchip
RK3588 SoC [1] that ships with Android by default.

Note that there is no publicly available hardware documentation,
nor vendor sources to be used as a reference, so this implementation
is best effort based on poking around my board and staring at the
decompiled stock DTB. It works for me, but improvement suggestions
are very much welcome.

HDMI output is not tested, but expected to work.

Auxiliary LED display is not enabled (no mainline driver available).
The controller used is FD6551 connected to GPIO3 RK_PC7 (clk) and
GPIO3 RK_PD0 (data), which happen to be the right pins for
i2c5m0_xfer pinctrl config, and thus might potentially be used with
the hardware I2C5 controller (to be verified). Out of tree drivers
are available at [2] and another newer alternative at [3]

SPDIF output tested using a 2-channel digital to analog converter
box (higher channel counts not tested, but expected to work)

[1] https://www.h96tvbox.com/product/h96max-v58/
[2] https://github.com/arthur-liberman/linux_openvfd/blob/master/driver/controllers/fd650.c
[3] https://github.com/jefflessard/tm16xx-display

Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
Changes in v2:
- Added SPDIF support in SoC .dtsi files and board .dts
- Fixed DT warnings found by Rob's bot
- Reworded commit messages following Krzysztof's suggestion and
  collected his A-b
- Link to v1: https://lore.kernel.org/r/20250106-rk3588-h96-max-v58-v1-0-d25255f851fc@gmail.com

---
Alexey Charkov (3):
      dt-bindings: arm: rockchip: Add H96 Max V58 TV box
      arm64: dts: rockchip: Add SPDIF nodes to RK3588(s) device trees
      arm64: dts: rockchip: Add H96 Max V58 TV Box based on RK3588 SoC

 .../devicetree/bindings/arm/rockchip.yaml          |   5 +
 arch/arm64/boot/dts/rockchip/Makefile              |   1 +
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      |  64 ++
 arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi     |  30 +
 .../arm64/boot/dts/rockchip/rk3588-h96-max-v58.dts | 826 +++++++++++++++++++++
 5 files changed, 926 insertions(+)
---
base-commit: af349ca4d3f8659d84abc667125c826fda155109
change-id: 20240618-rk3588-h96-max-v58-c2c1bf8e6996

Best regards,

Comments

Heiko Stuebner Jan. 8, 2025, 10:57 a.m. UTC | #1
On Wed, 08 Jan 2025 13:09:05 +0400, Alexey Charkov wrote:
> Add support for H96 Max V58: a compact TV box based on Rockchip
> RK3588 SoC [1] that ships with Android by default.
> 
> Note that there is no publicly available hardware documentation,
> nor vendor sources to be used as a reference, so this implementation
> is best effort based on poking around my board and staring at the
> decompiled stock DTB. It works for me, but improvement suggestions
> are very much welcome.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: arm: rockchip: Add H96 Max V58 TV box
      commit: 6e9efe826b02ccd68700be691ce9addbd5c81e40
[3/3] arm64: dts: rockchip: Add H96 Max V58 TV Box based on RK3588 SoC
      commit: b53864811b35247193856a45567d416b8341ae7d

I've just dropped the spdif bits from the board in patch3 to be
handled separately. (And moved the status in spi2 at the end of
the property list)


Best regards,