| Message ID | 20250306-drm-two-ldb-improvements-v1-0-f139d768b92c@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/bridge: two minor code improvements | expand |
On Thu, Mar 06, 2025 at 06:28:40PM +0100, Luca Ceresoli wrote: > 'ret' can only be 0 at this point, being preceded by a 'if (ret) return > ret;'. So return 0 for clarity. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > --- > drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > index 7bce2305d676714cdec7ce085cb53b25ce42f8e7..bee1c6002d5f84dc33b6d5dc123726703baa427e 100644 > --- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > @@ -665,7 +665,7 @@ static int imx8qxp_ldb_probe(struct platform_device *pdev) > > ldb_add_bridge_helper(ldb, &imx8qxp_ldb_bridge_funcs); > > - return ret; > + return 0; I don't think it is necessary, no difference. Frank > } > > static void imx8qxp_ldb_remove(struct platform_device *pdev) > > -- > 2.48.1 >
This small series brings small improvements to two bridge drivers. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> --- Luca Ceresoli (2): drm/bridge: imx8qxp-ldb: cleanup return value drm/bridge: fsl-ldb: make warning message more informative drivers/gpu/drm/bridge/fsl-ldb.c | 6 +++--- drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) --- base-commit: 7eb172143d5508b4da468ed59ee857c6e5e01da6 change-id: 20250306-drm-two-ldb-improvements-16fa67cc0eaf Best regards,