| Message ID | 20250311104359.1767728-1-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block: nvme: fix blktests nvme/039 failure | expand |
On 3/11/25 4:43 AM, Shin'ichiro Kawasaki wrote: > Commit 1f47ed294a2b ("block: cleanup and fix batch completion adding > conditions") in the kernel tag v6.14-rc3 triggered blktests nvme/039 > failure [1]. > > The test case injects errors to the NVMe driver and confirms the errors > are logged. The first half of the test checks it for non-passthrough > requests, and the second half checks for passthrough requests. The > commit made both halves fail. > > This series addresses the test case failure. The first patch covers the > passthrough requests, and the second patch covers the non-passthrough > requests. Looks good to me, and better than the quick fix-up for the problem. Thanks for taking the time to do it right!
On Tue, 11 Mar 2025 19:43:57 +0900, Shin'ichiro Kawasaki wrote: > Commit 1f47ed294a2b ("block: cleanup and fix batch completion adding > conditions") in the kernel tag v6.14-rc3 triggered blktests nvme/039 > failure [1]. > > The test case injects errors to the NVMe driver and confirms the errors > are logged. The first half of the test checks it for non-passthrough > requests, and the second half checks for passthrough requests. The > commit made both halves fail. > > [...] Applied, thanks! [1/2] nvme: move error logging from nvme_end_req() to __nvme_end_req() commit: e5c2bcc0cd47321d78bb4e865d7857304139f95d [2/2] block: change blk_mq_add_to_batch() third argument type to bool commit: f00baf2eac785bba837e5ed79d489f16520e7a6d Best regards,
Commit 1f47ed294a2b ("block: cleanup and fix batch completion adding conditions") in the kernel tag v6.14-rc3 triggered blktests nvme/039 failure [1]. The test case injects errors to the NVMe driver and confirms the errors are logged. The first half of the test checks it for non-passthrough requests, and the second half checks for passthrough requests. The commit made both halves fail. This series addresses the test case failure. The first patch covers the passthrough requests, and the second patch covers the non-passthrough requests. [1] https://lkml.kernel.org/linux-block/y7m5kyk5r2eboyfsfprdvhmoo27ur46pz3r2kwb4puhxjhbvt6@zgh4dg3ewya3/ Changes from v1: * 1st patch: Added Reviewed-by tags * 2nd patch: Replaced argument blk_status_t with boolean 'is_error' Added kerneldoc of blk_mq_add_to_batch() arguments Shin'ichiro Kawasaki (2): nvme: move error logging from nvme_end_req() to __nvme_end_req() block: change blk_mq_add_to_batch() third argument type to bool drivers/block/null_blk/main.c | 4 ++-- drivers/block/virtio_blk.c | 5 +++-- drivers/nvme/host/apple.c | 3 ++- drivers/nvme/host/core.c | 12 ++++++------ drivers/nvme/host/pci.c | 5 +++-- include/linux/blk-mq.h | 11 ++++++++--- 6 files changed, 24 insertions(+), 16 deletions(-)