From patchwork Thu Mar 13 18:26:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Chevallier X-Patchwork-Id: 14015801 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25945C35FF3 for ; Thu, 13 Mar 2025 18:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=2JCIWIA2tXCmZdC2AbanjAO3zmfFwpL+OHnNB2RBlX0=; b=E/nfcWi4+ZseqwD/od5CcRmfN/ Z7bs6Ja+zHBw5KX1GFkWUXQVlgzyIpXuuAjrxZa2aZERXjjxw2+aQA2pLgWoZkk9FlFs7unxTLnZh yPa8YWVPemeHVsneqqJ+GFfoDvxsQ24wGkvCE6a48jUK0mJuu+8OfMsZEMewOWGRTqIsXIG4mfa+j Q/q1HsIBqj7ywUb08AlmcOMfyiOb0laYEgcwbn93m7i7AXzoOfYGE7d5nU/TJa7wwqJMhuS9k+5zt sC+4L2zCmU4htvCUEB+jvsNWzCn56l9syoVgJxJYm+6r6g6ovhoHJSPERixnrYb5zuHNx/VCnDqq0 1v3HWEBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsnfw-0000000CEcO-2aav; Thu, 13 Mar 2025 18:53:00 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsnGh-0000000CBo4-3RT1 for linux-arm-kernel@lists.infradead.org; Thu, 13 Mar 2025 18:26:57 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3B97F2047D; Thu, 13 Mar 2025 18:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1741890410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2JCIWIA2tXCmZdC2AbanjAO3zmfFwpL+OHnNB2RBlX0=; b=L21nxXiC/8lSiEQRsHkhOD4tQSQEUHfkDTxcrpBvX5c0NzUlm9e09dfaHSgYea3zASohPv HCkIxgpYmmNr+gcJPXucdPpjYqXtD6mnH8smH12pzU96bepqDwm7ne6X/m9R74fnBZaVQQ oagyoFjvvIUXTW27HN641mXilezSDHh/7Xm3mwl6EGGv5MrwFz3slxBOwd9zGIrDWIY5V7 t3Xzkj0qWzDpY+m9uGiyQq/Hy+yP6cQp5PpcEtYWN6EUUHH/60DgAUUu05WFwe28Pn+5Wn v/xHIG2WhhuSa6lNBivoNFZ0d/HTLMP/2TCOoLwHIAQyqSvcpiF/eGOEIn112g== From: Maxime Chevallier To: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Heiner Kallweit Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Russell King , Vladimir Oltean , =?utf-8?q?K=C3=B6ry_Maincent?= , Oleksij Rempel , Simon Horman , Romain Gantois , Piergiorgio Beruto Subject: [PATCH net-next v3 0/7] net: ethtool: Introduce ethnl dump helpers Date: Thu, 13 Mar 2025 19:26:39 +0100 Message-ID: <20250313182647.250007-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdekieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhmvgcuvehhvghvrghllhhivghruceomhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepjefhleeihefgffeiffdtffeivdehfeetheekudekgfetffetveffueeujeeitdevnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejpdhhvghlohepfhgvughorhgrqddvrdhhohhmvgdpmhgrihhlfhhrohhmpehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedvuddprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohepkhhusggrsehkvghrn hgvlhdrohhrghdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehhkhgrlhhlfigvihhtudesghhmrghilhdrtghomhdprhgtphhtthhopehmrgigihhmvgdrtghhvghvrghllhhivghrsegsohhothhlihhnrdgtohhmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_112656_473670_80AA733D X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi everyone, This is V3 for the ethnl dump support, allowing better handling of per-phy dump but also any other dump operation that needs to dump more than one message per netdev. Changes in V3: - Fixed some typos and xmas tree issues - Added a missing check for EOPNOTSUPP in patch 1 - Added missing kdoc - Added missing comments in phy_reply_size Changes in V2: - Rebased on the netdev_lock work by Stanislav and the fixes from Eric - Fixed a bissectability issue - Fixed kdoc for the new ethnl ops and fields V1: https://lore.kernel.org/netdev/20250305141938.319282-1-maxime.chevallier@bootlin.com/ V2: https://lore.kernel.org/netdev/20250308155440.267782-1-maxime.chevallier@bootlin.com/ As of today when using ethnl's default ops, the DUMP requests will simply perform a GET for each netdev. That hits limitations for commands that may return multiple messages for a single netdev, such as : - RSS (listing contexts) - All PHY-specific commands (PLCA, PSE-PD, phy) - tsinfo (one item for the netdev + one per phy) Commands that need a non-default DUMP support have to re-implement ->dumpit() themselves, which prevents using most of ethnl's internal circuitry. This series therefore introduces a better support for dump operations in ethnl. The patches 1 and 2 introduce the support for filtered DUMPs, where an ifindex/ifname can be passed in the request header for the DUMP operation. This is for when we want to dump everything a netdev supports, but without doing so for every single netdev. ethtool's "--show-phys ethX" option for example performs a filtered dump. Patch 3 introduces 3 new ethnl ops : ->dump_start() to initialize a dump context ->dump_one_dev(), that can be implemented per-command to dump everything on a given netdev ->dump_done() to release the context The default behaviour for dumps remains the same, calling the whole ->doit() path for each netdev. Patch 4 introduces a set of ->dump_start(), ->dump_one_dev() and ->dump_done() callback implementations that can simply be plugged into the existing commands that list objects per-phy, making the phy-targeting command behaviour more coherent. Patch 5 uses that new set of helpers to rewrite the phy.c support, which now uses the regulat ethnl_ops instead of fully custom genl ops. This one is the hardest to review, sorry about that, I couldn't really manage to incrementally rework that file :( Patches 6 and 7 are where the new dump infra shines, adding per-netdev per-phy dump support for PLCA and PSE-PD. We could also consider converting tsinfo/tsconfig, rss and tunnels to these new ->dump_***() operations as well, but that's out of this series' scope. Thanks, Maxime Maxime Chevallier (7): net: ethtool: netlink: Allow per-netdevice DUMP operations net: ethtool: netlink: Rename ethnl_default_dump_one net: ethtool: netlink: Introduce command-specific dump_one_dev net: ethtool: netlink: Introduce per-phy DUMP helpers net: ethtool: phy: Convert the PHY_GET command to generic phy dump net: ethtool: plca: Use per-PHY DUMP operations net: ethtool: pse-pd: Use per-PHY DUMP operations net/ethtool/netlink.c | 190 +++++++++++++++++------ net/ethtool/netlink.h | 47 +++++- net/ethtool/phy.c | 344 ++++++++++++------------------------------ net/ethtool/plca.c | 12 ++ net/ethtool/pse-pd.c | 6 + 5 files changed, 309 insertions(+), 290 deletions(-)