Message ID | Yk1iHCy4fqvxsvu0@shell.armlinux.org.uk (mailing list archive) |
---|---|
Headers | show |
Series | net: dsa: mt7530: updates for phylink changes | expand |
On Wed, 6 Apr 2022 10:49:16 +0100 "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > Hi, > > This revised series is a partial conversion of the mt7530 DSA driver to > the modern phylink infrastructure. This driver has some exceptional > cases which prevent - at the moment - its full conversion (particularly > with the Autoneg bit) to using phylink_generic_validate(). > > Patch 1 fixes the incorrect test highlighted in the first RFC series. > > Patch 2 fixes the incorrect assumption that RGMII is unable to support > 1000BASE-X. > > Patch 3 populates the supported_interfaces for each port > > Patch 4 removes the interface checks that become unnecessary as a result > of patch 3. > > Patch 5 removes use of phylink_helper_basex_speed() which is no longer > required by phylink. > > Patch 6 becomes possible after patch 5, only indicating the ethtool > modes that can be supported with a particular interface mode - this > involves removing some modes and adding others as per phylink > documentation. > > Patch 7 switches the driver to use phylink_get_linkmodes(), which moves > the driver as close as we can to phylink_generic_validate() due to the > Autoneg bit issue mentioned above. > > Patch 8 converts the driver to the phylink pcs support, removing a bunch > of driver private indirected methods. We include TRGMII as a PCS even > though strictly TRGMII does not have a PCS. This is convenient to allow > the change in patch 9 to be made. > > Patch 9 moves the special autoneg handling to the PCS validate method, > which means we can convert the MAC side to the generic validator. > > Patch 10 marks the driver as non-legacy. > > The series was posted on 23 February, and a ping sent on 3 March, but > no feedback has been received. The previous posting also received no > feedback on the actual patches either. > > drivers/net/dsa/mt7530.c | 330 +++++++++++++++++++++-------------------------- > drivers/net/dsa/mt7530.h | 26 ++-- > 2 files changed, 159 insertions(+), 197 deletions(-) > Tested-by: Marek BehĂșn <kabel@kernel.org>