From patchwork Wed Apr 6 09:49:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 12803050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FA52C433EF for ; Wed, 6 Apr 2022 10:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TrcN+Wm77a7Fdhncu8UsgFubjwIl6vHTEPVhzyKETAw=; b=shxOHlBveR5Xj9 CmDWiFh6HV0q/lHqN9e6e6tyqPlvpDBNOo0gvC4TCRaL72jQdvY5k3yf14VIJx6rXl3cLGvuBQzOx Xl/mJIxTVvptee+D2lgP26/kiVS9p+Xw3x0VuSHF0kN1o5kM+cRtXoJCjk+GrjC9ZT3VaZioSPHaL xVUoI2sa0Bxe6LtRP5vOhgJGfmTuv1ing+l/DtHo9okFPBBTXSwJYnxkl5K9/ifW6b66B/gGN5xD8 1cm/vdBee/Aj8B+6yh7pmQDBIPjHdhv4OQVm82OlDnhRZo+QOvyq/yt7kEVlS3E8e7Jrh4N4qHkc+ C7UfgwrhPV7qVrl5jamQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc2SZ-005C2f-FH; Wed, 06 Apr 2022 10:00:19 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc2IB-0057PT-DR; Wed, 06 Apr 2022 09:49:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HAZAkxGQ/zOdZiDQf8oSglIAyCEr2REmP3A7bnFL5Lw=; b=sO7m6/msfb1eq0aFrkmsU+sEzt eKwlIuQhzyzSjVUe9pFqfastnzDv2E9xwjD6RITJvC7ywINEjTfpQM7VXifEbgwJeDSVFRrQXH4wA J5yHvS8ON7R4zuJ3g8ZgJeFBNiJrmVHArv7ns3C3OTUpwIZoHFgyxUBCtBEcEPTIoRmm/+DGqKC4f EQw1SgrlGIgnNqwW+glElXiUY/GdNv8kiJ467YrBAWLSTv6LLVQQt/cidU1cFZiBEZdI0B3uVQBhz rh+Ix+ICyqU9UBSOF7zOrUaGy97b/hx8kYKLuDQNXrqonGfX3yI3t6n60w58uQVxKY/w+YqOVfDJI nrkqCFZw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58144) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nc2Hv-0002T9-Hc; Wed, 06 Apr 2022 10:49:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nc2Hs-00052x-6g; Wed, 06 Apr 2022 10:49:16 +0100 Date: Wed, 6 Apr 2022 10:49:16 +0100 From: "Russell King (Oracle)" To: Landen Chao , DENG Qingfang , Sean Wang Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Marek =?iso-8859-1?q?Beh=FAn?= , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH net-next 0/9] net: dsa: mt7530: updates for phylink changes Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_024935_573024_DB04E071 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This revised series is a partial conversion of the mt7530 DSA driver to the modern phylink infrastructure. This driver has some exceptional cases which prevent - at the moment - its full conversion (particularly with the Autoneg bit) to using phylink_generic_validate(). Patch 1 fixes the incorrect test highlighted in the first RFC series. Patch 2 fixes the incorrect assumption that RGMII is unable to support 1000BASE-X. Patch 3 populates the supported_interfaces for each port Patch 4 removes the interface checks that become unnecessary as a result of patch 3. Patch 5 removes use of phylink_helper_basex_speed() which is no longer required by phylink. Patch 6 becomes possible after patch 5, only indicating the ethtool modes that can be supported with a particular interface mode - this involves removing some modes and adding others as per phylink documentation. Patch 7 switches the driver to use phylink_get_linkmodes(), which moves the driver as close as we can to phylink_generic_validate() due to the Autoneg bit issue mentioned above. Patch 8 converts the driver to the phylink pcs support, removing a bunch of driver private indirected methods. We include TRGMII as a PCS even though strictly TRGMII does not have a PCS. This is convenient to allow the change in patch 9 to be made. Patch 9 moves the special autoneg handling to the PCS validate method, which means we can convert the MAC side to the generic validator. Patch 10 marks the driver as non-legacy. The series was posted on 23 February, and a ping sent on 3 March, but no feedback has been received. The previous posting also received no feedback on the actual patches either. drivers/net/dsa/mt7530.c | 330 +++++++++++++++++++++-------------------------- drivers/net/dsa/mt7530.h | 26 ++-- 2 files changed, 159 insertions(+), 197 deletions(-) Tested-by: Marek Behún