[net-next,0/4] net: stmmac: qcom-ethqos: simplifications

Message

Russell King (Oracle) April 12, 2025, 2:09 p.m. UTC

Remove unnecessary code from the qcom-ethqos glue driver.

Start by consistently using -> serdes_speed to set the speed of the
serdes PHY rather than sometimes using ->serdes_speed and sometimes
using ->speed.

This then allows the removal of ->speed in the second patch.

There is no need to set the maximum speed just because we're using
2500BASE-X - phylink already knows that 2500BASE-X can't support
faster speeds.

This then makes qcom_ethqos_speed_mode_2500() redundant as it's
setting the interface mode to the value that was determined in the
switch statement that already determined that the interface mode
had this value.

Not tested on hardware.

 .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    | 43 ++++++++--------------
 1 file changed, 15 insertions(+), 28 deletions(-)

Comments

[e-mail] April 15, 2025, 12:50 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Sat, 12 Apr 2025 15:09:51 +0100 you wrote:
> Remove unnecessary code from the qcom-ethqos glue driver.
> 
> Start by consistently using -> serdes_speed to set the speed of the
> serdes PHY rather than sometimes using ->serdes_speed and sometimes
> using ->speed.
> 
> This then allows the removal of ->speed in the second patch.
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] net: stmmac: qcom-ethqos: set serdes speed using serdes_speed
    https://git.kernel.org/netdev/net-next/c/b4589810082a
  - [net-next,2/4] net: stmmac: qcom-ethqos: remove ethqos->speed
    https://git.kernel.org/netdev/net-next/c/a3d54648ada2
  - [net-next,3/4] net: stmmac: qcom-ethqos: remove unnecessary setting max_speed
    https://git.kernel.org/netdev/net-next/c/4c30093f784e
  - [net-next,4/4] net: stmmac: qcom-ethqos: remove speed_mode_2500() method
    https://git.kernel.org/netdev/net-next/c/0d1c18a10dd1

You are awesome, thank you!