From patchwork Wed May 29 08:40:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13678451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A01CC25B75 for ; Wed, 29 May 2024 08:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3r0jgwa6pL7+Sx0qLquNu+YT0pPFecGt+ftQx69LqdI=; b=nqsbZorw4BqCZX BDUtwTTxJqT/p4eT+dXmQ7+v2J2f53JpsL+RLuC2I1WwHytLG0sD7oC7OjdCh5SS2q+1/pX/FUy0Q YjhXtjiiBvH/WsENumxullcu4JMg3yQ3fkBFfc+J9jmCZZgPMYB2QHiBxld8ewgaxrk8c4Ae2kAWX 7YI80Q5JGQKyAV26tb+8NuK5ouQS8/7J65LWq0GyDQ7qTIelN20y1tU7//U82Qy4+uudWxl7aXl2z c1xhxwq2pFCDc5UxhC3XCe8aTPTLkpwwi0acwkUU+4pdhFJMq5VtRPfdbF4zTLq2IMj8wVr9dKSIL GdEqxfsLkm/83vBCjqww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCEtN-00000003SID-3TGN; Wed, 29 May 2024 08:42:41 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCEtK-00000003RZn-2gLM for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 08:42:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WBthTXF0tvM8P+3l/Pr3VnSW0fJqfhQ6w5OUBDLvGXo=; b=jdRa0V1sN+VDzhVS8kCjLjkIWd T0sYAhjp9LxuBKngzUjWFhqA3LU9ZIiuUg0QdTeiDNDezt9aMbTnKCeFvktKl7cfb0J7v5UxYlS+c 4g4QPhRjwP8k32yGfi6rIJA+44OdIEmei51tN11Hz08g0eVs9uZX7ERNVfBJdwTfdDjDSbIgZ86jc b7vA5X2pHklEAK/oxjCLUpo4M8im+BxohncFfuVFMm/gQC82Vj0UYV6fd5lCEwelzad5mBDlSi3ef rlDbGKFh7Hv/uif+lSu7yZVtxShXstk6QETs7lf1IW3QtWzfIkCIvkoSTGfc3QqXy+IhiZxDVOglP ExTzue0w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53862) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sCEr3-0005lJ-1G; Wed, 29 May 2024 09:40:17 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sCEr2-000458-1F; Wed, 29 May 2024 09:40:16 +0100 Date: Wed, 29 May 2024 09:40:15 +0100 From: "Russell King (Oracle)" To: Serge Semin Cc: Andrew Halaney , Alexandre Torgue , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: [PATCH net-next v2 0/6] net: stmmac: cleanups Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_014238_704416_60FD2AD2 X-CRM114-Status: GOOD ( 10.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This series removes various redundant items in the stmmac driver: - the unused TBI and RTBI PCS flags - the NULL pointer initialisations for PCS methods in dwxgmac2 - the stmmac_pcs_rane() method which is never called, and it's associated implementations - the redundant netif_carrier_off()s Finally, it replaces asm/io.h with the preferred linux/io.h. Changes since v1: - Fix patch 1 "Drop TBI/RTBI flags" which didn't transfer correctly between my internal trees! - Update patch 5 to address all the asm/io.h in stmmac - Add Andrew Halaney's reviewed-by - Add patch 6 cleaning up qcom-ethqos phy speed setting drivers/net/ethernet/stmicro/stmmac/common.h | 2 -- .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 24 +++++++------- .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 8 +---- .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 2 +- .../net/ethernet/stmicro/stmmac/dwmac100_core.c | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 8 ----- .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 6 ---- drivers/net/ethernet/stmicro/stmmac/hwif.h | 3 -- .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 38 +++++----------------- drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h | 17 ---------- 12 files changed, 26 insertions(+), 88 deletions(-) Reviewed-by: Serge Semin