| Message ID | ZlctinnTT8Xhemsm@shell.armlinux.org.uk (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: phylink: rearrange ovr_an_inband support | expand |
On Wed, May 29, 2024 at 02:28:42PM GMT, Russell King (Oracle) wrote: > Hi, > > This series addresses the use of the ovr_an_inband flag, which is used > by two drivers to indicate to phylink that they wish to use inband mode > without firmware specifying inband mode. > > The issue with ovr_an_inband is that it overrides not only PHY mode, > but also fixed-link mode. Both of the drivers that set this flag > contain code to detect when fixed-link mode will be used, and then > either avoid setting it or explicitly clear the flag. This is > wasteful when phylink already knows this. > > Therefore, the approach taken in this patch set is to replace the > ovr_an_inband flag with a default_an_inband flag which means that > phylink defaults to MLO_AN_INBAND instead of MLO_AN_PHY, and will > allow that default to be overriden if firmware specifies a fixed-link. > This allows users of ovr_an_inband to be simplified. > > What's more is this requires minimal changes in phylink to allow this > new mode of operation. > > This series changes phylink, and also updates the two drivers > (fman_memac and stmmac), and then removes the unnecessary complexity > from the drivers. > > This series may depend on the stmmac cleanup series I've posted > earlier - this is something I have not checked, but I currently have > these patches on top of that series. > > drivers/net/ethernet/freescale/fman/fman_memac.c | 16 ++++++---------- > drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 15 ++------------- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- > drivers/net/phy/phylink.c | 11 ++++++++--- > include/linux/phylink.h | 5 +++-- > include/linux/stmmac.h | 2 +- > 6 files changed, 22 insertions(+), 31 deletions(-) > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! > This all seems more clear to me now for what it is worth: Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 29 May 2024 14:28:42 +0100 you wrote: > Hi, > > This series addresses the use of the ovr_an_inband flag, which is used > by two drivers to indicate to phylink that they wish to use inband mode > without firmware specifying inband mode. > > The issue with ovr_an_inband is that it overrides not only PHY mode, > but also fixed-link mode. Both of the drivers that set this flag > contain code to detect when fixed-link mode will be used, and then > either avoid setting it or explicitly clear the flag. This is > wasteful when phylink already knows this. > > [...] Here is the summary with links: - [net-next,1/6] net: phylink: rearrange phylink_parse_mode() https://git.kernel.org/netdev/net-next/c/75518b0dc9d6 - [net-next,2/6] net: phylink: move test for ovr_an_inband https://git.kernel.org/netdev/net-next/c/fea49f065c1c - [net-next,3/6] net: phylink: rename ovr_an_inband to default_an_inband https://git.kernel.org/netdev/net-next/c/02d00dc73d8d - [net-next,4/6] net: fman_memac: remove the now unnecessary checking for fixed-link https://git.kernel.org/netdev/net-next/c/5e332954e760 - [net-next,5/6] net: stmmac: rename xpcs_an_inband to default_an_inband https://git.kernel.org/netdev/net-next/c/83f55b01dd90 - [net-next,6/6] net: stmmac: dwmac-intel: remove checking for fixed link https://git.kernel.org/netdev/net-next/c/ab77c7aa9388 You are awesome, thank you!