From patchwork Thu Nov 1 07:17:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Vaittinen, Matti" X-Patchwork-Id: 10663567 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6010C13A4 for ; Thu, 1 Nov 2018 07:17:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E4872B910 for ; Thu, 1 Nov 2018 07:17:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3202D2B933; Thu, 1 Nov 2018 07:17:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CE8512B910 for ; Thu, 1 Nov 2018 07:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RfPN4RpmSplwXhxfm0fgMZ40ao+4Og03qqC9AUBUOTM=; b=Hf+ASn+mHV+XY7 m8YVJJKrPCA6g/NBJcsjg2nEvD9AMDgZhgafs2m+PdfASqG2H9uVIyf/K2hYpD+gWNzt91pW9PItj qXwHK49Wa74sldQoNvPHG0wa7HQYot4MU5JyWfSGmkMTQTstXLHSMilI/Ihta6a62OeR/jTtiR0sD UAcoI6enMuOcyRRpnGprRdXcd8I9pM49M8KZXtWmN1BFkvKrdclk43B5g29TKuP7tcvgaUrVEEmf/ Qojma9iGRLqYxcMTw2Cjyg8PpRso4w8vXQB+B+m6FBfCSwi5fQq37WTR8r52Brs6qKqVbbx16leh9 sj+Tzx5RfRuqDs08k01g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gI7Eo-0004kZ-1h; Thu, 01 Nov 2018 07:17:54 +0000 Received: from mail-lf1-f67.google.com ([209.85.167.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gI7El-0004iQ-3H for linux-arm-kernel@lists.infradead.org; Thu, 01 Nov 2018 07:17:52 +0000 Received: by mail-lf1-f67.google.com with SMTP id h192so13515817lfg.3 for ; Thu, 01 Nov 2018 00:17:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=tuTJsoBlJAz/Od17VS3XqtNOnWZ0QDYhBOZPEMrB3cY=; b=t2XsS3ANZOy8zIT4HeTm8nrm1PwWT/da9LD9Xsk3dIN6JAqeIgRN9ZEiSPGHxkHqVF KzCvi0eMzJZurMX7JC2KKsDv4TkacQGfPL48Mzwo+tj5jpo5hlUU0/i8x1zCOeuWOnmv VK4qDjoUvHON343E9rwYCuB3MgmcD5jnHt3uOJ9HKza1RNCcaDF4+bLXIX/gA2RkEUvL Bs6SEPCeUSg3GzS1RMhOLc6z4LdX12NkJ3UGtnwwmx1j3mHtzlsJJkQNv5ZUfBjztm9A DChsTEui1CXeO7W3TqQekxm6JBESwDpvWYA5mzRtswtOEu94mtEPV6Wq+6EhwK9Ge9Ni y66Q== X-Gm-Message-State: AGRZ1gItp3ckeWgVYpxlJDa7vBPgliJHtjLSdY35CIEvyFk6+XaePNbX puFpppJmkERjQZWJfzUzPpE= X-Google-Smtp-Source: AJdET5c1a+hcUyKREw4h1DqWorReK39x9I3q7Lw7IWZWDL7EUEHCNtKaeAgyNeIKgrM7GoZmj75ivg== X-Received: by 2002:a19:fc09:: with SMTP id a9mr3921623lfi.21.1541056658953; Thu, 01 Nov 2018 00:17:38 -0700 (PDT) Received: from localhost.localdomain ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id d17-v6sm4596754lfg.97.2018.11.01.00.17.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 00:17:38 -0700 (PDT) Date: Thu, 1 Nov 2018 09:17:25 +0200 From: Matti Vaittinen To: Jonathan Corbet , Michael Turquette , Stephen Boyd , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Russell King , Andy Gross , David Brown , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Andrey Smirnov , Sebastian Reichel , Guenter Roeck , Rob Herring , Matti Vaittinen , Huang Shijie , Akshu Agrawal , "Rafael J. Wysocki" , Daniel Kurtz , mazziesaccount@gmail.com Subject: [PATCH v2 0/8] clk: clkdev: managed clk lookup and provider registrations Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181101_001751_140599_89A9CBC3 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, matti.vaittinen@fi.rohmeurope.com, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Patch series adding managed clkdev and of_provider registrations Few clk drivers appear to be leaking clkdev lookup registrations at driver remove. The patch series adds devm versions of lookup registrations and cleans up few drivers. Driver clean-up patches have not been tested as I lack the HW. All testing and comments if driver/device removal is even possible for changed drivers is highly appreciated. If removal is not possible I will gladly drop the patches from series - although leaking lookups may serve as bad example for new developers =) Changed drivers are: clk-max77686, clk-s3c2410-dclk, clk-st, clk-hi655x, rk808, clk-twl6040 and apcs-msm8916. New devm registration variants have been tested on BeagleBoneBlack using ROHM BD71837 PMIC driver. Same devm variants were earlier proposed together with BD71837/BD71847 PMIC clk driver in this series: https://lore.kernel.org/linux-clk/cover.1535630942.git.matti.vaittinen@fi.rohmeurope.com/ The BD71837/BD71847 work is currently pending for related MFD commits to get merged in clk-tree and the devm functions are now submitted in this series. Changelog v2 Issue spotted by 0-Day test suite - Add a stub function 'devm_of_clk_add_parent_hw_provider' for no OF config. - patches 2-8 are unchanged. This patch series is based on clk-next --- Matti Vaittinen (8): clk: clkdev/of_clk - add managed lookup and provider registrations clk: clk-max77686: Clean clkdev lookup leak and use devm clk: clk-s3c2410-dclk: clean up clkdev lookup leak clk: clk-st: avoid clkdev lookup leak at remove clk: clk-hi655x: Free of_provider at remove clk: rk808: use managed version of of_provider registration clk: clk-twl6040: Free of_provider at remove clk: apcs-msm8916: simplify probe cleanup by using devm Documentation/driver-model/devres.txt | 3 + drivers/clk/clk-hi655x.c | 4 +- drivers/clk/clk-max77686.c | 25 ++----- drivers/clk/clk-rk808.c | 15 +--- drivers/clk/clk-twl6040.c | 5 +- drivers/clk/clk.c | 28 ++++++-- drivers/clk/clkdev.c | 122 ++++++++++++++++++++++++++------- drivers/clk/qcom/apcs-msm8916.c | 5 +- drivers/clk/samsung/clk-s3c2410-dclk.c | 15 ++-- drivers/clk/x86/clk-st.c | 3 +- include/linux/clk-provider.h | 11 +++ include/linux/clkdev.h | 4 ++ 12 files changed, 158 insertions(+), 82 deletions(-)