[v5,0/9] clk: clkdev: managed clk lookup and provider registrations

Message

Vaittinen, Matti Dec. 3, 2018, 12:17 p.m. UTC

Series add bd71837/bd71837 PMIC clock support + managed interfaces

Few clk drivers appear to be leaking clkdev lookup registrations at
driver remove. The patch series adds devm versions of lookup
registrations and cleans up few drivers. Driver clean-up patches have
not been tested as I lack the HW. All testing and comments if
driver/device removal is even possible for changed drivers is highly
appreciated. If removal is not possible I will gladly drop the patches
from series - although leaking lookups may serve as bad example for new
developers =)

Patch 8 adds support for clock gate in ROHM bd71837 and bd71847 PMICs.
This change is included in the series because it depends on new managed
interfaces introduced in this series.

bd718x7 driver and devm interfaces are tested on BeagleBoneBlack and 
bd71837 break-out board. Clk area register interface of bd71847 is
identical to bd71837.

Changed drivers are:
clk-max77686, clk-st, clk-hi655x, rk808, clk-twl6040
and apcs-msm8916. New driver is clk-bd718x7

This series has been discussed for a while now. For those who want to
see whole discussion:

The bd71837 driver was originally proposed here
https://lore.kernel.org/lkml/d99c876[e-mail]/

clk portion was separated from that series and devm variants were
proposed here
https://lore.kernel.org/linux-clk/[e-mail]/

Cleanup to other drivers was initiated in this series while waiting for
MFD portions of bd718x7 to be applied. And now when MFD dependencies are in-tree
the patch version (4) combined bd718x7 driver back to this series.

Changelog (for this series) v5
- Split v4 patch 1. Place clkdev stuff to patch 1 and clk provider to patch 2
- Remove devm_clk_release_clkdev from devres.txt
- Added kerneldoc for managed provider registrations.
- Cleaned styling issues.

Changelog (for this series) v4
- Add support for ROHM bd718x7 PMIC clock gate. Included in this patch
  series because it depends on managed interfaces added in patch 1.

Changelog (for this series) v3
Address issues spotted by Krzysztof Kozlowski
- Drop patch 3 for clk-s3c2410-dclk as this device can never be removed
- Fix indentiation for clk-max77686
- Rest  of the patches are unchanged.

Changelog (for this series) v2
Issue spotted by 0-Day test suite
- Add a stub function 'devm_of_clk_add_parent_hw_provider' for no OF config.
- patches 2-8 are unchanged.

This patch series is based on clk-next

---

Matti Vaittinen (9):
  clkdev: add managed clkdev lookup registration
  clk: of_clk - add managed provider registrations
  clk: clk-max77686: Clean clkdev lookup leak and use devm
  clk: clk-st: avoid clkdev lookup leak at remove
  clk: clk-hi655x: Free of_provider at remove
  clk: rk808: use managed version of of_provider registration
  clk: clk-twl6040: Free of_provider at remove
  clk: apcs-msm8916: simplify probe cleanup by using devm
  clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock

 Documentation/driver-model/devres.txt |   2 +
 drivers/clk/Kconfig                   |   7 ++
 drivers/clk/Makefile                  |   1 +
 drivers/clk/clk-bd718x7.c             | 131 ++++++++++++++++++++++++++++++++++
 drivers/clk/clk-hi655x.c              |   4 +-
 drivers/clk/clk-max77686.c            |  29 ++------
 drivers/clk/clk-rk808.c               |  15 +---
 drivers/clk/clk-twl6040.c             |   5 +-
 drivers/clk/clk.c                     |  65 ++++++++++++++---
 drivers/clk/clkdev.c                  | 122 ++++++++++++++++++++++++-------
 drivers/clk/qcom/apcs-msm8916.c       |   5 +-
 drivers/clk/x86/clk-st.c              |   3 +-
 include/linux/clk-provider.h          |  11 +++
 include/linux/clkdev.h                |   4 ++
 14 files changed, 325 insertions(+), 79 deletions(-)
 create mode 100644 drivers/clk/clk-bd718x7.c

Comments

Lee Jones Dec. 3, 2018, 12:19 p.m. UTC | #1

> Series add bd71837/bd71837 PMIC clock support + managed interfaces

[...]

> Matti Vaittinen (9):
>   clkdev: add managed clkdev lookup registration
>   clk: of_clk - add managed provider registrations
>   clk: clk-max77686: Clean clkdev lookup leak and use devm
>   clk: clk-st: avoid clkdev lookup leak at remove
>   clk: clk-hi655x: Free of_provider at remove
>   clk: rk808: use managed version of of_provider registration
>   clk: clk-twl6040: Free of_provider at remove
>   clk: apcs-msm8916: simplify probe cleanup by using devm
>   clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock
> 
>  Documentation/driver-model/devres.txt |   2 +
>  drivers/clk/Kconfig                   |   7 ++
>  drivers/clk/Makefile                  |   1 +
>  drivers/clk/clk-bd718x7.c             | 131 ++++++++++++++++++++++++++++++++++
>  drivers/clk/clk-hi655x.c              |   4 +-
>  drivers/clk/clk-max77686.c            |  29 ++------
>  drivers/clk/clk-rk808.c               |  15 +---
>  drivers/clk/clk-twl6040.c             |   5 +-
>  drivers/clk/clk.c                     |  65 ++++++++++++++---
>  drivers/clk/clkdev.c                  | 122 ++++++++++++++++++++++++-------
>  drivers/clk/qcom/apcs-msm8916.c       |   5 +-
>  drivers/clk/x86/clk-st.c              |   3 +-
>  include/linux/clk-provider.h          |  11 +++
>  include/linux/clkdev.h                |   4 ++
>  14 files changed, 325 insertions(+), 79 deletions(-)
>  create mode 100644 drivers/clk/clk-bd718x7.c

You've send me a cover letter and no patches.

I suggest that I should not be on the addressee list at all for this.

Vaittinen, Matti Dec. 3, 2018, 12:35 p.m. UTC | #2

Hi de Ho Lee,

On Mon, Dec 03, 2018 at 12:19:51PM +0000, Lee Jones wrote:
> > Series add bd71837/bd71837 PMIC clock support + managed interfaces
> 
> You've send me a cover letter and no patches.
I am afraid the patches may be still on their way... I added recipients
to git format-patch via command-line so you are probably included also
in patch mails :(

> 
> I suggest that I should not be on the addressee list at all for this.

I'm terribly sorry for spamming! I must've done some mistake with the
get_maintainer.pl as I copied the recipients from that output. I may
have accidentally included some old patch to maintainer query.

> 
> -- 
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

Lee Jones Dec. 3, 2018, 12:56 p.m. UTC | #3

On Mon, 03 Dec 2018, Matti Vaittinen wrote:

> 
> Hi de Ho Lee,
> 
> On Mon, Dec 03, 2018 at 12:19:51PM +0000, Lee Jones wrote:
> > > Series add bd71837/bd71837 PMIC clock support + managed interfaces
> > 
> > You've send me a cover letter and no patches.
> > 
> I am afraid the patches may be still on their way... I added recipients
> to git format-patch via command-line so you are probably included also
> in patch mails :(

Ah I see.  Yes, I see that they have started to come through.

> > I suggest that I should not be on the addressee list at all for this.
> 
> I'm terribly sorry for spamming! I must've done some mistake with the
> get_maintainer.pl as I copied the recipients from that output. I may
> have accidentally included some old patch to maintainer query.

No problem.  If you could remove me from future mails though, that
would be appreciated.  The torrent it fierce enough without receiving
correspondence that is not relevant to me.  Thanks.