mbox series

[v2,0/5] gpio: mvebu: pwm fixes and improvements

Message ID cover.1610529002.git.baruch@tkos.co.il (mailing list archive)
Headers show
Series gpio: mvebu: pwm fixes and improvements | expand

Message

Baruch Siach Jan. 13, 2021, 9:22 a.m. UTC
This series adds a few related fixes to the pwm .apply and .get_state 
callbacks.

The first patch was originally part of the series adding Armada 8K/7K pwm 
support. I split it out to a separate series following review comments from 
Uwe Kleine-König who spotted a few more issues. There is no dependency between 
this and the Armada 8K/7K series.

v2:

Address Uwe Kleine-König comments.

  * Improve patch 1/5 summary line

  * Add more information to patch 1/5 description

  * Add more information to patch 2/5 description

  * Don't round period/duty_cycle up in .apply (patch 3/5)

  * Expand the comment in path 5/5 based on RMK's analysis of hardware 
    behaviour

  * Add Uwe's Reviewed-by tags

Baruch Siach (5):
  gpio: mvebu: fix pwm .get_state period calculation
  gpio: mvebu: improve pwm period calculation accuracy
  gpio: mvebu: make pwm .get_state closer to idempotent
  gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX
  gpio: mvebu: document zero pwm duty cycle limitation

 drivers/gpio/gpio-mvebu.c | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

Comments

Linus Walleij Jan. 18, 2021, 1:45 p.m. UTC | #1
On Wed, Jan 13, 2021 at 10:23 AM Baruch Siach <baruch@tkos.co.il> wrote:

> This series adds a few related fixes to the pwm .apply and .get_state
> callbacks.
>
> The first patch was originally part of the series adding Armada 8K/7K pwm
> support. I split it out to a separate series following review comments from
> Uwe Kleine-König who spotted a few more issues. There is no dependency between
> this and the Armada 8K/7K series.

This version looks really good and +/- minor tweaks as indicated by
Uwe:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Uwe Kleine-König Jan. 18, 2021, 2:59 p.m. UTC | #2
Hello Linus,

On Mon, Jan 18, 2021 at 02:45:14PM +0100, Linus Walleij wrote:
> On Wed, Jan 13, 2021 at 10:23 AM Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > This series adds a few related fixes to the pwm .apply and .get_state
> > callbacks.
> >
> > The first patch was originally part of the series adding Armada 8K/7K pwm
> > support. I split it out to a separate series following review comments from
> > Uwe Kleine-König who spotted a few more issues. There is no dependency between
> > this and the Armada 8K/7K series.
> 
> This version looks really good and +/- minor tweaks as indicated by
> Uwe:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

The most recent version of this series is v4.

Best regards
Uwe