From patchwork Thu Apr 14 09:00:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Qian X-Patchwork-Id: 12813197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73A28C433F5 for ; Thu, 14 Apr 2022 09:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/qAbJfLHulugROQlZq/CBFviX9JGdvQin1EsQ7sHiq4=; b=knqoKgGAkV5y/C bRRa8JBkqtkFcfV6/X/Pbw0prU5tgvtX6GJqdUbYCZeEdDStFxIPwd3wsExqS9C7KEstR2qT69qsM Ylt0YlUciVagYO4cJpC53UrczibRqoOdL/KPxU3GasEsBbqUGmNzPmSSOLyainC8lVGHSwKfIbk7e AorGWsvG2kWCQREbSPn9q4FS9V2cRgVy/ah2BVnWTHtHfsrn8S0tqcuM3Ou6tC2TYbM/An1auNaPI DgGZ7WqXVGw4p31REfxDXNLuZDWssUzJtVyVKLqdAa0ZV4ek6P35welLNEH6kybtaE7Qx2O/ZVXwP ih97fLH3GzrgM9Lhigng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevZc-004pDh-Bz; Thu, 14 Apr 2022 09:15:33 +0000 Received: from mail-vi1eur04on0618.outbound.protection.outlook.com ([2a01:111:f400:fe0e::618] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevZV-004pBE-MZ for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 09:15:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gcPhBSa1Oo4PwwH8i3dPavMvxQwH9SkxFDuriGYopfIq+0CcpZp+fHhWQeRyUDVXEbyec+WtV/orIEyREauYbJhu09gI/a/qPG1ZZv1tEnnrt34U1tx+0rw5A7mnRDMR9wTk3Hc4vGh9l4uRj5asMu+t7gI8PkpVQDnQw8n+PebJWw9eS8zjM57LQ7a+GAV23xWix+8uYkBduYdo3UO0dvRpCbqOqURmsKH+ciBktRAawWRU86gyGqQZ/gOgAtirjz40wXWFfjg+32RkEx2DYSKeRy4ddjQEyd2LUyQ75b8rj848vGtFLsDjb5YNGjSWi6+pIq4Q19XbqPMt91Febw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lvgCLFXsubbtA01RXJpLMrioAnoJFVPtPhj24b1wrTA=; b=DGUn6ufxdEnxZlFt/r0VEb2U45BsmA2m9TmiAvX9jrGoC8rpzwcHfmkfPaNZ7RzCuNUCle5oO1xol0zpyc92FwP5gM9FodHMZlN6Zf0ygH8Ca+SFJq+DeAjCQ6hZxAKgM2+CIimY2gCJy7ImUr3I5fffMC/t+uQnEEtZaoj5m0Za3ja+45KqlCouVnVMgPi1vo+ZOvFB7RObOj0+IBOoevMjfZF87j/Pf5pmBLmECTo5PCVRaUO1K6u7uX/P00+UzXinmvSA3ZyT4c66CWs5Zv1BTx9X6bgP92blPfhzEhJukBvHYCxvaNVbj8kq+zgC2qpS9cB6CZuA9ZeTQzIX6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lvgCLFXsubbtA01RXJpLMrioAnoJFVPtPhj24b1wrTA=; b=GNQ/odc3AW9bnDXywhwdvlZPUycRFX2DpRtye80wnHJKRk4fgiYwjMmNHfE9Z9a1fWH6uropKRIuH5GOneRVSrNCgFbPgmVPGVRVgdW3Cyjpi2wA1sX3iVtbXsxfrT2i/m2obzm/BneJXdb7QSaTb+8SjR2SEJ6YQfmTlXFyty8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by AM7PR04MB6885.eurprd04.prod.outlook.com (2603:10a6:20b:10d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Thu, 14 Apr 2022 09:01:07 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::d8b5:5914:5189:ffa5]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::d8b5:5914:5189:ffa5%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022 09:01:07 +0000 From: Ming Qian To: mchehab@kernel.org, shawnguo@kernel.org Cc: hverkuil-cisco@xs4all.nl, robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 0/2] media: amphion: copy timestamp from output to Date: Thu, 14 Apr 2022 17:00:28 +0800 Message-Id: X-Mailer: git-send-email 2.35.1 X-ClientProxiedBy: SG2P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096::21) To AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d741faf-076d-466b-7b05-08da1df54fe7 X-MS-TrafficTypeDiagnostic: AM7PR04MB6885:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C3n33wXv25I8Qijk9B/VOQBkOg6Lte7k0rX+gCFR6xBJHD86b+fizzdveUkiqa7dGNZOTCRTmp+2Sz+uZuGimKVrVf86XPhT1DcA1/tCt1E8yuPwIrQuOsWvrshQlch/672gfNu2iEav6/gvTrLv6t4g7XscS+yQ/CuW+6uEzEStX6L+OQik9EKRVvcNgpu6WTKKXoFKCr2bA6S5PH9yXhNmBtV50NDdzZIN+OmMMsH6oRyqmwcv7NzAE9HRkIfp37T/EdUP9MbdtlaRsNnqEajchnNWSuwJlhRFdQTim1PYjvntzefTrm3f2hfqPq8uagaSnRmTYhdXb6kei+D5gH1SbxNPkELUeNBWR0SN6exf1XT7qaGleWvlRCiL/8YWXcfngUFMqmjaZE2Iy6QgalVsTARl9JMSLgp0zPWInPLijZMkjkbyzNem5lPB16E/khw+jtpQzgMgnUX9sEveAGykD1qDM5ZQy+5/0nAvYCnnQfnZoJviNyzX0A71i9DIikkGZpVmreUmkrIl+5DG9fFMnx2oPsBBAiaSMXElbfkeaOSEcfMD13RcUnU5KgllhwZ/jUHR41OrQYJ6Loiiww67Lgt9FiqoR9GSVQVwdTbw0pkjle59nOtI5BqXorfx/HCzUdXIEvDtvRDLy1WAByIw8+poCckOG+kYykME3ot/uC2AthALzRZOt6oo/oPHeR3ZBJfCwomYA3uZsCXT7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6341.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(38350700002)(2616005)(83380400001)(5660300002)(66556008)(8676002)(52116002)(86362001)(186003)(26005)(7416002)(66946007)(4326008)(36756003)(2906002)(8936002)(44832011)(6486002)(6666004)(508600001)(6506007)(6512007)(316002)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NIgXYe/fx1WdRDY7IpYlONKDeNYXq6jhnzAd8ZtRi98hGa1ZcCeimNRhtF5Sf9nBry2HiPnGXtvSfwcuzD9hYWafsFunbPkLi1mrb7tTqbSWgZ9nuSsWJX6VxueF7GqDswHL1xGDSkoL+5R1bFMk7rr71EF6vryFXinr2Fbmcp64yvI3K10mA7OQIB5j1gadI/RVwpA4+TooPaBABK++yUbgV1Z1XoioEoBQDQxrRDaZPwaDL5Yn4nGm9ReBzk/cVIsV/3ncNGEGjUpAb4El6mgKfLDJiaJatBL56J4rE9DoS1MfAmRf7jh3TBhTwhZttXaSVhGXLYgFont+VERXVzKdeuLP3zQVQv+9NM7ZMq6c8zsje6rVUyu+QRC+LYvaP/W1YC/z7iCmhtxxid9QNILPUbd29Apd/aYn/rzcGLKguwxFcPVOq+keFwcj0dr7QLFdcH75c+3GwDYx8Z3MrJ8cakp8YxjMmJZHbVHw5VS3JzJHWyuw5GnfD3pTNXr/xTJdTUNACAzd+X6R+phK+n0qDaeqE6pjWVlzJLSFvyHzTZ8IEmsFYmPaMmUyPB3RDy6Btn51TC6WX+qkFEfnzZeepO1kv4BMtZl0RH6Q5ZtFcpQH4tbEIT/oTLqHsNhqpX6MinfcsgjCfOB37yclKmXGakVq/PAEq6/TuLh1S9NmVdiRQO6o0nlGW84s0ib3kNO5Oiy5Tujnu91O+VEdDEkrZKHIykLg9tkGacooj9eZnI/t9+s9UrQ3fPFCr7Y+LPH+9+QCfUpo7eYMkos4Oqal4MmVjpi1q/NiU+0KNlD5ZEzNDRShCVgp/M61ld3wKcExiSowK9BgRq/QNY2jAcSunioeShRGHGn8dgwgNsRmuBozQFhy+C5+tdhanak7lLd7eMLsdMsDEpmwMDOR5TVzMf32bTcxtjCO3CvdAIUshRb89XXoRfZYXJbvdnGWccS9ya8+gWflIwyA+XWJtZTDwEsJ2gACamnJ91JBdOhjb/my4jXUYDgX67dlANjd0ACh8hmK/yEML1AOkiPDCQc9dfYIUSWkHyOei9buCMwci7J2kLtONk2K1C8vJ+JbHu2PEyCvEPz3jqsNqFyxxEiaKaLdxAq4IUn4GV62ghq2g93s+Dd3hCxJCXxImYeIcdoUnI7K6HPduhgkxGzMp2mNWmjzTFPe0OPvLEFDzC/DD+ZTuwHcSgAAQ3ZH3M7n3uT4rkxeg9J5egtGjnwvgQspdE7LfJ4F9IC0NAdL/k/sRxzr8o3TsAZD7KEazfvLodTOYbIFjiAEwvy1JWXjSlSqRWDj7/PyhbBcmQk8AH8H/4Vo2effxbslvlBl12HhN2SlTA/f/nj4g/Ivg0nXaO4Nkyr5lM3DXcGMZPxNcVV96v26aCaP63RXiMp3UWnUSmEv17RJ76E/2QXqYwotnm+U77vCK1G/OfD/+iiznEO9fkYTPz0hB2TGz0hV8TSN4nJ4eLlBu17x3BuADQdahO9eMt9oR3eQLWXoaeZBoV8xJJo0+HLnqerLSQLnDK9Fqe2Jm26c/w3RkiizZmH83wMtpFpaACyQgSFBdm9B7iwQz8CUyw6ZuhBUH4jW37P+5lCDvSBZHoeERU7DzRUCOGKjIhgdtd5E2x1pjzP+6PdWl02FxdgXWfqO25MB2gR5ZF1YdNjMs8Z+hylN3LUAleM8rJ/qd6u9f0/K9KEK/PHqXqKvWVVOVcOrOlAOwU7JWUwiKL27xIpaB8w8z6kYCw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d741faf-076d-466b-7b05-08da1df54fe7 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 09:01:07.4234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GwfZB3kiUc+1FEqT/Vj1pSEqpGl5X8iPTQ86WSjlNAGW0gAaV1Nxb/tx/u3c4mTNr111wYaJsQ7TMfJL50MCXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6885 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_021525_762981_F423A0F7 X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v2 - reduce the min buffers count There is a timestamp manager in firmware, so in previous, driver will pass the timestamp to firmware, and when a frame is decoded or encoded, firmware will pass the timestamp to driver, then driver set the timestamp to the capture vb2_buffer. But there is problem that the timestamp manager will ensure that the timestamps are monotonically increasing. So if there are reorder frames, the capture buffer's timestamp is inconsistent with the timestamp of the corresponding output buffer. It goes against the description of V4L2_BUF_FLAG_TIMESTAMP_COPY in the specification In order to comply with the specification, driver should copy timestamp from output buffer to capture buffer, and there is an helper function v4l2_m2m_buf_copy_metadata to handle it. Ming Qian (2): media: amphion: decoder copy timestamp from output to capture media: amphion: encoder copy timestamp from output to capture drivers/media/platform/amphion/vdec.c | 89 ++++++++++------------- drivers/media/platform/amphion/venc.c | 47 ++++-------- drivers/media/platform/amphion/vpu_v4l2.c | 13 ++++ drivers/media/platform/amphion/vpu_v4l2.h | 1 + 4 files changed, 70 insertions(+), 80 deletions(-)