mbox series

[v3,0/7] Iommu: Retire bus ops

Message ID cover.1694693889.git.robin.murphy@arm.com (mailing list archive)
Headers show
Series Iommu: Retire bus ops | expand

Message

Robin Murphy Sept. 15, 2023, 4:58 p.m. UTC 
v2: https://lore.kernel.org/linux-iommu/cover.1674753627.git.robin.murphy@arm.com/

Hi all,

I've finally been able to get back to this again, and I think it is now
hopefully ready to go. Changes from v3 are quite minor - basically a few
cosmetics and small tweaks (where I've taken the liberty of keeping
Baolu and Jason's review tags; hope that's OK!), the one functional
thing around blocking domains fixed, and plenty of reshuffling from
rebases. I'm happy to see that the IOMMUFD selftest problem has resolved
itself in the meantime, and it might even be able to use the standard
registration flow after this, however I'll leave that for someone else
more motivated, since my follow-up priority will be moving the of_xlate
business around at the bus level to sort out the probe_device ordering
mess once and for all.

Thanks,
Robin.


Robin Murphy (7):
  iommu: Factor out some helpers
  iommu: Decouple iommu_present() from bus ops
  iommu: Validate that devices match domains
  iommu: Switch __iommu_domain_alloc() to device ops
  iommu/arm-smmu: Don't register fwnode for legacy binding
  iommu: Retire bus ops
  iommu: Clean up open-coded ownership checks

 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |   3 -
 drivers/iommu/arm/arm-smmu/arm-smmu.c       |  12 +-
 drivers/iommu/arm/arm-smmu/qcom_iommu.c     |  14 +-
 drivers/iommu/iommu.c                       | 140 ++++++++++++++------
 drivers/iommu/mtk_iommu.c                   |   7 +-
 drivers/iommu/mtk_iommu_v1.c                |   3 -
 drivers/iommu/sprd-iommu.c                  |   8 +-
 drivers/iommu/virtio-iommu.c                |   3 -
 include/acpi/acpi_bus.h                     |   2 +
 include/linux/device.h                      |   1 -
 include/linux/device/bus.h                  |   5 -
 include/linux/dma-map-ops.h                 |   1 +
 include/linux/iommu.h                       |   1 +
 13 files changed, 108 insertions(+), 92 deletions(-)

Comments

Jason Gunthorpe Sept. 18, 2023, 4:24 p.m. UTC | #1 
On Fri, Sep 15, 2023 at 05:58:04PM +0100, Robin Murphy wrote:
> v2: https://lore.kernel.org/linux-iommu/cover.1674753627.git.robin.murphy@arm.com/
> 
> Hi all,
> 
> I've finally been able to get back to this again, and I think it is now
> hopefully ready to go. Changes from v3 are quite minor - basically a few
> cosmetics and small tweaks (where I've taken the liberty of keeping
> Baolu and Jason's review tags; hope that's OK!), the one functional

Looks OK

> thing around blocking domains fixed, and plenty of reshuffling from
> rebases. I'm happy to see that the IOMMUFD selftest problem has resolved
> itself in the meantime, and it might even be able to use the standard
> registration flow after this, however I'll leave that for someone else
> more motivated,

The main issue is the dedicated bus the test needs.

We can change the two wonky interfaces to two new APIs to add/remove a
new bus from iommu monitoring. Then the normal register APIs are
probably OK after this series.

Jason