From patchwork Thu Aug 22 07:13:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13772864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADD0BC3DA4A for ; Thu, 22 Aug 2024 07:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=CFMLU37SF14i0z7/xzd4z7SOLQqMigYLuSMvL0jdhU0=; b=fDzJE1aMO5iqoVFnY6JR/E+MKS 8ODvIFCl0DdGEvL9jTrDuYUHabOZxN+tBtUQgjZttGlp22P5bHwzIzQTWDXKPxuAl6DD0JFF6emvl 5Gn2pWIinbGN3MJlsCTURW+7W9EF+jr2PAis/WsDiTFTXUv0ubikQwVx1ynbGPN9ZT3Q1KTg9PBl4 XA8o/+1n7SwjLJSJKueN743bcXIGxy2dAIamKYdx+3EY/lN7rj0OxBS3+ruEErkH803tJ5mKmZrm+ 9LI0LYTPI3Z9tSbXLLR5Fc5m9hlnUWuSdssv+N/AYr+CXZ/gvGR43pz4Y7mUBxbM5tL+J7vyH9+SY Vd5YewoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh21s-0000000BnHG-0dL0; Thu, 22 Aug 2024 07:14:44 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh211-0000000Bmhc-0WSS for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 07:13:53 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-70941cb73e9so244051a34.2 for ; Thu, 22 Aug 2024 00:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1724310829; x=1724915629; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CFMLU37SF14i0z7/xzd4z7SOLQqMigYLuSMvL0jdhU0=; b=NxDamBvEWcSPxmAViuDeFjJMhXBD6ZIHkpzS1O5oVTSS1R7tRuMkG5YTVhAbBm4Jf1 TK3ZmVJDSwhD/nw3OuGdEw9IAqgvJAbYX+ClGlH2WN3uAVieQCHy4yMjYYecl6hYg+CG lXyI1HWAox3D/bR5/WpleazrjEBzWcnTtAQYU/sqDVW8Q2ifTWG9e4HyQ59c43NV7fpr JhE8qIfKw+b/15B/s+1qPjtjHUq+reMMTIyxrBAjCW3dhYq613IEIobGJbLtdFCJd2j5 NGxakdtTf0UE3rjLmWe1SDm8wvWaYTsft/4jrU7kqB5nCHWPO2IH2T3F3aKQtwMYk8wh Iesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724310829; x=1724915629; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CFMLU37SF14i0z7/xzd4z7SOLQqMigYLuSMvL0jdhU0=; b=k1X+CiIOLL/jwrlyWj2ifhO6yhhTfDU0Pl21QXDOFIpkZcipj7X89gXS5EsY0XQ96h kjpOB6n4KGKvV9JKaeRjiW/q5oyZhJzSYtZ8NNGuwWZjZJuMWAsliIgykj/gXIt5CbFy 8RvtE1BPe6M7ScCA78I6wmgIladNxYncqHP9bZGpwF3cUn3+YPdjdjHGkUhUAVZssG4X VsQ2pfaDpp637YYizD0hiaOZDZTVyUHa31nVOV8qcLYJ2FwqOrdLqwckj68woDYZMwSj CfpAyABLNbunXTHhfvkhLD0r46SIATF6XOYzD2xEK95vHDHfaG/7uJahR6pxBRF4hSPp X2Hw== X-Forwarded-Encrypted: i=1; AJvYcCVxlkSkNdakljGrqIysSsVNwhb562iki9cIagcGbdZZ1F8c+UofRo+/NVpIDz9J+hHcdVTDlXzsTFO/Lm2MeU/a@lists.infradead.org X-Gm-Message-State: AOJu0YzKFrzY3q7NqNT1bqsIPxa405L3qjIHwVQoDMS8G8CBzsYZGRo+ 4EIBvcqS6XZFbA2g3CcA4//f3+tykJSzxcapBlDVGKJszvlAw7t+ndrFYlWM7wQ= X-Google-Smtp-Source: AGHT+IHFVt0p20Eao8jGQp/M4A8gGxgTtYUk7Hnj/FFBLeb56GgWurcM0rgpuj3RCCjsswwc/siqyg== X-Received: by 2002:a05:6830:4386:b0:702:5a0:2f82 with SMTP id 46e09a7af769-70e043561e4mr1361943a34.0.1724310828958; Thu, 22 Aug 2024 00:13:48 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([240e:473:c90:f96:d029:ea8a:4e6d:d272]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7cd9ac994a3sm695095a12.16.2024.08.22.00.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 00:13:48 -0700 (PDT) From: Qi Zheng To: david@redhat.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Qi Zheng Subject: [PATCH v2 00/14] introduce pte_offset_map_{ro|rw}_nolock() Date: Thu, 22 Aug 2024 15:13:15 +0800 Message-Id: X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_001351_420603_57A7646E X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Changes in v2: - rename pte_offset_map_{readonly|maywrite}_nolock() to pte_offset_map_{ro|rw}_nolock() (LEROY Christophe) - make pte_offset_map_rw_nolock() not accept NULL parameters (David Hildenbrand) - rebase onto the next-20240822 Hi all, As proposed by David Hildenbrand [1], this series introduces the following two new helper functions to replace pte_offset_map_nolock(). 1. pte_offset_map_ro_nolock() 2. pte_offset_map_rw_nolock() As the name suggests, pte_offset_map_ro_nolock() is used for read-only case. In this case, only read-only operations will be performed on PTE page after the PTL is held. The RCU lock in pte_offset_map_nolock() will ensure that the PTE page will not be freed, and there is no need to worry about whether the pmd entry is modified. Therefore pte_offset_map_ro_nolock() is just a renamed version of pte_offset_map_nolock(). pte_offset_map_rw_nolock() is used for may-write case. In this case, the pte or pmd entry may be modified after the PTL is held, so we need to ensure that the pmd entry has not been modified concurrently. So in addition to the name change, it also outputs the pmdval when successful. This can help the caller recheck *pmd once the PTL is taken. In some cases, that is, either the mmap_lock for write, or pte_same() check on contents, is also enough to ensure that the pmd entry is stable. But in order to prevent the interface from being abused, we choose to pass in a dummy local variable instead of NULL. This series will convert all pte_offset_map_nolock() into the above two helper functions one by one, and finally completely delete it. This also a preparation for reclaiming the empty user PTE page table pages. This series is based on the next-20240822. Comments and suggestions are welcome! Thanks, Qi [1]. https://lore.kernel.org/lkml/f79bbfc9-bb4c-4da4-9902-2e73817dd135@redhat.com/ Qi Zheng (14): mm: pgtable: introduce pte_offset_map_{ro|rw}_nolock() arm: adjust_pte() use pte_offset_map_rw_nolock() powerpc: assert_pte_locked() use pte_offset_map_ro_nolock() mm: filemap: filemap_fault_recheck_pte_none() use pte_offset_map_ro_nolock() mm: khugepaged: __collapse_huge_page_swapin() use pte_offset_map_ro_nolock() mm: handle_pte_fault() use pte_offset_map_rw_nolock() mm: khugepaged: collapse_pte_mapped_thp() use pte_offset_map_rw_nolock() mm: copy_pte_range() use pte_offset_map_rw_nolock() mm: mremap: move_ptes() use pte_offset_map_rw_nolock() mm: page_vma_mapped_walk: map_pte() use pte_offset_map_rw_nolock() mm: userfaultfd: move_pages_pte() use pte_offset_map_rw_nolock() mm: multi-gen LRU: walk_pte_range() use pte_offset_map_rw_nolock() mm: pgtable: remove pte_offset_map_nolock() mm: khugepaged: retract_page_tables() use pte_offset_map_rw_nolock() Documentation/mm/split_page_table_lock.rst | 6 +++- arch/arm/mm/fault-armv.c | 9 ++++- arch/powerpc/mm/pgtable.c | 2 +- include/linux/mm.h | 7 ++-- mm/filemap.c | 4 +-- mm/khugepaged.c | 39 ++++++++++++++++++-- mm/memory.c | 23 ++++++++++-- mm/mremap.c | 9 ++++- mm/page_vma_mapped.c | 24 ++++++++++--- mm/pgtable-generic.c | 42 ++++++++++++++++------ mm/userfaultfd.c | 15 ++++++-- mm/vmscan.c | 9 ++++- 12 files changed, 157 insertions(+), 32 deletions(-)