From patchwork Thu Sep 26 08:38:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dragan Simic X-Patchwork-Id: 13813066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 902BFCCF9E9 for ; Thu, 26 Sep 2024 08:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=JyVuCIrRcBjtbj1uJvQkCOOG4PUr556iRdy/26xsPOc=; b=rfhFIMkyUrPO8Q633LZ3abhPsB D4m+YIK07XghEWeNKhwO7+9KUntQj2jyJyu254vMbD2zMkWR4IMxhMytzx+190PtEmvvCaiBKSvkf frrjlWUX77rWXMMSL42TuMTPT4w54C2x6kNp+eXJnL+Xsw1cDUMCeqKJ99884FjMVkNU2gIjLMu1a 4dRLwT/dRHyI4QBDA1A4oWZRcWMfsZO+igh9ZR579y0PeV6nf8RmwyAw3ymrn6V+IE8+L7nrG/yQw BJDCo/3HKFo2InBVLBBCa/nbblRIV04a7kuP8tpbng9jjABu3bY/kV+pdfqlaEEPwktJ6vb9ocR4Q lQRtTFJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stkFt-00000007lXc-1DMo; Thu, 26 Sep 2024 08:53:45 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stk14-00000007iFt-0vw2; Thu, 26 Sep 2024 08:38:27 +0000 From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1727339904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JyVuCIrRcBjtbj1uJvQkCOOG4PUr556iRdy/26xsPOc=; b=MwEgWUG0W8rwROkafIYlJAMV08BIxbtgZPgy9jX2TbDoeWO8T2YyLkT6YYYytGsy/ZjuMG 5l1IeHVIH87u54SXF2Iqs6v5igxprjFF9k7cm7sTo4Ut3DZwUDlIflzM6PVveGfAbVp7PP QHbKXTWWG8xOWYESmu7cBO4Yc6Kb+iMx0LW5ZHqZ+HOR3Bp2pB3WCUKZcApgH0dkDKJjlb W6Zk2EoEMtaYQmtcVTfGvF3/AqNu89KwDqSfU4x2s5zV+n10IuGA7H0FwpZLpz9VY6wR6y T2O1r3aRKwyTlmQ1SpSQcK2NsvCJFK9qwFLX2lQ3+tjwfdybLeOTdulwTW1H8g== To: linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: broonie@kernel.org, heiko@sntech.de, oss@helene.moe, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] Improve error handling in Rockchip SPI drivers Date: Thu, 26 Sep 2024 10:38:11 +0200 Message-Id: MIME-Version: 1.0 Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_013826_426375_20A5F129 X-CRM114-Status: UNSURE ( 6.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a small series that improves error handling in the probe path of the Rockchip SPI drivers, by using dev_err_probe() properly in multiple places. It also removes one unnecessary check of a function return value, and performs a bunch of small, rather trivial code cleanups, to make the code neater and a bit easier to read. Dragan Simic (5): spi: rockchip: Perform trivial code cleanups spi: rockchip-sfc: Perform trivial code cleanups spi: rockchip: Don't check for failed get_fifo_len() spi: rockchip: Use dev_err_probe() in the probe path spi: rockchip-sfc: Use dev_err_probe() in the probe path drivers/spi/spi-rockchip-sfc.c | 21 +++++-------- drivers/spi/spi-rockchip.c | 57 ++++++++++++++-------------------- 2 files changed, 32 insertions(+), 46 deletions(-) Reviewed-by: Heiko Stuebner