| Message ID | cover.1730449003.git.0x1207@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: stmmac: Refactor FPE as a separate module | expand |
On Fri, Nov 01, 2024 at 09:31:27PM +0800, Furong Xu wrote: > Refactor FPE implementation by moving common code for DWMAC4 and > DWXGMAC into a separate FPE module. > > FPE implementation for DWMAC4 and DWXGMAC differs only for: > 1) Offset address of MAC_FPE_CTRL_STS and MTL_FPE_CTRL_STS > 2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1 > 3) Bit offset of Frame Preemption Interrupt Enable > > Tested on DWMAC CORE 5.20a and DWXGMAC CORE 3.20a > > Changes in v8: > 1. Reorder functions in their natural calling order > 2. Unexport stmmac_fpe_configure() and make it static > 3. Swap 3rd patch and 4th patch in V7 For the series: Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Hi Vladimir, On Fri, 1 Nov 2024 16:29:08 +0200, Vladimir Oltean <olteanv@gmail.com> wrote: > For the series: > > Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Much appreciated for your valuable comments on this series and also the previous series that moves stmmac FPE over to the new standard ethtool-mm/tc-mqprio/tc-taprio. The FPE support on stmmac would never be so complete and so soon without your help. Have a nice weekend :)
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 1 Nov 2024 21:31:27 +0800 you wrote: > Refactor FPE implementation by moving common code for DWMAC4 and > DWXGMAC into a separate FPE module. > > FPE implementation for DWMAC4 and DWXGMAC differs only for: > 1) Offset address of MAC_FPE_CTRL_STS and MTL_FPE_CTRL_STS > 2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1 > 3) Bit offset of Frame Preemption Interrupt Enable > > [...] Here is the summary with links: - [net-next,v8,1/8] net: stmmac: Introduce separate files for FPE implementation https://git.kernel.org/netdev/net-next/c/2c6ad81de163 - [net-next,v8,2/8] net: stmmac: Rework macro definitions for gmac4 and xgmac https://git.kernel.org/netdev/net-next/c/61e6051f4bbb - [net-next,v8,3/8] net: stmmac: Introduce stmmac_fpe_supported() https://git.kernel.org/netdev/net-next/c/af478ca82204 - [net-next,v8,4/8] net: stmmac: Refactor FPE functions to generic version https://git.kernel.org/netdev/net-next/c/c9cd9a5a834c - [net-next,v8,5/8] net: stmmac: Get the TC number of net_device by netdev_get_num_tc() https://git.kernel.org/netdev/net-next/c/2558fe30ae8b - [net-next,v8,6/8] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ https://git.kernel.org/netdev/net-next/c/df9e7b0250ad - [net-next,v8,7/8] net: stmmac: xgmac: Complete FPE support https://git.kernel.org/netdev/net-next/c/b440d677e15f - [net-next,v8,8/8] net: stmmac: xgmac: Enable FPE for tc-mqprio/tc-taprio https://git.kernel.org/netdev/net-next/c/77be7d737305 You are awesome, thank you!
Refactor FPE implementation by moving common code for DWMAC4 and DWXGMAC into a separate FPE module. FPE implementation for DWMAC4 and DWXGMAC differs only for: 1) Offset address of MAC_FPE_CTRL_STS and MTL_FPE_CTRL_STS 2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1 3) Bit offset of Frame Preemption Interrupt Enable Tested on DWMAC CORE 5.20a and DWXGMAC CORE 3.20a Changes in v8: 1. Reorder functions in their natural calling order 2. Unexport stmmac_fpe_configure() and make it static 3. Swap 3rd patch and 4th patch in V7 V7: https://patchwork.kernel.org/project/netdevbpf/list/?series=905021&state=%2A&archive=both Changes in v7: 1. Split stmmac_fpe_supported() changes into a separate patch 2. Unexport stmmac_fpe_send_mpacket() and make it static 3. Convert to netdev_get_num_tc() 4. Commit message update for the 3rd patch V6: https://patchwork.kernel.org/project/netdevbpf/list/?series=904502&state=%2A&archive=both Changes in v6: 1. Introduce stmmac_fpe_supported() to improve compatibility 2. Remove redundant fpesel check 3. Remove redundant parameters of stmmac_fpe_configure() V5: https://patchwork.kernel.org/project/netdevbpf/list/?series=903628&state=%2A&archive=both Changes in v5: 1. Fix build errors reported by kernel test robot: https://lore.kernel.org/oe-kbuild-all/202410260025.sME33DwY-lkp@intel.com/ Changes in v4: 1. Update FPE IRQ handling 2. Check fpesel bit and stmmac_fpe_reg pointer to guarantee that driver does not crash on a certain platform that FPE is to be implemented Changes in v3: 1. Drop stmmac_fpe_ops and refactor FPE functions to generic version to avoid function pointers 2. Drop the _SHIFT macro definitions Changes in v2: 1. Split patches to easily review 2. Use struct as function param to keep param list short 3. Typo fixes in commit message and title Furong Xu (8): net: stmmac: Introduce separate files for FPE implementation net: stmmac: Rework macro definitions for gmac4 and xgmac net: stmmac: Introduce stmmac_fpe_supported() net: stmmac: Refactor FPE functions to generic version net: stmmac: Get the TC number of net_device by netdev_get_num_tc() net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ net: stmmac: xgmac: Complete FPE support net: stmmac: xgmac: Enable FPE for tc-mqprio/tc-taprio drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 - .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 11 +- drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 150 ------- drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 26 -- .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 6 +- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 31 +- drivers/net/ethernet/stmicro/stmmac/hwif.c | 7 + drivers/net/ethernet/stmicro/stmmac/hwif.h | 20 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 11 +- .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 +- .../net/ethernet/stmicro/stmmac/stmmac_fpe.c | 413 ++++++++++++++++++ .../net/ethernet/stmicro/stmmac/stmmac_fpe.h | 33 ++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 165 +------ .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 4 +- 15 files changed, 476 insertions(+), 412 deletions(-) create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h