[0/3] pwm: pxa: Use #pwm-cells = <3>

Message

Uwe Kleine-König Feb. 5, 2025, 5:53 p.m. UTC

Hello,

this series' goal is to soften the special device-tree binding of
marvel,pxa-pwm devices. This is the only binding that doesn't pass the
line index as first parameter. 

Here the #pwm-cells value is bumped from 1 to 3, keeping compatibility
with the old binding. 

The motivation for this was that Hervé sent a patch introducing pwm
nexus nodes which don't work nicely with the marvel,pxa-pwm
particularities.

For merging this series (assuming device-tree and pxa maintainers agree)
I guess keeping the patches together makes sense because with the 2nd
patch applied but without the 3rd there are a few dt-checker warnings.

So I suggest to take it via my pwm tree as I guess drivers/pwm/core.c
has more potential for a conflict than arch/arm/boot/dts/intel/pxa.
So please send Acks and tell me if you would need an immutable branch
for pulling into the PXA tree.

Best regards
Uwe

Uwe Kleine-König (3):
  pwm: Add upgrade path to #pwm-cells = <3> for users of
    of_pwm_single_xlate()
  dt-bindings: pwm: marvell,pxa-pwm: Update to use #pwm-cells = <3>
  ARM: dts: pxa: Use #pwm-cells = <3> for marvell,pxa-pwm devices

 .../devicetree/bindings/pwm/marvell,pxa-pwm.yaml |  3 +--
 arch/arm/boot/dts/intel/pxa/pxa25x.dtsi          |  4 ++--
 arch/arm/boot/dts/intel/pxa/pxa27x.dtsi          |  8 ++++----
 .../dts/intel/pxa/pxa300-raumfeld-controller.dts |  2 +-
 arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi          |  8 ++++----
 drivers/pwm/core.c                               | 16 ++++++++++++++++
 6 files changed, 28 insertions(+), 13 deletions(-)


base-commit: c98e66144b7d07ee9a3ca8241123b628a8ac0288

Comments

Daniel Mack Feb. 5, 2025, 6:32 p.m. UTC | #1

On 05.02.25 18:53, Uwe Kleine-König wrote:
> Hello,
> 
> this series' goal is to soften the special device-tree binding of
> marvel,pxa-pwm devices. This is the only binding that doesn't pass the
> line index as first parameter.
> 
> Here the #pwm-cells value is bumped from 1 to 3, keeping compatibility
> with the old binding.
> 
> The motivation for this was that Hervé sent a patch introducing pwm
> nexus nodes which don't work nicely with the marvel,pxa-pwm
> particularities.
> 
> For merging this series (assuming device-tree and pxa maintainers agree)
> I guess keeping the patches together makes sense because with the 2nd
> patch applied but without the 3rd there are a few dt-checker warnings.
> 
> So I suggest to take it via my pwm tree as I guess drivers/pwm/core.c
> has more potential for a conflict than arch/arm/boot/dts/intel/pxa.
> So please send Acks and tell me if you would need an immutable branch
> for pulling into the PXA tree.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>    pwm: Add upgrade path to #pwm-cells = <3> for users of
>      of_pwm_single_xlate()
>    dt-bindings: pwm: marvell,pxa-pwm: Update to use #pwm-cells = <3>
>    ARM: dts: pxa: Use #pwm-cells = <3> for marvell,pxa-pwm devices

For all patches in the series:

Reviewed-by: Daniel Mack <[e-mail]>

> 
>   .../devicetree/bindings/pwm/marvell,pxa-pwm.yaml |  3 +--
>   arch/arm/boot/dts/intel/pxa/pxa25x.dtsi          |  4 ++--
>   arch/arm/boot/dts/intel/pxa/pxa27x.dtsi          |  8 ++++----
>   .../dts/intel/pxa/pxa300-raumfeld-controller.dts |  2 +-
>   arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi          |  8 ++++----
>   drivers/pwm/core.c                               | 16 ++++++++++++++++
>   6 files changed, 28 insertions(+), 13 deletions(-)
> 
> 
> base-commit: c98e66144b7d07ee9a3ca8241123b628a8ac0288