From patchwork Tue Jul 31 08:19:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 1258521 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 8F735DF26F for ; Tue, 31 Jul 2012 08:24:02 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sw7fy-0002va-Ml; Tue, 31 Jul 2012 08:19:34 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sw7ff-0002uj-Po for linux-arm-kernel@lists.infradead.org; Tue, 31 Jul 2012 08:19:16 +0000 Received: from epcpsbgm1.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8000EVQMORVYF0@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 31 Jul 2012 17:19:02 +0900 (KST) X-AuditID: cbfee61a-b7f616d000004b7e-87-501794f5796b Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 56.64.19326.5F497105; Tue, 31 Jul 2012 17:19:01 +0900 (KST) Received: from DOJG1HAN02 ([12.23.119.56]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8000KFIN3PJ610@mmp1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 31 Jul 2012 17:19:01 +0900 (KST) From: Jingoo Han To: 'Marek Szyprowski' , 'Leela Krishna Amudala' References: <1343637905-17764-1-git-send-email-l.krishna@samsung.com> <1343637905-17764-2-git-send-email-l.krishna@samsung.com> <000001cd6e30$da849520$8f8dbf60$%han@samsung.com> <000a01cd6eb6$2113a050$633ae0f0$%han@samsung.com> <032201cd6ee5$ad4a0d50$07de27f0$%szyprowski@samsung.com> In-reply-to: <032201cd6ee5$ad4a0d50$07de27f0$%szyprowski@samsung.com> Subject: Re: [PATCH 1/3] Move FIMD register headers to include/video/ Date: Tue, 31 Jul 2012 17:19:01 +0900 Message-id: <000701cd6ef5$24315c70$6c941550$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac1uRMLhSNQsWcENTVy/nqZXgl8N0QAalZwAAA19XgAAA7VIsA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jAd2vU8QDDN5MtrTY9PgaqwOjx+Yl 9QGMUVw2Kak5mWWpRfp2CVwZbU0BBfuEK06fm8PYwHiFr4uRk0NCwETi+9dudghbTOLCvfVs XYxcHEICixglHjx5wAzhLGaSmHbmIiNIFZuAmsSXL4fBOkQEUiQaG94wgRQxC3QwSbTOn8YE 0fGaSeLy/9dgHZwCrhKzrz4H6uDgEAayv/blg5gsAqoSW74XgFTwCthKzNq5gRHCFpT4Mfke C4jNLKAlsX7ncSYIW15i85q3zCCtEgLqEo/+6kKc4CRx7OtxqHIRiX0v3jFOYBSahWTSLCST ZiGZNAtJywJGllWMoqkFyQXFSem5hnrFibnFpXnpesn5uZsYwWH8TGoH48oGi0OMAhyMSjy8 HifFAoRYE8uKK3MPMUpwMCuJ8DpmiAcI8aYkVlalFuXHF5XmpBYfYpTmYFES5zX2/uovJJCe WJKanZpakFoEk2Xi4JRqYHRV2/nga4lzv/sr73eBs9zXZGS85usIbOIWuypw61ok7/5j7KYH K74bZQiUlLZX2DEZnZ+cWPTmbLJh+f97GbVPjTmmh2pcZRScGnPEsiqWe/W0Xatjlou+Pbzu n3SiV+lEZvX97bc5n3rXTcw2SvseeYB9pvzju4cSpzesttVYfrBo6apQUyWW4oxEQy3mouJE AL8zvh9fAgAA X-TM-AS-MML: No X-Spam-Note: CRM114 invocation failed X-Spam-Note: SpamAssassin invocation failed Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Jingoo Han' , joshi@samsung.com, dri-devel@lists.freedesktop.org, inki.dae@samsung.com, kgene.kim@samsung.com, ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Tuesday, July 31, 2012 3:28 PM Marek Szyprowski wrote: > > Hello, > > On Tuesday, July 31, 2012 2:48 AM Jingoo Han wrote: > > > On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote: > > > > > > Hello Jingoo Han, > > > > > > On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han wrote: > > > > On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote: > > > >> > > > >> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side > > > >> to include/video/samsung_fimd.h > > > >> > > > >> Signed-off-by: Leela Krishna Amudala > > > >> --- > > > >> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 ------- > > > >> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 ----------------- > > > >> include/video/samsung_fimd.h | 533 +++++++++++++++++++++++ > > > >> 3 files changed, 533 insertions(+), 562 deletions(-) > > > >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h > > > >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h > > > >> create mode 100644 include/video/samsung_fimd.h > > > >> > > > >> +*/ > > > >> + > > > >> +/*FIMD V8 REG OFFSET */ > > > >> +#define FIMD_V8_VIDTCON0 (0x20010) > > > >> +#define FIMD_V8_VIDTCON1 (0x20014) > > > >> +#define FIMD_V8_VIDTCON2 (0x20018) > > > >> +#define FIMD_V8_VIDTCON3 (0x2001C) > > > >> +#define FIMD_V8_VIDCON1 (0x20004) > > > > > > How about using soc_is_exynos5250()? > > > > +#define VIDTCON0 (soc_is_exynos5250() ? \ > > + (0x20010) : (0x10)) > > > > In this case, the FIMD driver does not need to change. > > Also, one binary is available. > > Please don't mix two methods of runtime detection. FIMD driver (s3c-fb) already > has runtime hw detection based on platform device id. Adding such detection for > exynos5 to DRM FIMD driver should not be a big issue too. Marek, Then, do you want use like this? #define VIDTCON0 (0x10) +#define FIMD_V8_VIDTCON0 (0x20010) > Best regards > -- > Marek Szyprowski > Samsung Poland R&D Center --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c @@ -1924,7 +1924,7 @@ static struct s3c_fb_driverdata s3c_fb_data_exynos4 = { static struct s3c_fb_driverdata s3c_fb_data_exynos5 = { .variant = { .nr_windows = 5, - .vidtcon = VIDTCON0, + .vidtcon = FIMD_V8_VIDTCON0, >