From patchwork Wed Aug 17 01:17:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "boojin.kim" X-Patchwork-Id: 1072732 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7H1HnOf030062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 17 Aug 2011 01:18:10 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QtUlA-00031c-SX; Wed, 17 Aug 2011 01:17:33 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QtUlA-0002ML-D5; Wed, 17 Aug 2011 01:17:32 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QtUl6-0002M2-V5 for linux-arm-kernel@lists.infradead.org; Wed, 17 Aug 2011 01:17:30 +0000 Received: from epcpsbgm1.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LQ10007ASW8H720@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 17 Aug 2011 10:17:07 +0900 (KST) X-AuditID: cbfee61a-b7cf0ae000006bc6-78-4e4b1693a541 Received: from epmmp1 ( [203.254.227.16]) by epcpsbgm1.samsung.com (MMPCPMTA) with SMTP id 73.8C.27590.3961B4E4; Wed, 17 Aug 2011 10:17:07 +0900 (KST) Received: from DOBOOJINKIM03 (12-23-120-72.csky.net [12.23.120.72]) by mmp1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LQ1003IKSWJKT@mmp1.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 17 Aug 2011 10:17:07 +0900 (KST) Date: Wed, 17 Aug 2011 10:17:06 +0900 From: Boojin Kim Subject: RE: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock In-reply-to: <1313530266-14939-2-git-send-email-vz@mleia.com> To: "'Vladimir Zapolskiy'" , "'Kukjin Kim'" Message-id: <000b01cc5c7b$6184fce0$248ef6a0$%kim@samsung.com> X-Mailer: Microsoft Office Outlook 12.0 Content-language: ko Thread-index: AcxcXUSgR8jZzZZbSrqCxZny48AFOAAHVkDQ References: <1313530266-14939-1-git-send-email-vz@mleia.com> <1313530266-14939-2-git-send-email-vz@mleia.com> X-Brightmail-Tracker: AAAAAA== X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110816_211729_299210_B5385AB1 X-CRM114-Status: GOOD ( 22.43 ) X-Spam-Score: -3.4 (---) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-3.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [203.254.224.33 listed in list.dnswl.org] -1.1 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 17 Aug 2011 01:18:10 +0000 (UTC) Vladimir Zapolskiy wrote: > Sent: Wednesday, August 17, 2011 6:31 AM > To: Kukjin Kim > Cc: linux-samsung-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; Vladimir Zapolskiy; Boojin Kim > Subject: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock > > This change replaces s3c-pl330.x clock device names with dma-pl330.x, > otherwise there won't be a correspondence between clock device name > and amba device name, thus clocks can't be enabled. > > Fixes runtime errors on clk_get() from drivers/dma/pl330.c: > dma-pl330 dma-pl330.0: Cannot get operation clock. > dma-pl330: probe of dma-pl330.0 failed with error -22 > > Signed-off-by: Vladimir Zapolskiy > Cc: Boojin Kim > --- > arch/arm/mach-exynos4/clock.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach- > exynos4/clock.c > index fee2dd8..04c997a 100644 > --- a/arch/arm/mach-exynos4/clock.c > +++ b/arch/arm/mach-exynos4/clock.c > @@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = { > .ctrlbit = (1 << 10), > }, { > .name = "dma", > - .devname = "s3c-pl330.0", > + .devname = "dma-pl330.0", > .enable = exynos4_clk_ip_fsys_ctrl, > .ctrlbit = (1 << 0), > }, { > .name = "dma", > - .devname = "s3c-pl330.1", > + .devname = "dma-pl330.1", > .enable = exynos4_clk_ip_fsys_ctrl, > .ctrlbit = (1 << 1), > }, { > -- > 1.7.5.1 I checked this patch just now. This patch looks good to me. but this missed regarding s5p64x0 dma-pl330 clock. So, need to following. Ohters, looks ok to me Acked-by: Boojin Kim diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c b/arch/arm/mach-s5p64x0/clock-s5p6440.c index c1f548f..c54c65d 100644 --- a/arch/arm/mach-s5p64x0/clock-s5p6440.c +++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c @@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = { .ctrlbit = (1 << 8), }, { .name = "dma", + .devname = "dma-pl330", .parent = &clk_hclk_low.clk, .enable = s5p64x0_hclk0_ctrl, .ctrlbit = (1 << 12), diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c b/arch/arm/mach-s5p64x0/clock-s5p6450.c index 3d9b609..2d04abf 100644 --- a/arch/arm/mach-s5p64x0/clock-s5p6450.c +++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c @@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = { .ctrlbit = (1 << 3), }, { .name = "dma", + .devname = "dma-pl330", .parent = &clk_hclk_low.clk, .enable = s5p64x0_hclk0_ctrl, .ctrlbit = (1 << 12),