diff mbox

ARM: dts: disable MDMA1 node for smdk5420 board

Message ID 001a01cf5b0c$5ddc7d60$19957820$%jun@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Seungwon Jeon April 18, 2014, 1:44 p.m. UTC
This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
for arndale-octa board). If MDMA1 region is configured with secure mode,
it makes the boot failure with the following.

Unhandled fault: imprecise external abort (0x1406) at 0x00000000

Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Kim Kukjin April 22, 2014, 2:18 a.m. UTC | #1
Seungwon Jeon wrote:
> 

+ Javi Merino and Tushar Behera

> This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
> for arndale-octa board). If MDMA1 region is configured with secure mode,
> it makes the boot failure with the following.
> 
> Unhandled fault: imprecise external abort (0x1406) at 0x00000000
> 
If so, how about adding the 'disabled' status in 5420 dtsi file? Then if 'enabling' is required, we can enable in each board dt file...

- Kukjin

> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> index 6910485..9a48e3f 100644
> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -373,4 +373,10 @@
>  			};
>  		};
>  	};
> +
> +	amba {
> +		mdma1: mdma@11C10000 {
> +			status = "disabled";
> +		};
> +	};
>  };
> --
> 1.7.0.4
Tushar Behera April 22, 2014, 4:25 a.m. UTC | #2
On 22 April 2014 07:48, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Seungwon Jeon wrote:
>>
>
> + Javi Merino and Tushar Behera
>
>> This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
>> for arndale-octa board). If MDMA1 region is configured with secure mode,
>> it makes the boot failure with the following.
>>
>> Unhandled fault: imprecise external abort (0x1406) at 0x00000000
>>
> If so, how about adding the 'disabled' status in 5420 dtsi file? Then if 'enabling' is required, we can enable in each board dt file...
>

That should be okay. While at it, we can remove the node disabling
code from Arndale-Octa board DTS file.


> - Kukjin
>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> index 6910485..9a48e3f 100644
>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>> @@ -373,4 +373,10 @@
>>                       };
>>               };
>>       };
>> +
>> +     amba {
>> +             mdma1: mdma@11C10000 {
>> +                     status = "disabled";
>> +             };
>> +     };
>>  };
>> --
>> 1.7.0.4
>
Seungwon Jeon April 22, 2014, 7:01 a.m. UTC | #3
On Tue, April 22, 2014, Tushar Behera wrote:
> On 22 April 2014 07:48, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Seungwon Jeon wrote:
> >>
> >
> > + Javi Merino and Tushar Behera
> >
> >> This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
> >> for arndale-octa board). If MDMA1 region is configured with secure mode,
> >> it makes the boot failure with the following.
> >>
> >> Unhandled fault: imprecise external abort (0x1406) at 0x00000000
> >>
> > If so, how about adding the 'disabled' status in 5420 dtsi file? Then if 'enabling' is required, we
> can enable in each board dt file...
> >
> 
> That should be okay. While at it, we can remove the node disabling
> code from Arndale-Octa board DTS file.

OK, I'll consider both.

Thanks,
Seungwon Jeon

> 
> 
> > - Kukjin
> >
> >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos5420-smdk5420.dts |    6 ++++++
> >>  1 files changed, 6 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> index 6910485..9a48e3f 100644
> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> @@ -373,4 +373,10 @@
> >>                       };
> >>               };
> >>       };
> >> +
> >> +     amba {
> >> +             mdma1: mdma@11C10000 {
> >> +                     status = "disabled";
> >> +             };
> >> +     };
> >>  };
> >> --
> >> 1.7.0.4
> >
> 
> 
> 
> --
> Tushar Behera
Tushar Behera April 22, 2014, 8:23 a.m. UTC | #4
On 22 April 2014 12:31, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> On Tue, April 22, 2014, Tushar Behera wrote:
>> On 22 April 2014 07:48, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> > Seungwon Jeon wrote:
>> >>
>> >
>> > + Javi Merino and Tushar Behera
>> >
>> >> This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
>> >> for arndale-octa board). If MDMA1 region is configured with secure mode,
>> >> it makes the boot failure with the following.
>> >>
>> >> Unhandled fault: imprecise external abort (0x1406) at 0x00000000
>> >>
>> > If so, how about adding the 'disabled' status in 5420 dtsi file? Then if 'enabling' is required, we
>> can enable in each board dt file...
>> >
>>
>> That should be okay. While at it, we can remove the node disabling
>> code from Arndale-Octa board DTS file.
>
> OK, I'll consider both.
>
Seungwon,

Please move the comments for MDMA1 from Arndale-Octa dts file too.

Thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 6910485..9a48e3f 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -373,4 +373,10 @@ 
 			};
 		};
 	};
+
+	amba {
+		mdma1: mdma@11C10000 {
+			status = "disabled";
+		};
+	};
 };