From patchwork Thu Nov 22 11:33:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cho KyongHo X-Patchwork-Id: 1783601 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 3CAACDF230 for ; Thu, 22 Nov 2012 11:43:41 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TbV8p-0001vC-GM; Thu, 22 Nov 2012 11:40:26 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TbV89-0001Uj-TN for linux-arm-kernel@lists.infradead.org; Thu, 22 Nov 2012 11:39:44 +0000 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MDW00G2R03MJAR0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 22 Nov 2012 20:33:42 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C1.35.01231.69D0EA05; Thu, 22 Nov 2012 20:33:42 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-58-50ae0d96f60b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 90.35.01231.69D0EA05; Thu, 22 Nov 2012 20:33:42 +0900 (KST) Received: from DOPULLIPCHO06 ([12.23.118.152]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MDW00E63045Q190@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 22 Nov 2012 20:33:42 +0900 (KST) From: Cho KyongHo To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 11/12] iommu/exynos: add literal name of System MMU for debugging Date: Thu, 22 Nov 2012 20:33:41 +0900 Message-id: <002c01cdc8a5$3976abd0$ac640370$%cho@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac3IpTktbufXLw2oRj+8CCKi5uMPHw== Content-language: ko DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zfd1pvOsCDLqbtCw2Pb7G6sDosXlJ fQBjFJdNSmpOZllqkb5dAldGw8eHLAVbzSr2bZrB1MB4VbuLkZNDQsBE4sjK3ywQtpjEhXvr 2boYuTiEBJYxSiyZv5YZpqjn/i52iMR0Rolr/w6xQjjLmSROXH7ODlLFJqAlsXrucUaQhIhA L6PEhf6vTCAOs8APRonpm3+BLREWCJNoev4JaC4HB4uAqsTfc7IgYV4BW4mb368wQtiCEj8m 3wMrZwYaun7ncSYIW15i85q3YK0SAuoSj/7qgpgiAnoSU6Z5QVSISOx78Q5sCouAgMS3yYdY IKplJTYdYAY5RkKgm11i3eT97BCPSUocXHGDZQKj2Cwki2chWTwLyeJZSFYsYGRZxSiaWpBc UJyUnmuoV5yYW1yal66XnJ+7iRESK1I7GFc2WBxiFOBgVOLh1XReGyDEmlhWXJl7iFGCg1lJ hPce97oAId6UxMqq1KL8+KLSnNTiQ4w+QJdPZJYSTc4HxnFeSbyhsbGJmYmpibmlqbkpDmEl cd5mj5QAIYH0xJLU7NTUgtQimHFMHJxSDYxSvzx8U9aydn/wTfl2rkGy7vk7h1NsvgLm16pE djyqTLyt0B0tN7Hjhfz6S1ENFxVnBQpr5uz/9vt76OvQNYxlEg71ar/190/limSpauTXE/jw fvr685YbntVEsNen7jS8M/nbrKLZd/8WG+n/Urc6vC1V/FDbYeWj6u++3/076Yry4yt5X58q sRRnJBpqMRcVJwIAewN/LsICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t9jQd1pvOsCDL59UbbY9PgaqwOjx+Yl 9QGMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlA U5UUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGQ0fH7IUbDWr2LdpBlMD 41XtLkZODgkBE4me+7vYIWwxiQv31rN1MXJxCAlMZ5S49u8QK4SznEnixOXnYFVsAloSq+ce ZwRJiAj0Mkpc6P/KBOIwC/xglJi++RcLSJWwQJhE0/NPzF2MHBwsAqoSf8/JgoR5BWwlbn6/ wghhC0r8mHwPrJwZaOj6nceZIGx5ic1r3oK1SgioSzz6qwtiigjoSUyZ5gVRISKx78U7xgmM ArOQDJqFZNAsJINmIWlZwMiyilE0tSC5oDgpPddQrzgxt7g0L10vOT93EyM4Ep9J7WBc2WBx iFGAg1GJh1fTeW2AEGtiWXFl7iFGCQ5mJRHee9zrAoR4UxIrq1KL8uOLSnNSiw8x+gC9OZFZ SjQ5H5gk8kriDY1NzIwsjcwsjEzMzXEIK4nzNnukBAgJpCeWpGanphakFsGMY+LglGpgTLrA 0SHwSjUvRYFHnfHHQQaVfxejj1Ut+v/mhtWCQ9EtjRozftaFcTxc0c/cPEX/WSPLo1yXv8uV T4RtnOjw5on+kxjFhXd+C4aUTGhaV8WhV6X6QCOx79DczT3B3l+/yh57OzM5IqX0Njc/o/bW 4uD6Dn+L5MYV3PYr2/M5NguvtrrLx+CgxFKckWioxVxUnAgAovZGcPECAAA= X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121122_063942_818176_1A2D9807 X-CRM114-Status: GOOD ( 19.13 ) X-Spam-Score: -7.5 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers Cc: 'Kukjin Kim' , prathyush.k@samsung.com, 'Joerg Roedel' , sw0312.kim@samsung.com, 'Subash Patel' , 'Sanghyun Lee' , rahul.sharma@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This commit adds System MMU name to the driver data of each System MMU. It is used by fault information. Signed-off-by: KyongHo Cho --- drivers/iommu/exynos-iommu.c | 100 ++++++++++++++++++++++++++++++++----------- 1 file changed, 76 insertions(+), 24 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 985d317..4981afe 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include @@ -150,15 +151,21 @@ enum exynos_sysmmu_inttype { SYSMMU_FAULTS_NUM }; -/* +/** + * fault handler function type + * @dev: the client device + * @mmuname: name of the System MMU that generates fault * @itype: type of fault. * @pgtable_base: the physical address of page table base. This is 0 if @itype * is SYSMMU_BUSERROR. * @fault_addr: the device (virtual) address that the System MMU tried to * translated. This is 0 if @itype is SYSMMU_BUSERROR. */ -typedef int (*sysmmu_fault_handler_t)(enum exynos_sysmmu_inttype itype, - unsigned long pgtable_base, unsigned long fault_addr); +typedef int (*sysmmu_fault_handler_t)(struct device *dev, + const char *mmuname, + enum exynos_sysmmu_inttype itype, + unsigned long pgtable_base, + unsigned long fault_addr); static unsigned short fault_reg_offset[SYSMMU_FAULTS_NUM] = { REG_PAGE_FAULT_ADDR, @@ -234,6 +241,7 @@ struct sysmmu_drvdata { sysmmu_fault_handler_t fault_handler; unsigned long pgtable; bool runtime_active; + const char **mmuname; void __iomem *sfrbases[0]; }; @@ -611,16 +619,18 @@ void exynos_sysmmu_set_fault_handler(struct device *dev, spin_unlock_irqrestore(&owner->lock, flags); } -static int default_fault_handler(enum exynos_sysmmu_inttype itype, - unsigned long pgtable_base, unsigned long fault_addr) +static int default_fault_handler(struct device *dev, const char *mmuname, + enum exynos_sysmmu_inttype itype, + unsigned long pgtable_base, + unsigned long fault_addr) { unsigned long *ent; if ((itype >= SYSMMU_FAULTS_NUM) || (itype < SYSMMU_PAGEFAULT)) itype = SYSMMU_FAULT_UNKNOWN; - pr_err("%s occurred at 0x%lx(Page table base: 0x%lx)\n", - sysmmu_fault_name[itype], fault_addr, pgtable_base); + dev_err(dev, "%s occured at 0x%lx by '%s'(Page table base: 0x%lx)\n", + sysmmu_fault_name[itype], fault_addr, mmuname, pgtable_base); ent = section_entry(__va(pgtable_base), fault_addr); pr_err("\tLv1 entry: 0x%lx\n", *ent); @@ -641,25 +651,30 @@ static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id) { /* SYSMMU is in blocked when interrupt occurred. */ struct sysmmu_drvdata *data = dev_id; - struct resource *irqres; - struct platform_device *pdev; + struct exynos_iommu_owner *owner = NULL; enum exynos_sysmmu_inttype itype; unsigned long addr = -1; - + const char *mmuname = NULL; int i, ret = -ENOSYS; - spin_lock(&data->lock); + if (data->master) + owner = data->master->archdata.iommu; + + if (owner) + spin_lock(&owner->lock); WARN_ON(!is_sysmmu_active(data)); - pdev = to_platform_device(data->sysmmu); - for (i = 0; i < (pdev->num_resources / 2); i++) { - irqres = platform_get_resource(pdev, IORESOURCE_IRQ, i); + for (i = 0; i < data->nsfrs; i++) { + struct resource *irqres; + irqres = platform_get_resource( + to_platform_device(data->sysmmu), + IORESOURCE_IRQ, i); if (irqres && ((int)irqres->start == irq)) break; } - if (i == pdev->num_resources) { + if (i == data->nsfrs) { itype = SYSMMU_FAULT_UNKNOWN; } else { itype = (enum exynos_sysmmu_inttype) @@ -671,28 +686,34 @@ static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id) data->sfrbases[i] + fault_reg_offset[itype]); } - if (data->domain) - ret = report_iommu_fault(data->domain, data->master, + if (data->domain) /* owner is always set if data->domain exists */ + ret = report_iommu_fault(data->domain, owner->dev, addr, itype); if ((ret == -ENOSYS) && data->fault_handler) { unsigned long base = data->pgtable; + mmuname = (data->mmuname) ? data->mmuname[i] + : dev_name(data->sysmmu); + if (itype != SYSMMU_FAULT_UNKNOWN) base = __raw_readl( data->sfrbases[i] + REG_PT_BASE_ADDR); - ret = data->fault_handler(itype, base, addr); + ret = data->fault_handler(owner ? owner->dev : data->sysmmu, + mmuname, itype, base, addr); } if (!ret && (itype != SYSMMU_FAULT_UNKNOWN)) __raw_writel(1 << itype, data->sfrbases[i] + REG_INT_CLEAR); else - dev_dbg(data->sysmmu, "%s is not handled.\n", - sysmmu_fault_name[itype]); + dev_dbg(owner ? owner->dev : data->sysmmu, + "%s is not handled by %s\n", + sysmmu_fault_name[itype], + dev_name(data->sysmmu)); - if (itype != SYSMMU_FAULT_UNKNOWN) - sysmmu_unblock(data->sfrbases[i]); + sysmmu_unblock(data->sfrbases[i]); - spin_unlock(&data->lock); + if (owner) + spin_unlock(&owner->lock); return IRQ_HANDLED; } @@ -1050,6 +1071,30 @@ err_dev_put: return ret; } +static void __init __sysmmu_init_mmuname(struct device *sysmmu, + struct sysmmu_drvdata *drvdata) +{ + int i; + const char *mmuname; + + if (of_property_count_strings(sysmmu->of_node, "mmuname") != + drvdata->nsfrs) + return; + + drvdata->mmuname = (void *)drvdata->sfrbases + + sizeof(drvdata->sfrbases[0]) * drvdata->nsfrs; + + for (i = 0; i < drvdata->nsfrs; i++) { + if (of_property_read_string_index(sysmmu->of_node, + "mmuname", i, &mmuname)) + dev_err(sysmmu, "Failed read mmuname[%d]\n", i); + else + drvdata->mmuname[i] = kstrdup(mmuname, GFP_KERNEL); + if (!drvdata->mmuname[i]) + drvdata->mmuname[i] = "noname"; + } +} + static int __init exynos_sysmmu_probe(struct platform_device *pdev) { int i, ret; @@ -1061,9 +1106,14 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) return -ENODEV; } + ret = of_property_count_strings(pdev->dev.of_node, "mmuname"); + if (ret != (int)(pdev->num_resources / 2)) + ret = 0; + data = devm_kzalloc(dev, sizeof(*data) - + sizeof(*data->sfrbases) * (pdev->num_resources / 2), + + sizeof(*data->sfrbases) * (pdev->num_resources / 2) + + sizeof(*data->mmuname) * ret, GFP_KERNEL); if (!data) { dev_err(dev, "Not enough memory\n"); @@ -1107,6 +1157,8 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) ret = __sysmmu_setup(dev, data); if (!ret) { + __sysmmu_init_mmuname(dev, data); + data->runtime_active = !pm_runtime_enabled(dev); data->sysmmu = dev; spin_lock_init(&data->lock);