| Message ID | 003001ce4e1b$24a28fc0$6de7af40$@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jingoo, On Sat, May 11, 2013 at 12:42 AM, Jingoo Han <jg1.han@samsung.com> wrote: > The transition to common clock happened; however, DP (Display Port) > clock node was not added. Thus, DP (Display Port) clock node should > be added to the device tree. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > Tested on Exynos5250 > > arch/arm/boot/dts/exynos5250.dtsi | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Clock number matches clock bindings for 5250 and clock name matches dp driver, so this looks good. Reviewed-by: Doug Anderson <dianders@chromium.org>
Vikas Sajjan wrote: > > Hi Mr. Jingoo Han, > > On Sat, May 11, 2013 at 1:12 PM, Jingoo Han <jg1.han@samsung.com> wrote: > The transition to common clock happened; however, DP (Display Port) > clock node was not added. Thus, DP (Display Port) clock node should > be added to the device tree. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > Tested on Exynos5250 > > arch/arm/boot/dts/exynos5250.dtsi | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) [...] > I have already sent similar patch on 8th May 2013. > > http://www.spinics.net/lists/linux-samsung-soc/msg18136.html Vikas, please don't use html typed e-mail :-( OK, I found Jingoo's ack on that. Let me take that with Jingoo's ack and Doug's review tag. Thanks. - Kukjin
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 9dfc6de..8b1f9b6 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -651,6 +651,8 @@ reg = <0x145b0000 0x1000>; interrupts = <10 3>; interrupt-parent = <&combiner>; + clocks = <&clock 342>; + clock-names = "dp"; #address-cells = <1>; #size-cells = <0>;
The transition to common clock happened; however, DP (Display Port) clock node was not added. Thus, DP (Display Port) clock node should be added to the device tree. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- Tested on Exynos5250 arch/arm/boot/dts/exynos5250.dtsi | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)