From patchwork Wed Oct 16 01:24:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3049621 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0918EBF924 for ; Wed, 16 Oct 2013 01:25:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3173C202E6 for ; Wed, 16 Oct 2013 01:25:38 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41F39202B8 for ; Wed, 16 Oct 2013 01:25:37 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWFrh-0000lY-1z; Wed, 16 Oct 2013 01:25:33 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWFre-0003Mp-Hg; Wed, 16 Oct 2013 01:25:30 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWFrX-0003Lc-Eu for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2013 01:25:26 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUQ00D7SMLHXV50@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2013 10:24:58 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id F3.87.16566.9EAED525; Wed, 16 Oct 2013 10:24:57 +0900 (KST) X-AuditID: cbfee68e-b7f486d0000040b6-88-525deae993b4 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F3.B7.05832.9EAED525; Wed, 16 Oct 2013 10:24:57 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MUQ00GECMLLG760@mmp2.samsung.com>; Wed, 16 Oct 2013 10:24:57 +0900 (KST) From: Jingoo Han To: 'Marek Vasut' , linux-pci@vger.kernel.org References: <1381853200-5534-1-git-send-email-marex@denx.de> <1381853200-5534-2-git-send-email-marex@denx.de> In-reply-to: <1381853200-5534-2-git-send-email-marex@denx.de> Subject: Re: [PATCH 1/6] PCI: imx6: Make reset-gpio optional Date: Wed, 16 Oct 2013 10:24:56 +0900 Message-id: <006401ceca0e$86427be0$92c773a0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7JwJiDX6U4zURyT8Sq7v328e5jFgATUuFw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOKsWRmVeSWpSXmKPExsVy+t8zA92Xr2KDDCZsk7NY0pRh8fKQpsXl hZdYLS487WGz2PT4GqvF2XnH2Szuz97GbPGmrZHRYuPUX4wW7ZeULR7PErb4u30Ti8XTdUuY LVY0bWW0uHjiE7PFxkMdTBaNRx+wWrQ+ecBo8X/LZzYHYY+He3k85s06weLx73A/k8e5nrts Hjtn3WX3WLCp1GPTqk42j+8L57N73Lm2h81j85J6j/6/Bh59W1Yxejz9sZfZ4/iN7UwenzfJ BfBHcdmkpOZklqUW6dslcGW07L/DWNDAX/G5dy9jA+NUni5GTg4JAROJyy++MELYYhIX7q1n 62Lk4hASWMYoMXXLMyaYojtdPawQiemMEvObGsE6hAR+MUpMumgNYrMJqEl8+XKYHcQWEbCR +HRiB5jNLNDFKtHfUQ9Rny+x+tZSNhCbU8BWYmf3ebAFwkD1kxY1sYDYLAKqEs173zGD2LxA NbMXb2GFsAUlfky+xwIxU0ti/c7jTBC2vMTmNW+B6jmADlWXePRXF+IEI4lJL9tZIUpEJPa9 eMcIcr+EwH8OidlTd7JC7BKQ+Db5EAtEr6zEpgPMEP9KShxccYNlAqPELCSbZyHZPAvJ5llI VixgZFnFKJpakFxQnJReZKRXnJhbXJqXrpecn7uJEZKI+nYw3jxgfYgxGWj9RGYp0eR8YCLL K4k3NDYzsjA1MTU2Mrc0I01YSZxXrcU6UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAPjus0F 19bnB8S9dft4UVfl64LmrRMUXkx7tvrh5XInWwmHnPnNGR6V0r8OLtBL8xZ9m7G1cRqvYpri /hPfhIXqO/zlVjtWpu3wPzVdr+zyjq3hKw27K8s3V+kx/DcSizbMOv/x7b/YFPGfM6pWJW1p s5vz7LqwsnLD5YdyiwVYZZXDzqkUHjmpxFKckWioxVxUnAgAB11RfVoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCJsWRmVeSWpSXmKPExsVy+t9jQd2Xr2KDDLr+iVssacqweHlI0+Ly wkusFhee9rBZbHp8jdXi7LzjbBb3Z29jtnjT1shosXHqL0aL9kvKFo9nCVv83b6JxeLpuiXM FiuatjJaXDzxidli46EOJovGow9YLVqfPGC0+L/lM5uDsMfDvTwe82adYPH4d7ifyeNcz102 j52z7rJ7LNhU6rFpVSebx/eF89k97lzbw+axeUm9R/9fA4++LasYPZ7+2MvscfzGdiaPz5vk AvijGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4C+ VVIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jFmtOy/w1jQwF/xuXcvYwPj VJ4uRk4OCQETiTtdPawQtpjEhXvr2boYuTiEBKYzSsxvamQESQgJ/GKUmHTRGsRmE1CT+PLl MDuILSJgI/HpxA4wm1mgi1Wiv6Meoj5fYvWtpWwgNqeArcTO7vNMILYwUP2kRU0sIDaLgKpE 8953zCA2L1DN7MVbWCFsQYkfk++xQMzUkli/8zgThC0vsXnNW6B6DqBD1SUe/dWFOMFIYtLL dlaIEhGJfS/eMU5gFJqFZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ6blGesWJucWleel6yfm5 mxjBae6Z9A7GVQ0WhxgFOBiVeHhPRMUGCbEmlhVX5h5ilOBgVhLh5T8NFOJNSaysSi3Kjy8q zUktPsSYDPToRGYp0eR8YArOK4k3NDYxM7I0MrMwMjE3J01YSZz3YKt1oJBAemJJanZqakFq EcwWJg5OqQbGbQuY91vcq/u28NUm979J719tav63ahkX79E+voS5civF+LMMSq+Xy5TF2J2e U5Ml/UmqyOyxOW/thigO29QdveXlTqZxPl5zUnlevlSuE7f8V/LCmInR2Sjqyo0/OnaGXDde nXk+Q/X5p1eZLM5H5ppvLX184OJSKTbmd0JVrI2SWT/XKNYqsRRnJBpqMRcVJwIAldqHSbcD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131015_212523_838329_BB8B90CC X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -4.4 (----) Cc: 'Richard Zhu' , 'Pratyush Anand' , 'Siva Reddy Kallam' , 'Mohit KUMAR' , 'Sascha Hauer' , 'Jingoo Han' , 'Troy Kisky' , 'Kishon Vijay Abraham I' , 'Frank Li' , 'Srikanth T Shivanand' , 'Bjorn Helgaas' , 'Sean Cross' , 'Shawn Guo' , 'Yinghai Lu' , 'Tim Harvey' , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KHOP_BIG_TO_CC, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wednesday, October 16, 2013 1:07 AM, Marek Vasut wrote: > > Some boards do not have a PCIe reset GPIO. To avoid probe > failure on these boards, make the reset GPIO optional as > well. > > Signed-off-by: Marek Vasut [.....] > --- > .../devicetree/bindings/pci/designware-pcie.txt | 2 +- > drivers/pci/host/pci-imx6.c | 29 +++++++++++----------- > 2 files changed, 16 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt > b/Documentation/devicetree/bindings/pci/designware-pcie.txt > index d5d26d4..b7a2279 100644 > --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt > @@ -19,9 +19,9 @@ Required properties: > to define the mapping of the PCIe interface to interrupt > numbers. > - num-lanes: number of lanes to use > -- reset-gpio: gpio pin number of power good signal > > Optional properties for fsl,imx6q-pcie > +- reset-gpio: gpio pin number of power good signal > - power-on-gpio: gpio pin number of power-enable signal > - wake-up-gpio: gpio pin number of incoming wakeup signal > - disable-gpio: gpio pin number of outgoing rfkill/endpoint disable signal (+cc Kishon Vijay Abraham I) Also, 'reset-gpio' property can be used for 'samsung,exynos5440-pcie'. Thus, it is not specific for 'fsl,imx6q-pcie'. Please, modify it as below: Best regards, Jingoo Han --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt @@ -19,6 +19,8 @@ Required properties: to define the mapping of the PCIe interface to interrupt numbers. - num-lanes: number of lanes to use + +Optional properties - reset-gpio: gpio pin number of power good signal Optional properties for fsl,imx6q-pcie