From patchwork Mon Feb 24 09:07:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 11399875 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB18A14BC for ; Mon, 24 Feb 2020 09:37:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 887E920836 for ; Mon, 24 Feb 2020 09:37:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t5GHzTGq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="Wl6g0hPj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="cREm2nLi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 887E920836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ou+5tmlSkyMZirVxC7pyrUugQ4WiV2WLkeH3l0E/Ye4=; b=t5GHzTGqxa7xh+ Ty35j7qiXzWZEooMg2WtLO/0aGwJO2CgoCP0rXzIGbqZr4spkK5UqPceqmphzzDMPq79TBpOIGZJA MZCF2KhXNkYMuDE6HEbVkx0lZ3iorjFL/lcXZPLqSaOomok2/Hsmg443kQF6ISGXnv1uAK0eneo9b kIFAncRJ95NNtk0SWWbYoLE6iDw5gzgBVcMDiDRgjdKieUy4c/vlqOpeJSG59HeplXYbRf7aHfDCk pznXLce5LqXfnxvuqk/s+gYseIWED49CUJdax3PWs7zjUY8cnKn2M6MMzVtPNa2eAGNCRByhDKObd JoCflXspEN4ehzpqFblA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6ABY-0006u2-DA; Mon, 24 Feb 2020 09:37:56 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j69lN-0003tj-Ul; Mon, 24 Feb 2020 09:10:56 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 43F0B616; Mon, 24 Feb 2020 04:10:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 24 Feb 2020 04:10:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=FZIMsSvqEu67K Z2BsdsliCRua/N9ZIceMURgJL9sc78=; b=Wl6g0hPj02F+KFlO5VPffhNTAbt/o 2aEcf7NCi4+xgqAJzlECkDvHa1mNYWHfYnqPTegQ4QsSV+DtO+1KbOFerakwbfZ/ 3cGwK7P+XCt/zbWoc0bBxKsu8bRgi6y/Kl9MmwRxaUl36nEEe1lqhvQA4na3Wge5 65HKzcvhDsk5NuV1FPHoqgP6+7T6GTexhmBdw7cWAzDju4N/sM9KLg3r8qqlqDnl 3PrwJFhExdp7+AEgY+Sbkr6N44r309p90ao9x4KZQxT258NFwSXglelIQDU2iV36 gENIdvapg6U2iHoVkc/EoAU6AC7PuSp1HKD3sPOyVuicLRYptgaNnhMZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=FZIMsSvqEu67KZ2BsdsliCRua/N9ZIceMURgJL9sc78=; b=cREm2nLi hoVl2rKYolRCAC8AWNpfxns77gVg8P3ySbHXkVnGCMdHJjMSwtnAAUSmVX/jhb5P e8Chl+gqvdc9HTpNPUFxpgsEuhFQ27J1ZCoxIH4mxlbxA4nFA/VraAJLG4MebBAK GrtFsBDTrxVai05QzQkkOZyLRnK85gsSzdvc7YQUb4wtxDq1G2FDaGkBGdSUr5tU mqrGQqhU3P7zD/iphIxR3ld0C4zUk88AKyKCH9NLNQ0UK/xrzpnIUmGNfEPcwdCS TDWHcpQJH54v8syc0m942QGq4VDCr1og8QKlrGNFAVlRXv0/YMAUpGNluli2YuXa gSMun76sHmwd8w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledtucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhmvgcutfhi phgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecukfhppeeltddrkeelrd eikedrjeeinecuvehluhhsthgvrhfuihiivgepvdefnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 860FE3060F09; Mon, 24 Feb 2020 04:10:51 -0500 (EST) From: Maxime Ripard To: Nicolas Saenz Julienne , Eric Anholt Subject: [PATCH 85/89] drm/vc4: hdmi: Rename drm_encoder pointer in mode_valid Date: Mon, 24 Feb 2020 10:07:27 +0100 Message-Id: <025236a9624dcebf44521e22f002597bb1feabc8.1582533919.git-series.maxime@cerno.tech> X-Mailer: git-send-email 2.24.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_011054_199581_11E28A83 X-CRM114-Status: GOOD ( 10.55 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org, Maxime Ripard Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The mode_valid hook on the encoder uses a pointer to a drm_encoder called crtc, which is pretty confusing. Let's rename it to encoder to make it clear what it is. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 9b06352da377..2cbb950f5d5a 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -558,7 +558,7 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder) } static enum drm_mode_status -vc4_hdmi_encoder_mode_valid(struct drm_encoder *crtc, +vc4_hdmi_encoder_mode_valid(struct drm_encoder *encoder, const struct drm_display_mode *mode) { /* HSM clock must be 108% of the pixel clock. Additionally,