From patchwork Sat Nov 18 09:10:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064587 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7A27C60352 for ; Sat, 18 Nov 2017 09:12:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74BCD2A73C for ; Sat, 18 Nov 2017 09:12:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 696152A74D; Sat, 18 Nov 2017 09:12:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 054B42A75D for ; Sat, 18 Nov 2017 09:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=eivUTUi4qr1XhGptRlGPZLNKvMONXioyy7zP1so1bBY=; b=MTfAStSDDZLsl2DR1S4vi9jino FV0JdqJV23bS8+FY0H30Yx+R8aAGSZwAx6B1sD+JHKr/3TPrMb9KSapGo1+prngGamBsQkDUfJit4 0fWPj0nUFgJWMh+KUKwgV9p4tSKtYh1aVRF7rpGg1gjsemj1DI16pzWq929IFQX46lhlu6Kg28nkJ EoEap2XZFtGNA104LtF3sO3PM9t2S1rsaIj7T++V9DhstAP+vb9ATChRCV5Q/UVyt0zs5CflKWozl iUxtzjB827Y92wk9YRrGUis3LKVis2dNqA/7hIjx3aSqBVd1c8tVC90qvJZn67ZMqlDQnT0jlwGjq 7WfdG5og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFzAP-0005Ap-HA; Sat, 18 Nov 2017 09:12:01 +0000 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFzA5-0004s7-OA for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2017 09:11:45 +0000 Received: by mail-pf0-x241.google.com with SMTP id l24so3710963pfj.6 for ; Sat, 18 Nov 2017 01:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=bxo9z9GZJJZszU9YdinlLSZQzy7n9Mpk+lCSr2BBfO4=; b=FQcmPNBOzVuH/I/kY415aqsl+9+3zGtD8tzoAbXXj5QmjDthvFlpor95Eg427Cd2aq H66YABlXl2bVZBJMhVkwBXxQG882irrnp22tTliNTwj/8YjtaW1lX19J6VWLb+nZFnRL 4+RzM2Zcs7iZXe5ZZ6Dx9+QLuy8PPyZdTxC3TPBlfup6SkzpR9bgQ5rP/vcrdvMt8bwI d6MaEtjMdSW5RaiJFDztLmr7e+ZNequX+rD1yNp4zQlO+UaSmiVe4mxLQmfS8vg56NR/ vMLvkcRXLlnZ8vQE+rT8sGGh3WGwrW5r81vRTiui3GD7m9y5CQP+9SDN2wuujORozFwU D2rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=bxo9z9GZJJZszU9YdinlLSZQzy7n9Mpk+lCSr2BBfO4=; b=K+kQNjwjU4AqwItCePQZh8yducc/3hyJdY/hXoGOxndwLFPJlWLhsi8qvJHLTwHUC/ kn7rFd4UwQQ5PlA/364jw/0wi88Xg359a1wlpwctz4YI8KDN438R+n6+NwQeKb48G+5U BK4uFNlDzkYGJQpDCYwAs8MkzupXRbHgaxbL0rcVNAUnI7LcqpVxcenLGiBEmLXtAoCZ FFNtp5qzNL9dEy5qToemvgCd80X6m1aj43OPWTmFdGmhqE8iRDHPrB0NqG8eK0ApnMlY wjlFpFyVkTFu3xErWzQDWMHB48639+XpXZEGaEEr/3a0Yho7pNpwHLmgNoYpbHp3b9CE b3jw== X-Gm-Message-State: AJaThX6n/okMRxHnL0/HrOYWY1jroWlJf7rqwvcycO+7MVrvYBsCl7ct W9X+po4DEHAlZXSVhLSFkY4= X-Google-Smtp-Source: AGs4zMYQcgpIOfiijwmUq3GFqZWRMPT+3Kn28oB9No6hLAG792sFlXVceqExjgEsRDh8CyXrCbGnJA== X-Received: by 10.84.177.131 with SMTP id x3mr7746293plb.327.1510996281197; Sat, 18 Nov 2017 01:11:21 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id h81sm11158803pfh.119.2017.11.18.01.11.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Nov 2017 01:11:20 -0800 (PST) From: Arvind Yadav To: arnd@arndb.de, gregkh@linuxfoundation.org, joel@jms.id.au, nicolas.ferre@microchip.com, alexandre.belloni@free-electrons.com, linux@armlinux.org.uk Subject: [PATCH 2/2 v2] misc: atmel-ssc: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 14:40:13 +0530 Message-Id: <03c6f3e9df6d3077717e1f14b4775f2864a0304a.1510995185.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <6e238a28aa79c581c90329060805c0b07e2187a7.1510995185.git.arvind.yadav.cs@gmail.com> References: <6e238a28aa79c581c90329060805c0b07e2187a7.1510995185.git.arvind.yadav.cs@gmail.com> In-Reply-To: <6e238a28aa79c581c90329060805c0b07e2187a7.1510995185.git.arvind.yadav.cs@gmail.com> References: <6e238a28aa79c581c90329060805c0b07e2187a7.1510995185.git.arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171118_011142_075050_B94CFDF4 X-CRM114-Status: GOOD ( 11.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid. drivers/misc/atmel-ssc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index b2a0340..9d9eeae 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -235,9 +235,9 @@ static int ssc_probe(struct platform_device *pdev) clk_disable_unprepare(ssc->clk); ssc->irq = platform_get_irq(pdev, 0); - if (!ssc->irq) { + if (ssc->irq <= 0) { dev_dbg(&pdev->dev, "could not get irq\n"); - return -ENXIO; + return ssc->irq; } spin_lock(&user_lock);