| Message ID | 03f41ca8-68c6-f075-cb1e-c7f630a3b128@free.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Regenerate arm64 defconfig for current kernel | expand |
On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: > Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") > dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. > Looks good, Acked-by: Sudeep Holla <sudeep.holla@arm.com> But I left it intentionally to avoid churn assuming it will go away when ARM SoC team runs savedefconfig and sync the defconfig. -- Regards, Sudeep
On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: > > Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") > > dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. > > > > Looks good, > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > But I left it intentionally to avoid churn assuming it will go away when > ARM SoC team runs savedefconfig and sync the defconfig. I would never do that, instead I want patches like the one that Marc sent in order to make sure we don't accidentally drop anything that is still required, e.g. when an option got renamed or gained a dependency. Arnd
On 10/11/2018 09:57, Arnd Bergmann wrote: > On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla <sudeep.holla@arm.com> wrote: >> >> On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: >>> Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") >>> dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. >>> >> >> Looks good, >> >> Acked-by: Sudeep Holla <sudeep.holla@arm.com> >> >> But I left it intentionally to avoid churn assuming it will go away when >> ARM SoC team runs savedefconfig and sync the defconfig. > > I would never do that, Isn't that what commit c432c0880596 did? :-p $ git show --stat c432c0880596 arch/arm64/configs/defconfig | 102 +++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------- 1 file changed, 39 insertions(+), 63 deletions(-)
On 11/10/18, Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > On 10/11/2018 09:57, Arnd Bergmann wrote: > >> On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla <sudeep.holla@arm.com> >> wrote: >>> >>> On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: >>>> Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") >>>> dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. >>>> >>> >>> Looks good, >>> >>> Acked-by: Sudeep Holla <sudeep.holla@arm.com> >>> >>> But I left it intentionally to avoid churn assuming it will go away when >>> ARM SoC team runs savedefconfig and sync the defconfig. >> >> I would never do that, > > Isn't that what commit c432c0880596 did? :-p Olof did that one ;-) Arnd
On Sat, Nov 10, 2018 at 8:05 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On 11/10/18, Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: > > On 10/11/2018 09:57, Arnd Bergmann wrote: > > > >> On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla <sudeep.holla@arm.com> > >> wrote: > >>> > >>> On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: > >>>> Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") > >>>> dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. > >>>> > >>> > >>> Looks good, > >>> > >>> Acked-by: Sudeep Holla <sudeep.holla@arm.com> > >>> > >>> But I left it intentionally to avoid churn assuming it will go away when > >>> ARM SoC team runs savedefconfig and sync the defconfig. > >> > >> I would never do that, > > > > Isn't that what commit c432c0880596 did? :-p > > Olof did that one ;-) Yeah, it was because of churn caused by things moving over many releases. In the end, it's documenting what the kernel builds anyway. We don't do it often, I think this was the first time in recent memory. -Olof
On Sat, Nov 10, 2018 at 09:57:27AM +0100, Arnd Bergmann wrote: > On Thu, Nov 8, 2018 at 10:36 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > On Wed, Nov 07, 2018 at 11:39:42PM +0100, Marc Gonzalez wrote: > > > Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") > > > dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. > > > > > > > Looks good, > > > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > > > But I left it intentionally to avoid churn assuming it will go away when > > ARM SoC team runs savedefconfig and sync the defconfig. > > I would never do that, instead I want patches like the one that Marc sent > in order to make sure we don't accidentally drop anything that is still > required, e.g. when an option got renamed or gained a dependency. > Thanks for the clarification. I must have misunderstood what's done in Commit c432c0880596 ("arm64: defconfig: renormalize based on recent additions") I assume it was just the reordering rather than addition/removal of entries. It's not so clear from the log message. -- Regards, Sudeep
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f786c95504d3..8d6878c1e794 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -107,7 +107,6 @@ CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y CONFIG_CPUFREQ_DT=y CONFIG_ACPI_CPPC_CPUFREQ=m CONFIG_ARM_ARMADA_37XX_CPUFREQ=y -CONFIG_ARM_BIG_LITTLE_CPUFREQ=y CONFIG_ARM_SCPI_CPUFREQ=y CONFIG_ARM_TEGRA186_CPUFREQ=y CONFIG_ARM_SCPI_PROTOCOL=y
Commit a7314405d83c ("drop ARM_BIG_LITTLE_CPUFREQ support for ARM64") dropped ARM_BIG_LITTLE_CPUFREQ support for ARM64. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- arch/arm64/configs/defconfig | 1 - 1 file changed, 1 deletion(-)