From patchwork Mon Sep 3 13:10:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10585831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9132C139B for ; Mon, 3 Sep 2018 13:12:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CA5829341 for ; Mon, 3 Sep 2018 13:12:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D8FF29785; Mon, 3 Sep 2018 13:12:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F288029341 for ; Mon, 3 Sep 2018 13:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Z+Jw1QrYTiCk+HcOxtoJMIkvpCqJ6p3L2rRN7nldJn8=; b=RwDZpYH8DRzxCjSNImVpHe6fjT B9EyQYa2/DHn3rddqT2uhzGKO+/OqRcsk39AScExOuytcH9DqF1UCB5E/AhNwJLVRmcClDGIeMO99 OpLB9tyAFpkw06f96IFg07LP/XfKh3vK/szJL48g3iAbFXHIHuWuTXwi8I72T498cZAeoEjx4e0y+ f/nQStXXB7pJHReZht4N5/Rcdjvv0q2bmK6vOlTKG+RXPuDiZUoC0ZpqTjjkHHkU3LxbM6S1SsuM5 xiJUO9ZPJZcDz54Wn+dzx9GDNjTYVdwfo3QaTVhMure+khMmhPh4HykIVSeV0xyn6SneFXOSMbevw wR/mx7NQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fwoet-0001Vx-Ui; Mon, 03 Sep 2018 13:12:48 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fwodN-0000pF-G9 for linux-arm-kernel@lists.infradead.org; Mon, 03 Sep 2018 13:11:17 +0000 Received: by mail-wm0-x241.google.com with SMTP id s12-v6so1167864wmc.0 for ; Mon, 03 Sep 2018 06:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ZuPRWG0B4enQGXI2G2oBqHrb6zTd1Azps2shrb64GUU=; b=OYfUNFl57bmxosC7xk8Xsi/uLPSBLOLQHsj9lV3/vd1PlgzHq8xf5QHUir3BD7vs5j inDbwhjSAcuQTpWec61031DJl6KF7RLxKtzI6F3nRp233fIP0gOV8kkmCYlKZUNql9C8 +0NPKeg5OeTJPEiSViWy0QdK56ryGQOBQiABf5uo8rn7wPSr7xn1AfSYwDJy/nQGP4Cy 96VzOkBRfChYGe1QCK9zgr04OBRd9dBxrTp1P35STqGHW+rSiogqFp4b0ykycNI1cN8B 0H4lJ+wD5Ze5p9tRe4YgMBW1zOiW3n84NdMLCmt4EpYmq72VlaThXBD4C/7IugUp3RnC VbeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=ZuPRWG0B4enQGXI2G2oBqHrb6zTd1Azps2shrb64GUU=; b=EDzlTKDZ5HPiQfZq2QQA22sl7HICLbSL0yv0UnyK061lthQwknhc+aQ1v2UF5Tk3JR nswsbdaTuMKI4rpFi3XyDC73yMkHX4SnCLxwWDcZdTS6HjCqjrN7ex4F0WguX9bGIqMl Ka4kTsSVPvvDWw2OV19PJd9WRZQWIfDeft3uumc+oGYux+ajgK/AJkrNIFcmHOd2f+47 dq2sq3G8r/VHWOMkCAa6PT9cHQRxZI9GrV6TMgR8HKbc5eOFntEEEZ2KQIH/g11Mjow6 1e1mHnE3+1squmDR0u0Oa1OwcLIcTXUoUEuzMY2gLc8ctwsq0Co8MtMnMD9cJwGKRuZM ppXg== X-Gm-Message-State: APzg51A29rh4LH8xZFhvN+C546a4/cKmkkZH3GIjBC3G+NXPU5wJbLsU pMb/xQZdobeetrKgOBeY+y6sVg== X-Google-Smtp-Source: ANB0VdYWVBM+6Rh5h7FfDwqpBa0deOAjJ5zDnMFRER5EMLg6sEW0AKzPI9llykI4wfAhSa3J9ThFHA== X-Received: by 2002:a1c:cbc1:: with SMTP id b184-v6mr5423460wmg.149.1535980261568; Mon, 03 Sep 2018 06:11:01 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id a11-v6sm15592098wrr.81.2018.09.03.06.11.00 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 03 Sep 2018 06:11:01 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, gnomes@lxorguk.ukuu.org.uk, Alexander Graf , shubhraj@xilinx.com, robh@kernel.org Subject: [PATCH v3 01/10] serial: uartps: console_setup() can't be placed to init section Date: Mon, 3 Sep 2018 15:10:49 +0200 Message-Id: <08b079a26d5b5393ed58f68e55acbb1f9afe1821.1535980253.git.michal.simek@xilinx.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_061113_555935_8E7FA0E8 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When console device is rebinded, console_setup() is called again. But marking it as __init means that function will be clear after boot is complete. If console device is binded again console_setup() is not found and error "Unable to handle kernel paging request at virtual address" is reported. Signed-off-by: Michal Simek --- Changes in v3: - New patch found by testing Changes in v2: None drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index e5d90611c03f..dd905c981f67 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1216,7 +1216,7 @@ static void cdns_uart_console_write(struct console *co, const char *s, * * Return: 0 on success, negative errno otherwise. */ -static int __init cdns_uart_console_setup(struct console *co, char *options) +static int cdns_uart_console_setup(struct console *co, char *options) { struct uart_port *port = console_port;