From patchwork Fri Aug 10 04:56:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 1303971 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 98B553FC33 for ; Fri, 10 Aug 2012 04:59:34 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SzhHF-0005ny-Hs; Fri, 10 Aug 2012 04:56:49 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SzhHB-0005nk-HW for linux-arm-kernel@lists.infradead.org; Fri, 10 Aug 2012 04:56:47 +0000 Received: from epcpsbgm1.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8I00E1FWDNAA70@mailout3.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 10 Aug 2012 13:56:24 +0900 (KST) X-AuditID: cbfee61a-b7fc66d0000043b7-fd-502494776dc2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 3C.01.17335.77494205; Fri, 10 Aug 2012 13:56:23 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.119.152]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8I00BDFWDZTB20@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 10 Aug 2012 13:56:23 +0900 (KST) From: Kukjin Kim To: 'Mark Brown' References: <1344535549-4371-1-git-send-email-broonie@opensource.wolfsonmicro.com> In-reply-to: <1344535549-4371-1-git-send-email-broonie@opensource.wolfsonmicro.com> Subject: RE: [PATCH 1/2] ARM: S3C64XX: Update configuration for WM5102 module on Cragganmore Date: Fri, 10 Aug 2012 13:56:23 +0900 Message-id: <0db901cd76b4$7daf1730$790d4590$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac12WaB4E5G8igE6RuqdtOh9wZMNEwAWJWVQ Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t9jQd3yKSoBBssX21hsenyN1YHRY/OS +gDGKC6blNSczLLUIn27BK6Me62SBZPlK5pvtzA3ME6W7mLk5JAQMJFYtPUqK4QtJnHh3nq2 LkYuDiGB6YwSP3Z/hHKWMUl82b8frIpNQEPi8Ptn7F2MHBwiAmYSPw/ygISZBYok7h6YD1Yi JBAi8ezAc2aQEk6BUIkTJxJBwsICcRLXOq+ygdgsAqoS7Sv2MYHYvAK2EqsPPWCGsAUlfky+ xwIxUkti/c7jTBC2vMTmNW/BRkoIqEs8+qsLEhYRMJI4sn4xI0SJiMS+F+8YJzAKzUIyaRaS SbOQTJqFpGUBI8sqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjOAQfia1g3Flg8UhRgEORiUe 3kRelQAh1sSy4srcQ4wSHMxKIrwpL5QDhHhTEiurUovy44tKc1KLDzFKc7AoifMae3/1FxJI TyxJzU5NLUgtgskycXBKNTCuPas1q+OUSIp5gOLzr67a82eUV3Jy2iYGFyxb5HYofva7730a nQZ3fyySyc9azjl/3pqFy+zeuvDMsjPkmjRHeOJCPtYnNa/uiN788np17N+zkqGfJt7mbT0y bfsy0RY+lTSB7v3BiRl9Ioe/2z7xn73eaNtD4Uvv4ncubRDmztnr41Z5gttQiaU4I9FQi7mo OBEABHffVV0CAAA= X-TM-AS-MML: No X-Spam-Note: CRM114 invocation failed X-Spam-Score: -6.9 (------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-6.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.33 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-samsung-soc@vger.kernel.org, patches@opensource.wolfsonmicro.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Mark Brown wrote: > > SPI is also connected on the board, use that instead of I2C as it's much > faster. Also define platform data now the core driver is in mainline. > > Signed-off-by: Mark Brown > --- > arch/arm/mach-s3c64xx/mach-crag6410-module.c | 35 > ++++++++++++++++++++++---- > 1 file changed, 30 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach- > s3c64xx/mach-crag6410-module.c > index f81f089..22dd77b 100644 > --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c > +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c > @@ -192,9 +192,33 @@ static const struct i2c_board_info wm1277_devs[] = { > }, > }; > > -static const struct i2c_board_info wm5102_devs[] = { > - { I2C_BOARD_INFO("wm5102", 0x1a), > - .irq = GLENFARCLAS_PMIC_IRQ_BASE + WM831X_IRQ_GPIO_2, }, > +static struct arizona_pdata wm5102_pdata = { > + .ldoena = S3C64XX_GPN(7), > + .gpio_base = CODEC_GPIO_BASE, > + .irq_active_high = true, > + .micd_pol_gpio = CODEC_GPIO_BASE + 4, > + .gpio_defaults = { > + [2] = 0x10000, /* AIF3TXLRCLK */ > + [3] = 0x4, /* OPCLK */ > + }, > +}; Mark, happens error. arch/arm/mach-s3c64xx/mach-crag6410-module.c:184: error: variable 'wm5102_pdata' has initializer but incomplete type arch/arm/mach-s3c64xx/mach-crag6410-module.c:185: error: unknown field 'ldoena' specified in initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:185: warning: excess elements in struct initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:185: warning: (near initialization for 'wm5102_pdata') arch/arm/mach-s3c64xx/mach-crag6410-module.c:186: error: unknown field 'gpio_base' specified in initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:186: warning: excess elements in struct initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:186: warning: (near initialization for 'wm5102_pdata') arch/arm/mach-s3c64xx/mach-crag6410-module.c:187: error: unknown field 'irq_active_high' specified in initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:187: warning: excess elements in struct initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:187: warning: (near initialization for 'wm5102_pdata') arch/arm/mach-s3c64xx/mach-crag6410-module.c:188: error: unknown field 'micd_pol_gpio' specified in initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:188: warning: excess elements in struct initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:188: warning: (near initialization for 'wm5102_pdata') arch/arm/mach-s3c64xx/mach-crag6410-module.c:189: error: unknown field 'gpio_defaults' specified in initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:189: error: extra brace group at end of initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:189: error: (near initialization for 'wm5102_pdata') arch/arm/mach-s3c64xx/mach-crag6410-module.c:192: warning: excess elements in struct initializer arch/arm/mach-s3c64xx/mach-crag6410-module.c:192: warning: (near initialization for 'wm5102_pdata') make[1]: *** [arch/arm/mach-s3c64xx/mach-crag6410-module.o] Error 1 make: *** [arch/arm/mach-s3c64xx] Error 2 make: *** Waiting for unfinished jobs.... Probably, this patch needs following? --- If you're ok, I will fix build error by above when I apply. [...] Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c index c148384..7f4f9eb 100644 --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c @@ -16,6 +16,7 @@ #include #include #include +#include #include --