diff mbox

[1/2] ARM: S3C64XX: Update configuration for WM5102 module on Cragganmore

Message ID 0eff01cd777f$4c9d1f90$e5d75eb0$%kim@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kim Kukjin Aug. 11, 2012, 5:08 a.m. UTC 
Mark Brown wrote:
> 
> On Fri, Aug 10, 2012 at 01:56:23PM +0900, Kukjin Kim wrote:
> 
> > Probably, this patch needs following?
> 
> > If you're ok, I will fix build error by above when I apply.
> 
> Yes, thanks.

Applied.

BTW, don't you need to enable your Cragganmore board in the defconfig?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


From: Kukjin Kim <kgene.kim@samsung.com>
Subject: [PATCH] ARM: s3c6400_defconfig: enable more boards in defconfig

This enables all of s3c64xx boards in the s3c6400_defconfig.
In this time, MINI6410, REAL6410, and WLF_CRAGG_6410 are
added in the defconfig.

Cc: Darius Augulis <augulis.darius@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/configs/s3c6400_defconfig |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

initrd=0x51000000,6M ramdisk_size=6144"

Comments

Mark Brown Aug. 13, 2012, 12:24 p.m. UTC | #1 
On Sat, Aug 11, 2012 at 02:08:09PM +0900, Kukjin Kim wrote:

> BTW, don't you need to enable your Cragganmore board in the defconfig?

Well, it doesn't really matter that much to us - it's more a question
for whoever uses the defconfig.
Kim Kukjin Aug. 23, 2012, 9:45 a.m. UTC | #2 
Mark Brown wrote:
> 
> On Sat, Aug 11, 2012 at 02:08:09PM +0900, Kukjin Kim wrote:
> 
> > BTW, don't you need to enable your Cragganmore board in the defconfig?
> 
> Well, it doesn't really matter that much to us - it's more a question
> for whoever uses the defconfig.

Yeah, actually SoC defconfig in mainline doesn't cover _real_ requirements
for (mass) product. But I think, it's time we need to sort out the
defconfigs so that we could use them efficiently on product. BTW, if
enabling board in defconfig, at least, unexpected build breakages could be
detected by testing defconfig before merge for mainline...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Mark Brown Aug. 23, 2012, 3:20 p.m. UTC | #3 
On Thu, Aug 23, 2012 at 06:45:19PM +0900, Kukjin Kim wrote:

> Yeah, actually SoC defconfig in mainline doesn't cover _real_ requirements
> for (mass) product. But I think, it's time we need to sort out the
> defconfigs so that we could use them efficiently on product. BTW, if
> enabling board in defconfig, at least, unexpected build breakages could be
> detected by testing defconfig before merge for mainline...

Right, sure.  I guess the main thing I'm saying here is that I don't
mind what happens here, it's certainly no problem for me turn them on in
the build if that's what people wants.
diff mbox

Patch

diff --git a/arch/arm/configs/s3c6400_defconfig
b/arch/arm/configs/s3c6400_defconfig
index ba6a515..3a186d6 100644
--- a/arch/arm/configs/s3c6400_defconfig
+++ b/arch/arm/configs/s3c6400_defconfig
@@ -9,11 +9,14 @@  CONFIG_ARCH_S3C64XX=y
 CONFIG_S3C_BOOT_ERROR_RESET=y
 CONFIG_MACH_SMDK6400=y
 CONFIG_MACH_ANW6410=y
+CONFIG_MACH_MINI6410=y
+CONFIG_MACH_REAL6410=y
 CONFIG_MACH_SMDK6410=y
 CONFIG_MACH_NCP=y
 CONFIG_MACH_HMT=y
 CONFIG_MACH_SMARTQ5=y
 CONFIG_MACH_SMARTQ7=y
+CONFIG_MACH_WLF_CRAGG_6410=y
 CONFIG_CPU_32v6K=y
 CONFIG_AEABI=y
 CONFIG_CMDLINE="console=ttySAC0,115200 root=/dev/ram init=/linuxrc