From patchwork Wed Oct 7 07:59:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7343061 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 40D8A9F32B for ; Wed, 7 Oct 2015 08:02:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 795CF205EE for ; Wed, 7 Oct 2015 08:02:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA196205ED for ; Wed, 7 Oct 2015 08:02:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zjjdw-0000LH-Qe; Wed, 07 Oct 2015 08:00:08 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zjjds-0007Fz-OT for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2015 08:00:05 +0000 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0LtUuK-1ai3wq023Y-010wZR; Wed, 07 Oct 2015 09:59:36 +0200 From: Arnd Bergmann To: Jon Mason , Dave Jiang , Allen Hubbe Subject: [PATCH] NTB: fix 32-bit compiler warning Date: Wed, 07 Oct 2015 09:59:34 +0200 Message-ID: <10263287.Brd9HPYQJD@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:IIzmILVRV4LuIhCPKTMWGxj/sKqwqXka6DHX2vhcULqoK0KG5Jv j47ExXMVBazCFtuPS+WmF1LfZ7WujePg9QOJZwfrsStNgoWs4CeDrHVu4wH2zS/9OZhLvW4 jn8qadhKJNo1CS9sBGLkHhadzB3ZIrlM+Hk6mDpkd19u3J8sTRHyVW3utRpbovnDELb5CXL UXxA7kQgCr0eagU11DSmg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Iuy/LT6H+e8=:H/FxhD2z3/4/tLgLQ0tHv4 j+7o25+XGrPwm5RiReDF4VPRkfTUHR/mcsj0kCBdOK8ELwanBWap9y4xPX9U6g8KYA27sVK6u yPkljPFpdM7+YLFqqj+0TQ1P98Re/daboOynzh0MHrDlRJ5SpBm+BEHKz6Ss78D2/tQWjMn/W h81OjKIvvc+j+mgtDJw5hIUZGR6GYVyx+SxNkk1DY19JfxnR/K7dHKmOxlBL0g7tHKxKliyVF 8UySJSAP7Miy6wsaBriheMIUd+rk2UZnemOrjPjKvV3Lv3ZZ1Ei5jlkqGYvkWFiMFYUByxo8F Lyfso6Gj4Y8V9NYN93iRE4qb6TL89YBgFauSYCqxU79OnMYxBpe9zFRjG8UBmoO61p1HN/CEq XrtPDODqkxb8sfhzXQtgUDnZFtWsnHAbHR1y1QHgcTDB4goWOH8Ca/O84LQu+DYBbRHOa8gk/ rENFRwSQQTu7Aetan1RNQimp5HBizg11il2DJ5Qj7lnPCivRV8/eMc9JHaHnaAmeGlTYUfRly xJch39Ar38bEPl2KXhoOAmkuuN0OJijFda76H66lTM7w7cHI3jyyl6omgnpXAOWbjOouaY3xg LBWZkh4yCmjsNX+l72GBiwF+XuPJuhKNjWha1IhIDoQ+yiMFVI1T5KSA8TS1ULrC6DUFyAzGB zCykTL7PLZ9ors23KwPstToNa9LRTtHFBybf8qTfszsUzl6DoGxNkD2KDwOzV2M+VwbtX/2f6 UXhO3tTgPfctiAio X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151007_010005_048355_45915896 X-CRM114-Status: GOOD ( 13.26 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP resource_size_t may be 32-bit wide on some architectures, which causes this warning when building the NTB code: drivers/ntb/ntb_transport.c: In function 'ntb_transport_link_work': drivers/ntb/ntb_transport.c:828:46: warning: right shift count >= width of type [-Wshift-count-overflow] The warning is harmless but can be avoided by using the upper_32_bits() macro. Signed-off-by: Arnd Bergmann Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") --- Found while building ARM allmodconfig diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 6e3ee907d186..700f3ae833c2 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -825,10 +825,10 @@ static void ntb_transport_link_work(struct work_struct *work) size = max_mw_size; spad = MW0_SZ_HIGH + (i * 2); - ntb_peer_spad_write(ndev, spad, (u32)(size >> 32)); + ntb_peer_spad_write(ndev, spad, upper_32_bits(size)); spad = MW0_SZ_LOW + (i * 2); - ntb_peer_spad_write(ndev, spad, (u32)size); + ntb_peer_spad_write(ndev, spad, lower_32_bits(size)); } ntb_peer_spad_write(ndev, NUM_MWS, nt->mw_count);