| Message ID | 109601ce6679$fef2e410$fcd8ac30$%kim@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/11/2013 10:02 AM, Kukjin Kim wrote: > From: Giridhar Maruthy <giridhar.m@samsung.com> > > Since the pdma works only in secure mode, accessing the same > in hypervisor mode gives an abort. As we are not using pdma > anywhere (including spi), removing the same. > > Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> I was wondering, wouldn't it be sufficient to add status = "disabled"; in those pdma nodes, to avoid re-adding them in future ? As for the DMA properties in the spi device nodes, they should indeed be removed, as generic DMA bindings would be used instead. Regards, Sylwester > --- > arch/arm/boot/dts/exynos5440.dtsi | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi > index 871ebad..b08449e 100644 > --- a/arch/arm/boot/dts/exynos5440.dtsi > +++ b/arch/arm/boot/dts/exynos5440.dtsi > @@ -105,8 +105,6 @@ > compatible = "samsung,exynos4210-spi";Hmm, is there really no way to use PDMA in non-secure mode at all ? > reg = <0xD0000 0x1000>; > interrupts = <0 4 0>; > - tx-dma-channel = <&pdma0 5>; /* preliminary */ > - rx-dma-channel = <&pdma0 4>; /* preliminary */ > #address-cells = <1>; > #size-cells = <0>; > clocks = <&clock 21>, <&clock 16>; > @@ -184,28 +182,6 @@ > compatible = "arm,amba-bus"; > interrupt-parent = <&gic>; > ranges; > - > - pdma0: pdma@00121000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x121000 0x1000>; > - interrupts = <0 46 0>; > - clocks = <&clock 8>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > - > - pdma1: pdma@00120000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x120000 0x1000>; > - interrupts = <0 47 0>; > - clocks = <&clock 8>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > };
Sylwester Nawrocki wrote: > Hi Sylwester, > On 06/11/2013 10:02 AM, Kukjin Kim wrote: > > From: Giridhar Maruthy <giridhar.m@samsung.com> > > > > Since the pdma works only in secure mode, accessing the same > > in hypervisor mode gives an abort. As we are not using pdma > > anywhere (including spi), removing the same. > > > > Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com> > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> > > I was wondering, wouldn't it be sufficient to add status = "disabled"; > in those pdma nodes, to avoid re-adding them in future ? Yeah, could be. But the pdma will not be used on exynos5440 in future and if some guy use it in non-secure mode, it will cause problem, so I want to remove that. > As for the DMA properties in the spi device nodes, they should indeed > be removed, as generic DMA bindings would be used instead. > Yes, agreed. So I'd prefer to remove that :-) Thanks, Kukjin
diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi index 871ebad..b08449e 100644 --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm/boot/dts/exynos5440.dtsi @@ -105,8 +105,6 @@ compatible = "samsung,exynos4210-spi"; reg = <0xD0000 0x1000>; interrupts = <0 4 0>; - tx-dma-channel = <&pdma0 5>; /* preliminary */ - rx-dma-channel = <&pdma0 4>; /* preliminary */ #address-cells = <1>; #size-cells = <0>; clocks = <&clock 21>, <&clock 16>; @@ -184,28 +182,6 @@ compatible = "arm,amba-bus"; interrupt-parent = <&gic>; ranges; - - pdma0: pdma@00121000 { - compatible = "arm,pl330", "arm,primecell"; - reg = <0x121000 0x1000>; - interrupts = <0 46 0>; - clocks = <&clock 8>; - clock-names = "apb_pclk"; - #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; - }; - - pdma1: pdma@00120000 { - compatible = "arm,pl330", "arm,primecell"; - reg = <0x120000 0x1000>; - interrupts = <0 47 0>; - clocks = <&clock 8>; - clock-names = "apb_pclk"; - #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; - }; }; rtc {