diff mbox

ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()

Message ID 1308324110-21918-1-git-send-email-zonque@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Mack June 17, 2011, 3:21 p.m. UTC
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 arch/arm/mach-omap2/board-overo.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Kevin Hilman June 17, 2011, 4:03 p.m. UTC | #1
Daniel Mack <zonque@gmail.com> writes:

> Signed-off-by: Daniel Mack <zonque@gmail.com>

Thanks for fixing this, I noticed this recently too.

Please add a descriptive changelog.  For example, why is it duplcate?
where is it already done?  what commit added the extra call, what
problems does it cause, etc.

Also, your subject says 'illegal', but it's not really illegal.  It's just
wrong. :)   "remove duplcate call to..." is enough.

Thanks,

Kevin


> ---
>  arch/arm/mach-omap2/board-overo.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 175e1ab..110475f 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -568,7 +568,6 @@ static void __init overo_init(void)
>  	usb_musb_init(NULL);
>  	usbhs_init(&usbhs_bdata);
>  	overo_spi_init();
> -	overo_ads7846_init();
>  	overo_init_smsc911x();
>  	overo_display_init();
>  	overo_init_led();
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 175e1ab..110475f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -568,7 +568,6 @@  static void __init overo_init(void)
 	usb_musb_init(NULL);
 	usbhs_init(&usbhs_bdata);
 	overo_spi_init();
-	overo_ads7846_init();
 	overo_init_smsc911x();
 	overo_display_init();
 	overo_init_led();