| Message ID | 1310377091-18103-1-git-send-email-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 11, 2011 at 11:38:11AM +0200, Linus Walleij wrote: > Not only does this file duplicate <linux/bitops.h> and implement a > well-known antipattern, it is also not used by anything. > > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> > --- > arch/arm/mach-integrator/include/mach/bits.h | 61 -------------------------- > 1 files changed, 0 insertions(+), 61 deletions(-) > delete mode 100644 arch/arm/mach-integrator/include/mach/bits.h > > diff --git a/arch/arm/mach-integrator/include/mach/bits.h b/arch/arm/mach-integrator/include/mach/bits.h > deleted file mode 100644 > index 09b024e..0000000 > --- a/arch/arm/mach-integrator/include/mach/bits.h > +++ /dev/null > @@ -1,61 +0,0 @@ > -/* > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > - */ > -/* DO NOT EDIT!! - this file automatically generated > - * from .s file by awk -f s2h.awk > - */ > -/* Bit field definitions > - * Copyright (C) ARM Limited 1998. All rights reserved. > - */ > - > -#ifndef __bits_h > -#define __bits_h 1 > - > -#define BIT0 0x00000001 > -#define BIT1 0x00000002 > -#define BIT2 0x00000004 > -#define BIT3 0x00000008 > -#define BIT4 0x00000010 > -#define BIT5 0x00000020 > -#define BIT6 0x00000040 > -#define BIT7 0x00000080 > -#define BIT8 0x00000100 > -#define BIT9 0x00000200 > -#define BIT10 0x00000400 > -#define BIT11 0x00000800 > -#define BIT12 0x00001000 > -#define BIT13 0x00002000 > -#define BIT14 0x00004000 > -#define BIT15 0x00008000 > -#define BIT16 0x00010000 > -#define BIT17 0x00020000 > -#define BIT18 0x00040000 > -#define BIT19 0x00080000 > -#define BIT20 0x00100000 > -#define BIT21 0x00200000 > -#define BIT22 0x00400000 > -#define BIT23 0x00800000 > -#define BIT24 0x01000000 > -#define BIT25 0x02000000 > -#define BIT26 0x04000000 > -#define BIT27 0x08000000 > -#define BIT28 0x10000000 > -#define BIT29 0x20000000 > -#define BIT30 0x40000000 > -#define BIT31 0x80000000 > - > -#endif > - > -/* END */ > -- > 1.7.6 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Monday 11 July 2011, Russell King - ARM Linux wrote: > On Mon, Jul 11, 2011 at 11:38:11AM +0200, Linus Walleij wrote: > > Not only does this file duplicate <linux/bitops.h> and implement a > > well-known antipattern, it is also not used by anything. > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> Applied to arm-soc/next/cleanup Thanks, Arnd
diff --git a/arch/arm/mach-integrator/include/mach/bits.h b/arch/arm/mach-integrator/include/mach/bits.h deleted file mode 100644 index 09b024e..0000000 --- a/arch/arm/mach-integrator/include/mach/bits.h +++ /dev/null @@ -1,61 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - */ -/* DO NOT EDIT!! - this file automatically generated - * from .s file by awk -f s2h.awk - */ -/* Bit field definitions - * Copyright (C) ARM Limited 1998. All rights reserved. - */ - -#ifndef __bits_h -#define __bits_h 1 - -#define BIT0 0x00000001 -#define BIT1 0x00000002 -#define BIT2 0x00000004 -#define BIT3 0x00000008 -#define BIT4 0x00000010 -#define BIT5 0x00000020 -#define BIT6 0x00000040 -#define BIT7 0x00000080 -#define BIT8 0x00000100 -#define BIT9 0x00000200 -#define BIT10 0x00000400 -#define BIT11 0x00000800 -#define BIT12 0x00001000 -#define BIT13 0x00002000 -#define BIT14 0x00004000 -#define BIT15 0x00008000 -#define BIT16 0x00010000 -#define BIT17 0x00020000 -#define BIT18 0x00040000 -#define BIT19 0x00080000 -#define BIT20 0x00100000 -#define BIT21 0x00200000 -#define BIT22 0x00400000 -#define BIT23 0x00800000 -#define BIT24 0x01000000 -#define BIT25 0x02000000 -#define BIT26 0x04000000 -#define BIT27 0x08000000 -#define BIT28 0x10000000 -#define BIT29 0x20000000 -#define BIT30 0x40000000 -#define BIT31 0x80000000 - -#endif - -/* END */
Not only does this file duplicate <linux/bitops.h> and implement a well-known antipattern, it is also not used by anything. Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- arch/arm/mach-integrator/include/mach/bits.h | 61 -------------------------- 1 files changed, 0 insertions(+), 61 deletions(-) delete mode 100644 arch/arm/mach-integrator/include/mach/bits.h