From patchwork Wed Aug 3 07:18:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: axel lin X-Patchwork-Id: 1030662 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p737IdWR024098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 3 Aug 2011 07:19:01 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QoVio-0005rj-AS; Wed, 03 Aug 2011 07:18:30 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QoVin-0004xD-HQ; Wed, 03 Aug 2011 07:18:29 +0000 Received: from mail-iy0-f177.google.com ([209.85.210.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QoVij-0004vx-DG for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2011 07:18:26 +0000 Received: by iyn15 with SMTP id 15so808048iyn.36 for ; Wed, 03 Aug 2011 00:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=FOV8JLP71Ah4Tv8Rfim+C3at7DkG/EKHcNlxiNdLlaU=; b=TTiLzMTVZr5Q4UriO9JBXd1upDVZ2OqsLUoRroIkZPyziQfZubUagO4dWsAfJSFMqd FOWJxPNU124GvFzX4AOuXJvz0HW6ocKpPZpignR4ySx948cDqO3kglUs29CyGqYu4sRC 1tb9f5BfpRDoFZoc+1qJ9kNBdyzyXHTaG1Ss4= Received: by 10.231.117.158 with SMTP id r30mr4468218ibq.189.1312355902784; Wed, 03 Aug 2011 00:18:22 -0700 (PDT) Received: from [218.172.237.169] (218-172-237-169.dynamic.hinet.net [218.172.237.169]) by mx.google.com with ESMTPS id v16sm399173ibe.51.2011.08.03.00.18.20 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 03 Aug 2011 00:18:22 -0700 (PDT) Subject: [PATCH RESEND] omap1: select GENERIC_IRQ_CHIP for TI OMAP1 From: Axel Lin To: linux-kernel@vger.kernel.org Date: Wed, 03 Aug 2011 15:18:17 +0800 Message-ID: <1312355897.14329.5.camel@phoenix> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110803_031825_611767_76D06D69 X-CRM114-Status: GOOD ( 13.87 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (axel.lin[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_TO_NO_BRKTS_FREEMAIL To: misformatted and free email service Cc: Kevin Hilman , Tony Lindgren , linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 03 Aug 2011 07:19:01 +0000 (UTC) The gpio-omap driver has been converted to use generic IRQ chip. Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. LD vmlinux drivers/built-in.o: In function `omap_mpuio_alloc_gc': drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_generic_chip' drivers/gpio/gpio-omap.c:1100: undefined reference to `irq_setup_generic_chip' drivers/built-in.o: In function `omap_gpio_show_rev': drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_clr_bit' drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_set_bit' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- Kevin already sent a similar patch. http://marc.info/?l=linux-omap&m=130749135312468&w=2 But I still have the build error with make omap1_defconfig in today's linux-next tree. So here is a resend. Regards, Axel arch/arm/plat-omap/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index 6e6735f..bb8f4a6 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -13,6 +13,7 @@ config ARCH_OMAP1 bool "TI OMAP1" select CLKDEV_LOOKUP select CLKSRC_MMIO + select GENERIC_IRQ_CHIP help "Systems based on omap7xx, omap15xx or omap16xx"