diff mbox

[08/19] mach-davinci: move DaVinci TNET GPIO driver to GPIO subsystem

Message ID 1312978639-18339-1-git-send-email-linus.walleij@stericsson.com (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Aug. 10, 2011, 12:17 p.m. UTC 
From: Linus Walleij <linus.walleij@linaro.org>

As per example from the other ARM boards, push the DaVinci TNET
GPIO driver down to the GPIO subsystem so it can be consolidated.

Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/mach-davinci/Makefile                     |    1 -
 drivers/gpio/Makefile                              |    1 +
 .../mach-davinci => drivers/gpio}/gpio-tnetv107x.c |    0
 3 files changed, 1 insertions(+), 1 deletions(-)
 rename {arch/arm/mach-davinci => drivers/gpio}/gpio-tnetv107x.c (100%)

diff --git a/arch/arm/mach-davinci/gpio-tnetv107x.c b/drivers/gpio/gpio-tnetv107x.c
similarity index 100%
rename from arch/arm/mach-davinci/gpio-tnetv107x.c
rename to drivers/gpio/gpio-tnetv107x.c

Comments

Sekhar Nori Aug. 10, 2011, 10:21 p.m. UTC | #1 
Hi Linus,

On Wed, Aug 10, 2011 at 17:47:19, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> As per example from the other ARM boards, push the DaVinci TNET
> GPIO driver down to the GPIO subsystem so it can be consolidated.
> 
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

There should be no need of this since the TNETV107x
GPIO can simply be supported using the basic MMIO GPIO
driver. I submitted patches for that a while back
but have some comments from Grant to address. He requested
some changes to be done to the basic MMIO GPIO driver
itself.

https://lkml.org/lkml/2011/7/5/16

I do plan to rework those patches and post them back.

Thanks,
Sekhar
Linus Walleij Aug. 11, 2011, 1:06 p.m. UTC | #2 
On Thu, Aug 11, 2011 at 12:21 AM, Nori, Sekhar <nsekhar@ti.com> wrote:
> Hi Linus,
>
> On Wed, Aug 10, 2011 at 17:47:19, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>>
>> As per example from the other ARM boards, push the DaVinci TNET
>> GPIO driver down to the GPIO subsystem so it can be consolidated.
>>
>> Cc: Sekhar Nori <nsekhar@ti.com>
>> Cc: Kevin Hilman <khilman@ti.com>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> There should be no need of this since the TNETV107x
> GPIO can simply be supported using the basic MMIO GPIO
> driver. I submitted patches for that a while back
> but have some comments from Grant to address. He requested
> some changes to be done to the basic MMIO GPIO driver
> itself.
>
> https://lkml.org/lkml/2011/7/5/16
>
> I do plan to rework those patches and post them back.

OK I will keep this around in case it doesn't happen
soon, it certainly does not make matters worse
anyway.

Thanks,
Linus Walleij
Sekhar Nori Aug. 12, 2011, 9:30 p.m. UTC | #3 
On Thu, Aug 11, 2011 at 18:36:07, Linus Walleij wrote:
> On Thu, Aug 11, 2011 at 12:21 AM, Nori, Sekhar <nsekhar@ti.com> wrote:
> > Hi Linus,
> >
> > On Wed, Aug 10, 2011 at 17:47:19, Linus Walleij wrote:
> >> From: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> As per example from the other ARM boards, push the DaVinci TNET
> >> GPIO driver down to the GPIO subsystem so it can be consolidated.
> >>
> >> Cc: Sekhar Nori <nsekhar@ti.com>
> >> Cc: Kevin Hilman <khilman@ti.com>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > There should be no need of this since the TNETV107x
> > GPIO can simply be supported using the basic MMIO GPIO
> > driver. I submitted patches for that a while back
> > but have some comments from Grant to address. He requested
> > some changes to be done to the basic MMIO GPIO driver
> > itself.
> >
> > https://lkml.org/lkml/2011/7/5/16
> >
> > I do plan to rework those patches and post them back.
> 
> OK I will keep this around in case it doesn't happen
> soon, it certainly does not make matters worse
> anyway.

I am OK either way. Its going to be Grant's call since
it will result in some churn in GPIO tree.

Thanks,
Sekhar
diff mbox

Patch

diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile
index 8f3c8ee..495e313 100644
--- a/arch/arm/mach-davinci/Makefile
+++ b/arch/arm/mach-davinci/Makefile
@@ -17,7 +17,6 @@  obj-$(CONFIG_ARCH_DAVINCI_DM365)	+= dm365.o devices.o
 obj-$(CONFIG_ARCH_DAVINCI_DA830)        += da830.o devices-da8xx.o
 obj-$(CONFIG_ARCH_DAVINCI_DA850)        += da850.o devices-da8xx.o
 obj-$(CONFIG_ARCH_DAVINCI_TNETV107X)    += tnetv107x.o devices-tnetv107x.o
-obj-$(CONFIG_ARCH_DAVINCI_TNETV107X)    += gpio-tnetv107x.o
 
 obj-$(CONFIG_AINTC)			+= irq.o
 obj-$(CONFIG_CP_INTC)			+= cp_intc.o
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index a26fffa..2269822 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -51,6 +51,7 @@  obj-$(CONFIG_GPIO_SX150X)	+= gpio-sx150x.o
 obj-$(CONFIG_GPIO_TC3589X)	+= gpio-tc3589x.o
 obj-$(CONFIG_ARCH_TEGRA)	+= gpio-tegra.o
 obj-$(CONFIG_GPIO_TIMBERDALE)	+= gpio-timberdale.o
+obj-$(CONFIG_ARCH_DAVINCI_TNETV107X) += gpio-tnetv107x.o
 obj-$(CONFIG_GPIO_TPS65910)	+= gpio-tps65910.o
 obj-$(CONFIG_GPIO_TPS65912)	+= gpio-tps65912.o
 obj-$(CONFIG_GPIO_TWL4030)	+= gpio-twl4030.o