| Message ID | 1341058142-30438-2-git-send-email-sylvester.nawrocki@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Sylwester Nawrocki wrote: > The backlight gpio must not be left requested in the board > code, otherwise s3c24xx_led driver can't successfully claim it. > So request the backlight gpio, configure it to proper state and > gpio_free right away. > > This change is required for converting the s3c24xx_led driver > to the gpiolib API. > > Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> > --- > arch/arm/mach-s3c24xx/mach-mini2440.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c > b/arch/arm/mach-s3c24xx/mach-mini2440.c index f092b18..bd6d252 100644 > --- a/arch/arm/mach-s3c24xx/mach-mini2440.c > +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c > @@ -634,8 +634,8 @@ static void __init mini2440_init(void) > s3c_gpio_cfgpin(S3C2410_GPC(0), S3C2410_GPC0_LEND); > > /* Turn the backlight early on */ > - WARN_ON(gpio_request(S3C2410_GPG(4), "backlight")); > - gpio_direction_output(S3C2410_GPG(4), 1); > + WARN_ON(gpio_request_one(S3C2410_GPG(4), GPIOF_OUT_INIT_HIGH, NULL)); > + gpio_free(S3C2410_GPG(4)); > > /* remove pullup on optional PWM backlight -- unused on 3.5 and 7"s */ > s3c_gpio_setpull(S3C2410_GPB(1), S3C_GPIO_PULL_UP); Acked-by: jbe@pengutronix.de
diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c index f092b18..bd6d252 100644 --- a/arch/arm/mach-s3c24xx/mach-mini2440.c +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c @@ -634,8 +634,8 @@ static void __init mini2440_init(void) s3c_gpio_cfgpin(S3C2410_GPC(0), S3C2410_GPC0_LEND); /* Turn the backlight early on */ - WARN_ON(gpio_request(S3C2410_GPG(4), "backlight")); - gpio_direction_output(S3C2410_GPG(4), 1); + WARN_ON(gpio_request_one(S3C2410_GPG(4), GPIOF_OUT_INIT_HIGH, NULL)); + gpio_free(S3C2410_GPG(4)); /* remove pullup on optional PWM backlight -- unused on 3.5 and 7"s */ s3c_gpio_setpull(S3C2410_GPB(1), S3C_GPIO_PULL_UP);
The backlight gpio must not be left requested in the board code, otherwise s3c24xx_led driver can't successfully claim it. So request the backlight gpio, configure it to proper state and gpio_free right away. This change is required for converting the s3c24xx_led driver to the gpiolib API. Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> --- arch/arm/mach-s3c24xx/mach-mini2440.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)