diff mbox

[1/2] arm/dts: Add AM33XX basic pinctrl support

Message ID 1341479616-18630-2-git-send-email-anilkumar@ti.com
State New, archived
Headers show

Commit Message

AnilKumar, Chimata July 5, 2012, 9:13 a.m. UTC
Adds basic pinctrl support for AM33XX family of devices. This patch
is based on the pinctrl-simple driver submitted by Tony Lindgren's
here: http://lwn.net/Articles/496075/

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Tony Lindgren July 6, 2012, 8:23 a.m. UTC | #1
* AnilKumar Ch <anilkumar@ti.com> [120705 02:18]:
> Adds basic pinctrl support for AM33XX family of devices. This patch
> is based on the pinctrl-simple driver submitted by Tony Lindgren's
> here: http://lwn.net/Articles/496075/
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 59509c4..85def31 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -40,6 +40,18 @@
>  		};
>  	};
>  
> +	am3358_pinmux: pinmux@44E10800 {
> +		compatible = "ti,omap4-padconf";
> +		reg = <0x44E10800 0x0338>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		#pinctrl-cells = <2>;
> +		pinctrl-simple,register-width = <32>;
> +		pinctrl-simple,function-mask = <0x7>;
> +		pinctrl-simple,function-off = <0xffffffff>;
> +		pinctrl-simple,pinconf-mask = <0x78>;
> +	};
> +

You might want to update to the latest version, which is now called
pinctrl-single instead of pinctrl-simple. Should be easy to update,
note that we're still waiting on people to comment on the binding,
so you might want to wait a bit before reposting so we have the
driver merged.

Regards,

Tony
AnilKumar, Chimata July 9, 2012, 1:37 p.m. UTC | #2
Hi Tony,

Thanks for reviewing.

On Fri, Jul 06, 2012 at 13:53:44, Tony Lindgren wrote:
> * AnilKumar Ch <anilkumar@ti.com> [120705 02:18]:
> > Adds basic pinctrl support for AM33XX family of devices. This patch
> > is based on the pinctrl-simple driver submitted by Tony Lindgren's
> > here: http://lwn.net/Articles/496075/
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> >  arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 59509c4..85def31 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -40,6 +40,18 @@
> >  		};
> >  	};
> >  
> > +	am3358_pinmux: pinmux@44E10800 {
> > +		compatible = "ti,omap4-padconf";
> > +		reg = <0x44E10800 0x0338>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		#pinctrl-cells = <2>;
> > +		pinctrl-simple,register-width = <32>;
> > +		pinctrl-simple,function-mask = <0x7>;
> > +		pinctrl-simple,function-off = <0xffffffff>;
> > +		pinctrl-simple,pinconf-mask = <0x78>;
> > +	};
> > +
> 
> You might want to update to the latest version, which is now called
> pinctrl-single instead of pinctrl-simple. Should be easy to update,
> note that we're still waiting on people to comment on the binding,
> so you might want to wait a bit before reposting so we have the
> driver merged.

In that case, I will submit the patches with respect to pinctrl-single
after it is available in linux-next tree.

Thanks
AnilKumar
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 59509c4..85def31 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -40,6 +40,18 @@ 
 		};
 	};
 
+	am3358_pinmux: pinmux@44E10800 {
+		compatible = "ti,omap4-padconf";
+		reg = <0x44E10800 0x0338>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		#pinctrl-cells = <2>;
+		pinctrl-simple,register-width = <32>;
+		pinctrl-simple,function-mask = <0x7>;
+		pinctrl-simple,function-off = <0xffffffff>;
+		pinctrl-simple,pinconf-mask = <0x78>;
+	};
+
 	/*
 	 * XXX: Use a flat representation of the AM33XX interconnect.
 	 * The real AM33XX interconnect network is quite complex.Since