| Message ID | 1341564590-14024-1-git-send-email-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > The sys_nirq2 is used for twl6040, make sure the pin is configured > correctly. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- Should remove the boot-loader pin-muxing dependency. Was this the reason, Audio had some issues on OMAP4430 SDP as reported by Russell ? FWIW: Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
On 07/06/2012 11:02 AM, Shilimkar, Santosh wrote: > On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: >> The sys_nirq2 is used for twl6040, make sure the pin is configured >> correctly. >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >> --- > Should remove the boot-loader pin-muxing dependency. > Was this the reason, Audio had some issues on OMAP4430 > SDP as reported by Russell ? The boot loader never configured the sys_nirq2, I have sent a patch for u-boot to do this, but it is said that the kernel should take care of this. We did not had jack detection working with upstream u-boot, kernel (I have patched u-boot so I have not seen this issue). Now if the board is booted without HS connected, upon connecting the HS we will recognize it and it should be all fine. So yes this was the reason why Russell had issues with audio.
+ Russell On Fri, Jul 6, 2012 at 2:52 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > On 07/06/2012 11:02 AM, Shilimkar, Santosh wrote: >> On Fri, Jul 6, 2012 at 2:19 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: >>> The sys_nirq2 is used for twl6040, make sure the pin is configured >>> correctly. >>> >>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >>> --- >> Should remove the boot-loader pin-muxing dependency. >> Was this the reason, Audio had some issues on OMAP4430 >> SDP as reported by Russell ? > > The boot loader never configured the sys_nirq2, I have sent a patch for u-boot > to do this, but it is said that the kernel should take care of this. > > We did not had jack detection working with upstream u-boot, kernel (I have > patched u-boot so I have not seen this issue). > Now if the board is booted without HS connected, upon connecting the HS we > will recognize it and it should be all fine. > So yes this was the reason why Russell had issues with audio. > Thanks Peter for tracking it down. Regards santosh
Hi, On 07/06/2012 10:49 AM, Peter Ujfalusi wrote: > The sys_nirq2 is used for twl6040, make sure the pin is configured > correctly. Please ignore this two patch, I'll resend them with the correct MUX config. By mistake I have set MUX_MODE1, while it must be set MUX_MODE0. It was working with MUX_MODE1, but it is not aligned with the TRM... Sorry, Péter > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > arch/arm/mach-omap2/board-4430sdp.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c > index c4e17641..050cc8e 100644 > --- a/arch/arm/mach-omap2/board-4430sdp.c > +++ b/arch/arm/mach-omap2/board-4430sdp.c > @@ -827,6 +827,9 @@ static void __init omap_4430sdp_display_init(void) > #ifdef CONFIG_OMAP_MUX > static struct omap_board_mux board_mux[] __initdata = { > OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT), > + /* NIRQ2 for twl6040 */ > + OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 | > + OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE), > { .reg_offset = OMAP_MUX_TERMINATOR }, > }; > >
diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index c4e17641..050cc8e 100644 --- a/arch/arm/mach-omap2/board-4430sdp.c +++ b/arch/arm/mach-omap2/board-4430sdp.c @@ -827,6 +827,9 @@ static void __init omap_4430sdp_display_init(void) #ifdef CONFIG_OMAP_MUX static struct omap_board_mux board_mux[] __initdata = { OMAP4_MUX(USBB2_ULPITLL_CLK, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT), + /* NIRQ2 for twl6040 */ + OMAP4_MUX(SYS_NIRQ2, OMAP_MUX_MODE1 | + OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE), { .reg_offset = OMAP_MUX_TERMINATOR }, };
The sys_nirq2 is used for twl6040, make sure the pin is configured correctly. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- arch/arm/mach-omap2/board-4430sdp.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)