From patchwork Tue Jul 17 11:33:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 1204761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4FA073FD9C for ; Tue, 17 Jul 2012 11:38:09 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sr62D-0003Kk-Ox; Tue, 17 Jul 2012 11:33:45 +0000 Received: from mail-bk0-f49.google.com ([209.85.214.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Sr626-0003KW-Hz for linux-arm-kernel@lists.infradead.org; Tue, 17 Jul 2012 11:33:40 +0000 Received: by bkcji2 with SMTP id ji2so214553bkc.36 for ; Tue, 17 Jul 2012 04:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=opaUUkqNbCIZrQarrO3Us8opiKWC3FgG9WOPLFq8Dls=; b=RgwWcg4ipNzFgsUteF6QVdUTmIVtllWNWWdgnbFavd+dTqz6Iqs7onSnNVpCb4ZRaf NbTQrWwi2K61zqKxvK0199pUHfPNuhYkJMGUiYOHC2Nht3IbpzTvE3xuN6DyS51j7prM kXdK8DB6Jk93cPWwnGJctDbNpD89UUT8wkTP95XWbZWOTbzENW1ggLFpL2mKn/K4Szuw 95arEdVRewF1U3vEb42uvFHkNqGy4DDi0aWBijwkiqEJbz2l0eakjzou4W/dTFH74pCp tItQ3DB9EHFzljpQUt8yRXYxWh3TBefyExwWxhAMzT2df6VEoQPjEqOR2001enoU8WDj FDFA== Received: by 10.204.154.74 with SMTP id n10mr930586bkw.60.1342524812314; Tue, 17 Jul 2012 04:33:32 -0700 (PDT) Received: from fambox.fritz.box (p548B64A6.dip.t-dialin.net. [84.139.100.166]) by mx.google.com with ESMTPS id gq2sm9752082bkc.13.2012.07.17.04.33.30 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 Jul 2012 04:33:31 -0700 (PDT) From: Sedat Dilek To: Tony Luck , Fenghua Yu , Linus Walleij , Samuel Ortiz , Andrew Morton , David Howells , "Srivatsa S. Bhat" , "Theodore Ts'o" , "David S. Miller" , Eric Dumazet , "H. Peter Anvin" , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org, "Stephen Rothwell" Subject: [PATCH -next] random: Remove remaining relicts of rand_initialize_irq() Date: Tue, 17 Jul 2012 13:33:13 +0200 Message-Id: <1342524793-2522-1-git-send-email-sedat.dilek@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sedat.dilek[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Sedat Dilek X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org rand_initialize_irq() was removed here: commit 946672f548682905d8ecdab33bb6e2c705418505 "random: remove rand_initialize_irq()" The AB3100 mfd-driver is the only driver still using it and breaks with the following error-messages in linux-next (next-20120717): ... drivers/built-in.o: In function `ab3100_probe': ab3100-core.c:(.devinit.text+0xbf97): undefined reference to `rand_initialize_irq' Fix this issue and remove all remaining relicts of rand_initialize_irq(). Might be worth to fold-in these changes into the original commit. Tested against linux-next (next-20120717) on a Ubuntu/precise AMD64 host. [ v2: Polish up subject and commit message ] Signed-off-by: Sedat Dilek Acked-by: Linus Walleij --- arch/ia64/kernel/irq_ia64.c | 1 - drivers/mfd/ab3100-core.c | 2 -- include/linux/random.h | 2 -- 3 files changed, 5 deletions(-) diff --git a/arch/ia64/kernel/irq_ia64.c b/arch/ia64/kernel/irq_ia64.c index 5c3e088..1034884 100644 --- a/arch/ia64/kernel/irq_ia64.c +++ b/arch/ia64/kernel/irq_ia64.c @@ -23,7 +23,6 @@ #include #include #include -#include /* for rand_initialize_irq() */ #include #include #include diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c index e799050..78fca29 100644 --- a/drivers/mfd/ab3100-core.c +++ b/drivers/mfd/ab3100-core.c @@ -934,8 +934,6 @@ static int __devinit ab3100_probe(struct i2c_client *client, IRQF_ONESHOT, "ab3100-core", ab3100); if (err) goto exit_no_irq; - /* This real unpredictable IRQ is of course sampled for entropy */ - rand_initialize_irq(client->irq); err = abx500_register_ops(&client->dev, &ab3100_ops); if (err) diff --git a/include/linux/random.h b/include/linux/random.h index 29e217a..ac621ce 100644 --- a/include/linux/random.h +++ b/include/linux/random.h @@ -48,8 +48,6 @@ struct rnd_state { #ifdef __KERNEL__ -extern void rand_initialize_irq(int irq); - extern void add_device_randomness(const void *, unsigned int); extern void add_input_randomness(unsigned int type, unsigned int code, unsigned int value);