| Message ID | 1343843371-14143-5-git-send-email-matt@genesi-usa.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 1, 2012 at 2:49 PM, Matt Sealey <matt@genesi-usa.com> wrote: > Since we're removing Efika MX support from the tree (for now), remove > the hack present in the USB host driver since it will never run and > isn't useful on any other systems. > > Signed-off-by: Matt Sealey <matt@genesi-usa.com> You should Cc linux-usb list and the USB maintainer on this one. Regards, Fabio Estevam
On Sun, Sep 9, 2012 at 10:00 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Wed, Aug 1, 2012 at 2:49 PM, Matt Sealey <matt@genesi-usa.com> wrote: >> Since we're removing Efika MX support from the tree (for now), remove >> the hack present in the USB host driver since it will never run and >> isn't useful on any other systems. >> >> Signed-off-by: Matt Sealey <matt@genesi-usa.com> > > You should Cc linux-usb list and the USB maintainer on this one. Good call, I actually thought I did that (git send-email is not my best friend this month). Luckily though with the board removal patches in Shawn's tree going up at some point, this code can't be compiled anyway so this patch not making it in will not ruin anyone's day. I'll resubmit it in the near future but I'm not considering it top priority because of the abovementioned reason.
On Mon, Sep 10, 2012 at 10:03:15AM -0500, Matt Sealey wrote: > On Sun, Sep 9, 2012 at 10:00 PM, Fabio Estevam <festevam@gmail.com> wrote: > > On Wed, Aug 1, 2012 at 2:49 PM, Matt Sealey <matt@genesi-usa.com> wrote: > >> Since we're removing Efika MX support from the tree (for now), remove > >> the hack present in the USB host driver since it will never run and > >> isn't useful on any other systems. > >> > >> Signed-off-by: Matt Sealey <matt@genesi-usa.com> > > > > You should Cc linux-usb list and the USB maintainer on this one. > > Good call, I actually thought I did that (git send-email is not my > best friend this month). > > Luckily though with the board removal patches in Shawn's tree going up > at some point, this code can't be compiled anyway so this patch not > making it in will not ruin anyone's day. I'll resubmit it in the near > future but I'm not considering it top priority because of the > abovementioned reason. > Ok, I will drop this one from my tree, and send arch/arm/mach-imx changes alone. And then the patch can be resubmitted to linux-usb tree later.
Anyone got a clue who the actual USB maintainer is who cares about ehci-mxc? Best search through the maintainers file is Li Yang <leoli@freescale.com> and of course I could always nudge David Brownell, Sascha (your name is at the top of the file!) I was going to resubmit on Friday and push an alternative patch to the chipidea driver but I can't figure out who's in control, if the only nitpick is I didn't CC the right people then this could take many, many submissions while this gets figured out :D Matt Sealey <matt@genesi-usa.com> Product Development Analyst, Genesi USA, Inc. On Sun, Sep 9, 2012 at 10:00 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Wed, Aug 1, 2012 at 2:49 PM, Matt Sealey <matt@genesi-usa.com> wrote: > > Since we're removing Efika MX support from the tree (for now), remove > > the hack present in the USB host driver since it will never run and > > isn't useful on any other systems. > > > > Signed-off-by: Matt Sealey <matt@genesi-usa.com> > > You should Cc linux-usb list and the USB maintainer on this one. > > Regards, > > Fabio Estevam >
On Sun, Dec 23, 2012 at 8:42 AM, Matt Sealey <matt@genesi-usa.com> wrote: > Anyone got a clue who the actual USB maintainer is who cares about ehci-mxc? $ ./scripts/get_maintainer.pl -F drivers/usb/host/ehci-mxc.c Alan Stern <stern@rowland.harvard.edu> (maintainer:USB EHCI DRIVER) Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM) linux-usb@vger.kernel.org (open list:USB EHCI DRIVER) linux-kernel@vger.kernel.org (open list) > Best search through the maintainers file is Li Yang <leoli@freescale.com> > and of course I could always nudge David Brownell, Sascha (your name is at > the top of the file!) > > I was going to resubmit on Friday and push an alternative patch to the > chipidea driver but I can't figure out who's in control, if the only nitpick > is I didn't CC the right people then this could take many, many submissions > while this gets figured out :D $ ./scripts/get_maintainer.pl -F drivers/usb/chipidea/host.c Alexander Shishkin <alexander.shishkin@linux.intel.com> (maintainer:CHIPIDEA USB HIGH...) Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM) linux-usb@vger.kernel.org (open list:CHIPIDEA USB HIGH...) linux-kernel@vger.kernel.org (open list) Regards, Fabio Estevam
diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index c778ffe..062f871 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -118,7 +118,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) struct usb_hcd *hcd; struct resource *res; int irq, ret; - unsigned int flags; struct ehci_mxc_priv *priv; struct device *dev = &pdev->dev; struct ehci_hcd *ehci; @@ -235,25 +234,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) if (ret) goto err_add; - if (pdata->otg) { - /* - * efikamx and efikasb have some hardware bug which is - * preventing usb to work unless CHRGVBUS is set. - * It's in violation of USB specs - */ - if (machine_is_mx51_efikamx() || machine_is_mx51_efikasb()) { - flags = usb_phy_io_read(pdata->otg, - ULPI_OTG_CTRL); - flags |= ULPI_OTG_CTRL_CHRGVBUS; - ret = usb_phy_io_write(pdata->otg, flags, - ULPI_OTG_CTRL); - if (ret) { - dev_err(dev, "unable to set CHRVBUS\n"); - goto err_add; - } - } - } - return 0; err_add:
Since we're removing Efika MX support from the tree (for now), remove the hack present in the USB host driver since it will never run and isn't useful on any other systems. Signed-off-by: Matt Sealey <matt@genesi-usa.com> --- drivers/usb/host/ehci-mxc.c | 20 -------------------- 1 file changed, 20 deletions(-)