From patchwork Mon Aug 6 12:55:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pieterg@gmx.com X-Patchwork-Id: 1278861 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id E1B9BDF288 for ; Mon, 6 Aug 2012 12:59:07 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SyMqm-0006rj-Kg; Mon, 06 Aug 2012 12:56:00 +0000 Received: from smtp-1.concepts.nl ([213.197.30.124]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SyMqj-0006rW-Cd for linux-arm-kernel@lists.infradead.org; Mon, 06 Aug 2012 12:55:58 +0000 Received: from c3404277.ftth.concepts.nl ([195.64.66.119] helo=mx1.grimmerink.nl) by smtp-1.concepts.nl with esmtps (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1SyMqd-0007x6-Ch; Mon, 06 Aug 2012 14:55:51 +0200 Received: from laptoppieter.wielewaal (laptoppieter.wielewaal [10.9.0.58]) by mx1.grimmerink.nl (Postfix) with ESMTP id D03E66A0C7; Mon, 6 Aug 2012 14:55:45 +0200 (CEST) From: pieterg@gmx.com To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] pxafb: fix BLW / ELW smart panel timing parameters Date: Mon, 6 Aug 2012 14:55:43 +0200 Message-Id: <1344257743-25692-1-git-send-email-pieterg@gmx.com> X-Mailer: git-send-email 1.7.9.5 X-Concepts-MailScanner-Information: Please contact abuse@concepts.nl for more information X-Concepts-MailScanner-ID: 1SyMqd-0007x6-Ch X-Concepts-MailScanner: Found to be clean X-Concepts-MailScanner-SpamCheck: X-Concepts-MailScanner-From: pieterg@gmx.com X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pieterg[at]gmx.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [213.197.30.124 listed in list.dnswl.org] 0.0 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=pieterg%40gmx.com; ip=213.197.30.124; r=merlin.infradead.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Pieter Grimmerink X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Pieter Grimmerink The parameters were swapped; LCCR1[BLW] configures rd_pulse_width and wr_pulse_width LCCR1[ELW] configures a0csrd_set_hld and a0cswr_set_hld --- drivers/video/pxafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index 3f90255..04c395a 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c @@ -1230,18 +1230,18 @@ static unsigned int __smart_timing(unsigned time_ns, unsigned long lcd_clk) static void setup_smart_timing(struct pxafb_info *fbi, struct fb_var_screeninfo *var) { struct pxafb_mach_info *inf = fbi->dev->platform_data; struct pxafb_mode_info *mode = &inf->modes[0]; unsigned long lclk = clk_get_rate(fbi->clk); unsigned t1, t2, t3, t4; - t1 = max(mode->a0csrd_set_hld, mode->a0cswr_set_hld); - t2 = max(mode->rd_pulse_width, mode->wr_pulse_width); + t1 = max(mode->rd_pulse_width, mode->wr_pulse_width); + t2 = max(mode->a0csrd_set_hld, mode->a0cswr_set_hld); t3 = mode->op_hold_time; t4 = mode->cmd_inh_time; fbi->reg_lccr1 = LCCR1_DisWdth(var->xres) | LCCR1_BegLnDel(__smart_timing(t1, lclk)) | LCCR1_EndLnDel(__smart_timing(t2, lclk)) | LCCR1_HorSnchWdth(__smart_timing(t3, lclk));