| Message ID | 1344262737-6662-5-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Felipe, On Monday 06 August 2012 07:48 PM, Felipe Balbi wrote: > this helps us reduce unnecessary pm transitions > in case we have another i2c message been started > soon. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/i2c/busses/i2c-omap.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 60928f2..22efaba 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -645,7 +645,8 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) > > omap_i2c_wait_for_bb(dev); > out: > - pm_runtime_put(dev->dev); > + pm_runtime_mark_last_busy(dev->dev); > + pm_runtime_put_autosuspend(dev->dev); > return r; > } > > @@ -1113,6 +1114,9 @@ omap_i2c_probe(struct platform_device *pdev) > dev->regs = (u8 *)reg_map_ip_v1; > > pm_runtime_enable(dev->dev); > + pm_runtime_set_autosuspend_delay(dev->dev, 1000); > + pm_runtime_use_autosuspend(dev->dev); > + > r = pm_runtime_get_sync(dev->dev); > if (IS_ERR_VALUE(r)) > goto err_free_mem; > @@ -1189,7 +1193,7 @@ omap_i2c_probe(struct platform_device *pdev) > > of_i2c_register_devices(adap); > > - pm_runtime_put(dev->dev); Should we mark it last busy stamp here here? Or it may not take effect till the first transaction. > + pm_runtime_put_autosuspend(dev->dev); > > return 0; >
Hi, On Mon, Aug 06, 2012 at 05:18:57PM +0300, Felipe Balbi wrote: > this helps us reduce unnecessary pm transitions > in case we have another i2c message been started > soon. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/i2c/busses/i2c-omap.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 60928f2..22efaba 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -645,7 +645,8 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) > > omap_i2c_wait_for_bb(dev); > out: > - pm_runtime_put(dev->dev); > + pm_runtime_mark_last_busy(dev->dev); > + pm_runtime_put_autosuspend(dev->dev); > return r; > } > > @@ -1113,6 +1114,9 @@ omap_i2c_probe(struct platform_device *pdev) > dev->regs = (u8 *)reg_map_ip_v1; > > pm_runtime_enable(dev->dev); > + pm_runtime_set_autosuspend_delay(dev->dev, 1000); > + pm_runtime_use_autosuspend(dev->dev); > + > r = pm_runtime_get_sync(dev->dev); > if (IS_ERR_VALUE(r)) > goto err_free_mem; > @@ -1189,7 +1193,7 @@ omap_i2c_probe(struct platform_device *pdev) > > of_i2c_register_devices(adap); > > - pm_runtime_put(dev->dev); > + pm_runtime_put_autosuspend(dev->dev); Probably... nice catch. Will send v2
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 60928f2..22efaba 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -645,7 +645,8 @@ omap_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num) omap_i2c_wait_for_bb(dev); out: - pm_runtime_put(dev->dev); + pm_runtime_mark_last_busy(dev->dev); + pm_runtime_put_autosuspend(dev->dev); return r; } @@ -1113,6 +1114,9 @@ omap_i2c_probe(struct platform_device *pdev) dev->regs = (u8 *)reg_map_ip_v1; pm_runtime_enable(dev->dev); + pm_runtime_set_autosuspend_delay(dev->dev, 1000); + pm_runtime_use_autosuspend(dev->dev); + r = pm_runtime_get_sync(dev->dev); if (IS_ERR_VALUE(r)) goto err_free_mem; @@ -1189,7 +1193,7 @@ omap_i2c_probe(struct platform_device *pdev) of_i2c_register_devices(adap); - pm_runtime_put(dev->dev); + pm_runtime_put_autosuspend(dev->dev); return 0;
this helps us reduce unnecessary pm transitions in case we have another i2c message been started soon. Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/i2c/busses/i2c-omap.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)