| Message ID | 1344419650-5389-4-git-send-email-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Peter, Thank you very much for the patch series. I probably will have some time to look into it more deeply on the next week. Currently, only a small comment, please see below. On 08/08/12 12:54, Peter Ujfalusi wrote: > These boards have similar audio setup and they can all use the same driver > for audio support if it is enabled in the kernel config. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > arch/arm/mach-omap2/board-cm-t35.c | 1 + > arch/arm/mach-omap2/board-devkit8000.c | 1 + > arch/arm/mach-omap2/board-igep0020.c | 1 + > arch/arm/mach-omap2/board-omap3beagle.c | 1 + > arch/arm/mach-omap2/board-omap3evm.c | 1 + > arch/arm/mach-omap2/board-overo.c | 1 + > 6 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c > index 97d7190..b73fa5c 100644 > --- a/arch/arm/mach-omap2/board-cm-t35.c > +++ b/arch/arm/mach-omap2/board-cm-t35.c > @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) > cm_t35_init_ethernet(); > cm_t35_init_led(); > cm_t35_init_display(); > + omap_twl4030_audio_init("overo", 26000000); Can the card_name here be "cm-t3x" ? [...]
Hi Igor, On 08/08/2012 03:24 PM, Igor Grinberg wrote: >> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c >> index 97d7190..b73fa5c 100644 >> --- a/arch/arm/mach-omap2/board-cm-t35.c >> +++ b/arch/arm/mach-omap2/board-cm-t35.c >> @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) >> cm_t35_init_ethernet(); >> cm_t35_init_led(); >> cm_t35_init_display(); >> + omap_twl4030_audio_init("overo", 26000000); > > Can the card_name here be "cm-t3x" ? I have used the "overo" as card name here since what I gathered is that cm-t35 used the sound/soc/omap/overo.c machine driver for audio support. If the card name is changing your existing user space might get confused by the card name change. But sure, I can change the card name to "cm-t3x" if it is better for you.
On 08/08/12 15:29, Peter Ujfalusi wrote: > Hi Igor, > > On 08/08/2012 03:24 PM, Igor Grinberg wrote: >>> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c >>> index 97d7190..b73fa5c 100644 >>> --- a/arch/arm/mach-omap2/board-cm-t35.c >>> +++ b/arch/arm/mach-omap2/board-cm-t35.c >>> @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) >>> cm_t35_init_ethernet(); >>> cm_t35_init_led(); >>> cm_t35_init_display(); >>> + omap_twl4030_audio_init("overo", 26000000); >> >> Can the card_name here be "cm-t3x" ? > > I have used the "overo" as card name here since what I gathered is that cm-t35 > used the sound/soc/omap/overo.c machine driver for audio support. > If the card name is changing your existing user space might get confused by > the card name change. > But sure, I can change the card name to "cm-t3x" if it is better for you. Well, yes I know we will need to adjust the user space. I wanted to change that for a long time and did not get to it... Now, with your patches, it seems like the best time for doing this. Thanks
On 08/08/2012 04:06 PM, Igor Grinberg wrote: > Well, yes I know we will need to adjust the user space. > I wanted to change that for a long time and did not get to it... > Now, with your patches, it seems like the best time for doing this. Done for the v2. You will have card named "cm-t3x".
On 08/09/12 13:21, Peter Ujfalusi wrote: > On 08/08/2012 04:06 PM, Igor Grinberg wrote: >> Well, yes I know we will need to adjust the user space. >> I wanted to change that for a long time and did not get to it... >> Now, with your patches, it seems like the best time for doing this. > > Done for the v2. You will have card named "cm-t3x". Thanks!
* Peter Ujfalusi <peter.ujfalusi@ti.com> [120808 02:54]: > These boards have similar audio setup and they can all use the same driver > for audio support if it is enabled in the kernel config. After the naming changes suggested by Igor: Acked-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 97d7190..b73fa5c 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void) cm_t35_init_ethernet(); cm_t35_init_led(); cm_t35_init_display(); + omap_twl4030_audio_init("overo", 26000000); usb_musb_init(NULL); cm_t35_init_usbh(); diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c index 6567c1c..f834b3e 100644 --- a/arch/arm/mach-omap2/board-devkit8000.c +++ b/arch/arm/mach-omap2/board-devkit8000.c @@ -630,6 +630,7 @@ static void __init devkit8000_init(void) usbhs_init(&usbhs_bdata); omap_nand_flash_init(NAND_BUSWIDTH_16, devkit8000_nand_partitions, ARRAY_SIZE(devkit8000_nand_partitions)); + omap_twl4030_audio_init("omap3beagle", 26000000); /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT); diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c index 7491529..bc7c1ea 100644 --- a/arch/arm/mach-omap2/board-igep0020.c +++ b/arch/arm/mach-omap2/board-igep0020.c @@ -626,6 +626,7 @@ static void __init igep_init(void) igep_flash_init(); igep_leds_init(); + omap_twl4030_audio_init("igep2", 26000000); /* * WLAN-BT combo module from MuRata which has a Marvell WLAN diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index 6202fc7..dd6e4f0 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -519,6 +519,7 @@ static void __init omap3_beagle_init(void) usbhs_init(&usbhs_bdata); omap_nand_flash_init(NAND_BUSWIDTH_16, omap3beagle_nand_partitions, ARRAY_SIZE(omap3beagle_nand_partitions)); + omap_twl4030_audio_init("omap3beagle", 26000000); /* Ensure msecure is mux'd to be able to set the RTC. */ omap_mux_init_signal("sys_drm_msecure", OMAP_PIN_OFF_OUTPUT_HIGH); diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c index ef230a0..1be8f6e 100644 --- a/arch/arm/mach-omap2/board-omap3evm.c +++ b/arch/arm/mach-omap2/board-omap3evm.c @@ -736,6 +736,7 @@ static void __init omap3_evm_init(void) omap3evm_init_smsc911x(); omap3_evm_display_init(); omap3_evm_wl12xx_init(); + omap_twl4030_audio_init("omap3evm", 26000000); } MACHINE_START(OMAP3EVM, "OMAP3 EVM") diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 779734d..7b7db3d 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ b/arch/arm/mach-omap2/board-overo.c @@ -509,6 +509,7 @@ static void __init overo_init(void) overo_display_init(); overo_init_led(); overo_init_keys(); + omap_twl4030_audio_init("overo", 26000000); /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
These boards have similar audio setup and they can all use the same driver for audio support if it is enabled in the kernel config. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- arch/arm/mach-omap2/board-cm-t35.c | 1 + arch/arm/mach-omap2/board-devkit8000.c | 1 + arch/arm/mach-omap2/board-igep0020.c | 1 + arch/arm/mach-omap2/board-omap3beagle.c | 1 + arch/arm/mach-omap2/board-omap3evm.c | 1 + arch/arm/mach-omap2/board-overo.c | 1 + 6 files changed, 6 insertions(+), 0 deletions(-)