From patchwork Wed Aug 8 14:47:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1296271 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 2515BDF223 for ; Wed, 8 Aug 2012 14:52:12 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sz7Ya-0005Qz-JN; Wed, 08 Aug 2012 14:48:20 +0000 Received: from moutng.kundenserver.de ([212.227.126.171]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sz7Xv-0005Hv-3X for linux-arm-kernel@lists.infradead.org; Wed, 08 Aug 2012 14:47:40 +0000 Received: from klappe2.boeblingen.de.ibm.com (deibp9eh1--blueice3n2.emea.ibm.com [195.212.29.180]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MCObR-1SqYyK1Df7-009ppd; Wed, 08 Aug 2012 16:47:33 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/11] mfd/asic3: fix asic3_mfd_probe return value Date: Wed, 8 Aug 2012 16:47:19 +0200 Message-Id: <1344437248-20560-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1344437248-20560-1-git-send-email-arnd@arndb.de> References: <1344437248-20560-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:BQTU6HmlEB1Dwy+y5HiETfO3iNX7jVzrTGmq0MiEmQ7 1TTjncTNUAeZvBXoQRDh7F8HORGX6MIoQQNeTTi06V+5yVVfK4 yfAn0tWceZQfOA/tG9MrS7gE4WAXqHCotIx6gJJP0K3H0VeBfb pj+fSqaJRQhNZDonse4TTzIQIsmQhw4xb0jv/sTv7H0i0dwGvB XZUfz/cM15EtRYetDa9mPqKqL/uhBlhT/IIWiBscLNOBi/7ozd 2jI3u2P/qP4nGxbAVhOmHnhimnq21Dc5Z64p6lXQJbrgcloPNk wwRzyqh6uTWXHC+bAzzddqhtWEbKgNvymWI7ZpM9Z+jHZP0AJh +KomE6mJ3wiLKxJeColMpFR6OOT6psetGSKAgpPrue1k0HG9jx MJmZDBmzjztgC6JOFJITBc/z3/Bn1f5QhY= X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.171 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Samuel Ortiz , Arnd Bergmann , linux-kernel@vger.kernel.org, arm@kernel.org, Philipp Zabel , Paul Parsons X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org In commit 4f304245b "mfd: Set asic3 DS1WM clock_rate", a possible path through asic3_mfd_probe was introduced that would lead to an unpredictable return value, if everything succeeds but there are pdata->leds is NULL. This was reported correctly by gcc. Without this patch, building magician_defconfig results in: drivers/mfd/asic3.c: In function 'asic3_mfd_probe': drivers/mfd/asic3.c:940:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Arnd Bergmann Cc: Paul Parsons Cc: Philipp Zabel Cc: Samuel Ortiz --- drivers/mfd/asic3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index 383421b..683e18a 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -925,6 +925,7 @@ static int __init asic3_mfd_probe(struct platform_device *pdev, goto out; } + ret = 0; if (pdata->leds) { int i;