| Message ID | 1344437248-20560-5-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 08, 2012 at 04:47:21PM +0200, Arnd Bergmann wrote: > Commit fc67a597a "ARM: ux500: Remove temporary snowball_of_platform_devs > enablement structure" removed the only user of this variable, but did > not actually remove the array itself. > > Without this patch, building u8500_defconfig results in: > > arch/arm/mach-ux500/board-mop500.c:729:32: warning: 'snowball_of_platform_devs' defined but not used [-Wunused-variable] I've already sent a patch that does this: https://lkml.org/lkml/2012/7/31/305 Just waiting on Linus to review the set.
On Wednesday 08 August 2012, Lee Jones wrote: > On Wed, Aug 08, 2012 at 04:47:21PM +0200, Arnd Bergmann wrote: > > Commit fc67a597a "ARM: ux500: Remove temporary snowball_of_platform_devs > > enablement structure" removed the only user of this variable, but did > > not actually remove the array itself. > > > > Without this patch, building u8500_defconfig results in: > > > > arch/arm/mach-ux500/board-mop500.c:729:32: warning: 'snowball_of_platform_devs' defined but not used [-Wunused-variable] > > I've already sent a patch that does this: > > https://lkml.org/lkml/2012/7/31/305 > > Just waiting on Linus to review the set. Ok, I've removed my version. Arnd
diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c index 8674a89..2a732f7 100644 --- a/arch/arm/mach-ux500/board-mop500.c +++ b/arch/arm/mach-ux500/board-mop500.c @@ -726,11 +726,6 @@ MACHINE_END #ifdef CONFIG_MACH_UX500_DT -static struct platform_device *snowball_of_platform_devs[] __initdata = { - &snowball_led_dev, - &snowball_key_dev, -}; - struct of_dev_auxdata u8500_auxdata_lookup[] __initdata = { /* Requires DMA and call-back bindings. */ OF_DEV_AUXDATA("arm,pl011", 0x80120000, "uart0", &uart0_plat),
Commit fc67a597a "ARM: ux500: Remove temporary snowball_of_platform_devs enablement structure" removed the only user of this variable, but did not actually remove the array itself. Without this patch, building u8500_defconfig results in: arch/arm/mach-ux500/board-mop500.c:729:32: warning: 'snowball_of_platform_devs' defined but not used [-Wunused-variable] Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> --- arch/arm/mach-ux500/board-mop500.c | 5 ----- 1 file changed, 5 deletions(-)